From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 27436A0C4E
for <public@inbox.dpdk.org>; Fri, 30 Jul 2021 11:38:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 10CD2410F5;
Fri, 30 Jul 2021 11:38:11 +0200 (CEST)
Received: from mail-io1-f47.google.com (mail-io1-f47.google.com
[209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id 117FE4067A
for <stable@dpdk.org>; Fri, 30 Jul 2021 11:38:09 +0200 (CEST)
Received: by mail-io1-f47.google.com with SMTP id y9so10693631iox.2
for <stable@dpdk.org>; Fri, 30 Jul 2021 02:38:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc:content-transfer-encoding;
bh=E2waDA9+1v+2vL0tlVR5prMx7K8fT5wZpiT5q19Gl58=;
b=XW2CEx7PnQXvKEKbie1bQcMTuiovUHyA8ckT9qQi2BPr1BzHdsF6vIgGs5bFHVWKUR
z3xtoem/BynpJlx25PNruHk13A3em5QvLoo8I+VdtLpIg+y+iGkXUsufDd8UFecXRSFZ
UavoZ3oJCJ3+/iDelDorhiitb9b0Xsse8A3JXdfuqDGT2Juxfoumjp2V+2yGkO19oZrj
TYK6nzkqbyK7kT+ogkuVImsQ+wIwBkAoIxfbuQJY501/t7q/G4+FPRpk7U2ejIybudrV
RoUBLr82VNpFO4lAbHrmEsrvjTvAkIRzvfEJ1uyRUha0J1mGdNYgPqw2b2Z4y+v0CLLM
yCJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=E2waDA9+1v+2vL0tlVR5prMx7K8fT5wZpiT5q19Gl58=;
b=bH3MuLY5cO9bHnITzMfW5/L43OBR/Udp3SZ1DEhl4ec/Jr0AUFtE7I8JA0eVT4mlOZ
YDoW3kgAuPG2h6xGEbSdxSjRXEACleiAe5+CIV6aSy6p41EH32WJcZD5C5fd2wpA455Y
ufToY6HlOowiNYP5QdKUJ7MQVzeRc1IZiQmavpFe/z/TRaoISVOVqrZXEzJmod5GUMGW
QHlllHq/kqrnUuXLqrTFMiF7AVLfQv2oMgK/4V2OyorZ33wtTgUwUHCkS7h9Q1r0R/jp
jBZsPIA8krU8OKqy033BJs6w+cB1SEm+a7MErWfg23G23PIcuOm5PuFa5bXZr3aomaEX
dmKw==
X-Gm-Message-State: AOAM531pRH8uJeh03aZa+a4bSy2yC29UfMHr/QQ9lrKCkG4pNY98k/Mb
vcnfQuC7HVVmfIjuRCYOGTGZjsp0AdKcjmZw1tRZNQ==
X-Google-Smtp-Source: ABdhPJx7mqkYOkaSCQPbDh5vVl6XdNH0YQdZHFK+qnjbmbO0g+xHSeb5xRigH3fk4JeJx3p0ajuLHwnwW14xfLS4BYM=
X-Received: by 2002:a05:6602:d9:: with SMTP id
z25mr379205ioe.154.1627637888463;
Fri, 30 Jul 2021 02:38:08 -0700 (PDT)
MIME-Version: 1.0
References: <20210712170153.11508-1-ghalem.boudour@6wind.com>
<20210730083441.7465-1-olivier.matz@6wind.com>
In-Reply-To: <20210730083441.7465-1-olivier.matz@6wind.com>
From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= <mk@semihalf.com>
Date: Fri, 30 Jul 2021 11:37:55 +0200
Message-ID: <CAJMMOfOmkW49-awFfA+NV0LACSfH7yugYxxhbuXtUHhstMz5dw@mail.gmail.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev <dev@dpdk.org>, Ghalem Boudour <ghalem.boudour@6wind.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>, "Chauskin, Igor" <igorch@amazon.com>,
Marcin Wojtas <mw@semihalf.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-stable] [PATCH v2] net/ena: enable multi segment in Tx
offload flags
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
pt., 30 lip 2021 o 10:35 Olivier Matz <olivier.matz@6wind.com> napisa=C5=82=
(a):
>
> From: Ghalem Boudour <ghalem.boudour@6wind.com>
>
> The DPDK ENA driver does not provide multi-segment tx offload capability.
> Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by
> default, and always set it in dev->data->dev_conf.txmode.offload.
>
> This flag in not listed in doc/guides/nics/features/default.ini, so
> ena.ini does not need to be updated.
>
> Fixes: 1173fca25af9 ("ena: add polling-mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ghalem Boudour <ghalem.boudour@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
> ---
>
> v2
> * set DEV_TX_OFFLOAD_MULTI_SEGS in dev->data->dev_conf.txmode.offload
> * add Fixes and Cc stable
>
> drivers/net/ena/ena_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index dfe68279fa..b59451034c 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1981,6 +1981,7 @@ static int ena_dev_configure(struct rte_eth_dev *de=
v)
>
> if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
> dev->data->dev_conf.rxmode.offloads |=3D DEV_RX_OFFLOAD_R=
SS_HASH;
> + dev->data->dev_conf.txmode.offloads |=3D DEV_TX_OFFLOAD_MULTI_SEG=
S;
>
> adapter->tx_selected_offloads =3D dev->data->dev_conf.txmode.offl=
oads;
> adapter->rx_selected_offloads =3D dev->data->dev_conf.rxmode.offl=
oads;
> @@ -2055,6 +2056,7 @@ static int ena_infos_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_TCP_CKSUM;
>
> rx_feat |=3D DEV_RX_OFFLOAD_JUMBO_FRAME;
> + tx_feat |=3D DEV_TX_OFFLOAD_MULTI_SEGS;
>
> /* Inform framework about available features */
> dev_info->rx_offload_capa =3D rx_feat;
> --
> 2.29.2
>