patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Michał Krawczyk" <mk@semihalf.com>
To: dev <dev@dpdk.org>
Cc: upstream@semihalf.com, "Brandes, Shai" <shaibran@amazon.com>,
	 Harman Kalra <hkalra@marvell.com>,
	stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	 Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] bus/pci: assign driver's pointer before mapping
Date: Thu, 24 Feb 2022 15:17:27 +0100	[thread overview]
Message-ID: <CAJMMOfPgaY91Kd_hKtSYWb+H+bKU3qjC1eA+twDrbKq04bYCeg@mail.gmail.com> (raw)
In-Reply-To: <20220119145037.28125-1-mk@semihalf.com>

śr., 19 sty 2022 o 15:50 Michal Krawczyk <mk@semihalf.com> napisał(a):
>
> Patch changing the way of accessing interrupt handle also changed order
> of the rte_pci_map_device() call and rte_pci_device:driver assignment.
> It was causing issues with Write Combine mapping on the Linux platform
> if it was used with the igb_uio module.
>
> Linux implementation of pci_uio_map_resource_by_index(), which is called
> by rte_pci_map_device(), needs access to the device's driver. Otherwise
> it won't be able to check the driver's flags and won't respect them.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: hkalra@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> ---

Hi,
is there any chance that this fix will land for v22.03-rc2? Without
that, we suffer a huge performance impact for the ENA PMD.

Thanks,
Michal

>  drivers/bus/pci/pci_common.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index 4a3a87f24f..def372b67e 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -247,9 +247,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>                         return -ENOMEM;
>                 }
>
> +               dev->driver = dr;
> +
>                 if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
>                         ret = rte_pci_map_device(dev);
>                         if (ret != 0) {
> +                               dev->driver = NULL;
>                                 rte_intr_instance_free(dev->vfio_req_intr_handle);
>                                 dev->vfio_req_intr_handle = NULL;
>                                 rte_intr_instance_free(dev->intr_handle);
> @@ -257,8 +260,6 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>                                 return ret;
>                         }
>                 }
> -
> -               dev->driver = dr;
>         }
>
>         RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
> --
> 2.25.1
>

  reply	other threads:[~2022-02-24 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 14:50 Michal Krawczyk
2022-02-24 14:17 ` Michał Krawczyk [this message]
2022-02-27 19:14 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJMMOfPgaY91Kd_hKtSYWb+H+bKU3qjC1eA+twDrbKq04bYCeg@mail.gmail.com \
    --to=mk@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hkalra@marvell.com \
    --cc=shaibran@amazon.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).