From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D75B6430F1 for ; Thu, 24 Aug 2023 17:24:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E689F40EE1; Thu, 24 Aug 2023 17:24:14 +0200 (CEST) Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by mails.dpdk.org (Postfix) with ESMTP id 81E254067B for ; Thu, 24 Aug 2023 17:24:13 +0200 (CEST) Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-571110eb31bso3165eaf.2 for ; Thu, 24 Aug 2023 08:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1692890652; x=1693495452; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a8utIM6zcuWLmlwxSM02Xy+1EnvMNQZUH4Wdri/k8ho=; b=Idbjx+TAui1EWirxUu6kwRGYUaF4E0F+5p/lBZ29NxbBxdMHUOsb4ZzznrBBlQNH7x kTSHjwV/7pDUvwHZadC4jgpeqB6ySIVc8Iw2Juj4BLt8h53221OJEq9VJZpsGQaUHd6F z5zsVx6LshtvKiWIu5PmGIeOWnGM9jeVsdjK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692890652; x=1693495452; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a8utIM6zcuWLmlwxSM02Xy+1EnvMNQZUH4Wdri/k8ho=; b=A3X2kW4x7Kw4a5NmJgSLvjyR3OOwd4ItOpnmPjgbI6N8C2g69Go89wNYzR1aXSEOcw wNrA0qHhZkLaF6xnnnRGEyv/IZcYJL/gXeJyfJFAZOf3W7m5259v41kcUvfT1pnd0I0E XbCrQ5YEatKAehYzBAp3F0S6/F5heBtieEPrKcWWdBuDsfSowGcbwymjHD+HN+yIZVwH ISOO+L2RvJKxDMA38OHafzxqwF8fcLNsiPRylG0RGTBt5yAkDOgCTLuLxBbPqhKJIKu/ XD8648//zKiolErk00gOtvVN6bGUGRte6vGlAo89nG3L5SO+jfIsutMUW4BLXZIeKJqp W/bA== X-Gm-Message-State: AOJu0YxNJLJ+DjsWc7mVs3Xr7kzo1sVKfwXRIbYVYF2ket1N2K9J/jNf DWEPNDQ0DRPd7bNKOUtd/GYeKvCPDO3v8SShzE+msQ== X-Google-Smtp-Source: AGHT+IEA/B9Kb9YGvUAd8dtwdQDVQ8f9eO7SGW0BNSTozQ4ve/uSoJDsrw3LZZVCPDvorA8Hpc7p8JuPBftR2S1X7Tc= X-Received: by 2002:a4a:3508:0:b0:571:2c8e:d3c0 with SMTP id l8-20020a4a3508000000b005712c8ed3c0mr2147586ooa.0.1692890652654; Thu, 24 Aug 2023 08:24:12 -0700 (PDT) MIME-Version: 1.0 References: <20230818090351.2402519-1-david.marchand@redhat.com> <20230823062911.2483926-1-david.marchand@redhat.com> In-Reply-To: From: Patrick Robb Date: Thu, 24 Aug 2023 11:24:01 -0400 Message-ID: Subject: Re: [PATCH v2] net/iavf: fix checksum offloading To: "Zhang, Qi Z" Cc: David Marchand , "dev@dpdk.org" , "echaudro@redhat.com" , "mkp@redhat.com" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "Sinha, Abhijit" , "Doherty, Declan" , "Nicolau, Radu" Content-Type: multipart/alternative; boundary="000000000000fed82e0603acd137" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --000000000000fed82e0603acd137 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi David, you can ignore the failures UNH reported for this patch - we made a mistake reconfiguring jenkins for the refactored unit test suite. As discussed we are not running the arm64 unit tests until one of the solutions we talked about is in place. On Wed, Aug 23, 2023 at 4:33=E2=80=AFAM Zhang, Qi Z = wrote: > > > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday, August 23, 2023 2:29 PM > > To: dev@dpdk.org > > Cc: echaudro@redhat.com; mkp@redhat.com; Zhang, Qi Z > > ; stable@dpdk.org; Wu, Jingjing > > ; Xing, Beilei ; Sinha, > Abhijit > > ; Doherty, Declan ; > > Nicolau, Radu > > Subject: [PATCH v2] net/iavf: fix checksum offloading > > > > l2_len and l3_len fields are related to Tx offloading features. > > > > It is undefined in the DPDK API what those fields may contain if an > application > > did not request a Tx offload. > > > > Skip reading them if no Tx offloads has been requested. > > > > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Acked-by: Qi Zhang > > Applied to dpdk-next-net-intel. > > Thanks > Qi > > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --000000000000fed82e0603acd137 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi David, you can ignore the failures UNH reported=C2=A0fo= r this patch - we made a mistake reconfiguring jenkins for the refactored u= nit test suite. As discussed we are not running the arm64 unit tests until = one of the solutions we talked about is in place.=C2=A0

On Wed, Aug 23, 2023= at 4:33=E2=80=AFAM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, August 23, 2023 2:29 PM
> To: dev@dpdk.org=
> Cc: echaudro@= redhat.com; mkp@red= hat.com; Zhang, Qi Z
> <qi.z.zha= ng@intel.com>; = stable@dpdk.org; Wu, Jingjing
> <jingjin= g.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Sinha, Abhijit
> <abhij= it.sinha@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>
> Subject: [PATCH v2] net/iavf: fix checksum offloading
>
> l2_len and l3_len fields are related to Tx offloading features.
>
> It is undefined in the DPDK API what those fields may contain if an ap= plication
> did not request a Tx offload.
>
> Skip reading them if no Tx offloads has been requested.
>
> Fixes: 1e728b01120c ("net/iavf: rework Tx path")
> Cc: stable@dpdk.o= rg
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi



--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--000000000000fed82e0603acd137--