patches for DPDK stable branches
 help / color / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/6] event/dpaa2: fix def queue conf
Date: Mon, 30 Sep 2019 12:13:13 +0530
Message-ID: <CALBAE1M2hYWyNJ7FedLa3FRN9jqDa9X2owZHE5wOwt=beKrEDA@mail.gmail.com> (raw)
In-Reply-To: <20190927075841.21841-2-hemant.agrawal@nxp.com>

On Fri, Sep 27, 2019 at 1:31 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Test vector expect only one type of scheduling as default.
> The old code is provide support scheduling types instead of default.
>
> Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
> Cc: stable@dpdk.org
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

1) Patch version is missing

2) Shared library build failure.
http://mails.dpdk.org/archives/test-report/2019-September/099288.html

Please send the next version with fixes.


/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mempool_get_ops':
dpaa2_eventdev_selftest.c:(.text+0x224): undefined reference to
`rte_mempool_ops_table'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mbuf_raw_alloc':
dpaa2_eventdev_selftest.c:(.text+0x8d4): undefined reference to
`rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x8f5): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_reset':
dpaa2_eventdev_selftest.c:(.text+0xa26): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `__rte_pktmbuf_free_direct':
dpaa2_eventdev_selftest.c:(.text+0xb47): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0xc15): undefined
reference to `rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_free':
dpaa2_eventdev_selftest.c:(.text+0x23cf): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2408): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2535): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2603): undefined
reference to `rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `_eventdev_setup':
dpaa2_eventdev_selftest.c:(.text+0x4142): undefined reference to
`rte_pktmbuf_pool_create'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `eventdev_teardown':
dpaa2_eventdev_selftest.c:(.text+0x465d): undefined reference to
`rte_mempool_free'
collect2: error: ld returned 1 exit status
> ---
>  drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 926b7edd8..b8cb437a0 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -1,7 +1,5 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - *
> - *   Copyright 2017 NXP
> - *
> + * Copyright 2017,2019 NXP
>   */
>
>  #include <assert.h>
> @@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
>         RTE_SET_USED(queue_conf);
>
>         queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
> -       queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
> -                                     RTE_SCHED_TYPE_PARALLEL;
> +       queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
>         queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
>  }
>
> --
> 2.17.1
>

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190906103410.14996-1-hemant.agrawal@nxp.com>
2019-09-06 10:34 ` [dpdk-stable] [PATCH 1/5] " Hemant Agrawal
     [not found] ` <20190907064209.30686-1-hemant.agrawal@nxp.com>
2019-09-07  6:42   ` [dpdk-stable] [PATCH v2 " Hemant Agrawal
2019-09-13  6:24     ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2019-09-26 17:55       ` Jerin Jacob
2019-09-27  6:02         ` Hemant Agrawal
     [not found]   ` <20190927075841.21841-1-hemant.agrawal@nxp.com>
2019-09-27  7:58     ` [dpdk-stable] [PATCH 1/6] " Hemant Agrawal
2019-09-30  6:43       ` Jerin Jacob [this message]
     [not found]     ` <20190930083215.8241-1-hemant.agrawal@nxp.com>
2019-09-30  8:32       ` [dpdk-stable] [PATCH v4 " Hemant Agrawal
2019-09-30 14:17         ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1M2hYWyNJ7FedLa3FRN9jqDa9X2owZHE5wOwt=beKrEDA@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox