From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04AA3A2EEB for ; Fri, 13 Sep 2019 12:30:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF1FC1F0A8; Fri, 13 Sep 2019 12:30:38 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 6EF0A1F0A8; Fri, 13 Sep 2019 12:30:38 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id k5so36671266iol.5; Fri, 13 Sep 2019 03:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yg0vs7y04pLIAMgE8Qo9Yv14ynyk6nOTVo6V6X26ZZU=; b=aMzzpeTmvObkKt4aCj52FdaBcMYcXBRVkSJsdLNxTvhoTZI5AduFBCbPTAukqXAZ1F BKWakoC7quelUhZ1MjeisxUeEmLXJD49sOIgpbjnjpK6agNpL5dvbnBvoHxpZ9oib33s nlpy1CFIOzlwtdBI+NwwuXWYtjozY3aRAtu83P7awIB0QjCsIRy9uUpxhUapA4nsVtno Rd26/VLUzOxN62S8nQdEoPKd+C9FSaqoKL6hlni7ICtcoNelSK019xW4m1iUTXidG7UA ghPJzCWw5LNm4fAhm3UfUNgvJTlZxqFa2gKSJMXvSBlMvgdgZVWVJfgVPnDFISIpcNkD /tVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yg0vs7y04pLIAMgE8Qo9Yv14ynyk6nOTVo6V6X26ZZU=; b=tiUfBRN4U1hlG0wJ9cRvHQLEO6C3jWjAcJINWS2J1esxdYlTu2LGYq7tqH1hlkZAuU W3wJU52HRiKQQMnjatu1C6+zoJgZWb7P4x+WZgB+u2HhjOCigprUGKwlZJUJb99PdmSi TMRZSE/aIEja2SRBNO1QFDJYxZFaYbeVU4V+gZr+61yg8sZf5VbcIAJdRp3rUn/wrSnq 0tiS78k7qPu6Th8RTvRhGQmCaT+hXL4Va8OSDC8UqRZFvYTrwwANtMFkh6lFHl8dxifv UgEb63zdBTXEonTKv55Oq13GMiSsoLJ9OnH3vQWH7cniPDN2GarQp1GPa1QghD0izI5N PPUQ== X-Gm-Message-State: APjAAAXwx4a5lXMWMVmhFN6srIwwhOMGuFuCRK/Y1UwZxEWYtdK35459 sMyYunnDucPoR8AJGmfsuCEYIxBbUSSH2xaPXic= X-Google-Smtp-Source: APXvYqwZkeHIRvhLEWFc0t40Kx9SCUjEZpdK0qEUmx6comSU0gCIAMvLQRKnpKCuL/j/vHWqNzZHTkU5Vj+L4whXsdI= X-Received: by 2002:a6b:8e0f:: with SMTP id q15mr10318236iod.186.1568370637771; Fri, 13 Sep 2019 03:30:37 -0700 (PDT) MIME-Version: 1.0 References: <20190827213459.23441-1-gage.eads@intel.com> In-Reply-To: <20190827213459.23441-1-gage.eads@intel.com> From: Jerin Jacob Date: Fri, 13 Sep 2019 16:00:26 +0530 Message-ID: To: Gage Eads Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Aug 28, 2019 at 3:06 AM Gage Eads wrote: > > The sw PMD implements xstats reset by having the xstat get operations > return a value to the statistic's value at the last reset. The value at the > last reset is maintained in the per-xstat reset_value field, but the PMD > was setting reset_value = current - reset_value instead of reset_value = > current. > > Fixes: c1ad03df7ad5 ("event/sw: support xstats") > Cc: stable@dpdk.org > > Signed-off-by: Gage Eads Harry, Could you review this patch? > --- > drivers/event/sw/sw_evdev_xstats.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/event/sw/sw_evdev_xstats.c b/drivers/event/sw/sw_evdev_xstats.c > index 7a6caa64d..90664903b 100644 > --- a/drivers/event/sw/sw_evdev_xstats.c > +++ b/drivers/event/sw/sw_evdev_xstats.c > @@ -491,7 +491,7 @@ sw_xstats_update(struct sw_evdev *sw, enum rte_event_dev_xstats_mode mode, > values[xidx] = val; > > if (xs->reset_allowed && reset) > - xs->reset_value = val; > + xs->reset_value += val; > > xidx++; > } > @@ -544,8 +544,7 @@ sw_xstats_reset_range(struct sw_evdev *sw, uint32_t start, uint32_t num) > if (!xs->reset_allowed) > continue; > > - uint64_t val = xs->fn(sw, xs->obj_idx, xs->stat, xs->extra_arg) > - - xs->reset_value; > + uint64_t val = xs->fn(sw, xs->obj_idx, xs->stat, xs->extra_arg); > xs->reset_value = val; > } > } > -- > 2.13.6 >