From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3DD4A00C3 for ; Thu, 13 Oct 2022 08:44:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E611B42D48; Thu, 13 Oct 2022 08:44:55 +0200 (CEST) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mails.dpdk.org (Postfix) with ESMTP id 7BF5242C27; Thu, 13 Oct 2022 08:44:54 +0200 (CEST) Received: by mail-qt1-f179.google.com with SMTP id l28so481960qtv.4; Wed, 12 Oct 2022 23:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=STbsylq/GH54P+zBsOpaBqFUIzK3kYL1cm0h+Bc0FkA=; b=Op92s0qPQggidTohLPZ+XhvMTGvINH9WMjpAmaCDkd1AUu3oBkfiNlqSIew2QoXhPl saoAHA+yU7Cu9Xmaopbx4D0cmyoqthlC0MF/quZsKeG8o0saQvjdkXXG0UUejSABGuXu 8fht8i0tEiXi5Tegqp32a1jsm9Xq8abBNb+iFInMI/K6RCTqU76W9anu1BpWZqSt4yVA YuqglDeiR80laHu2lyetam+wdVEj4VrLag3SXVslXAp++QeExDUzjxnvO5JTmBFPgYmS Y8kzC2gpd25l41ZfrACunzAsNDQH53g2FyyLVB/q6YVku7j/kVt+/zKT25YeWtqUybfk 7RCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=STbsylq/GH54P+zBsOpaBqFUIzK3kYL1cm0h+Bc0FkA=; b=t98DX31k597vlhvMgGbzde8wUOBgp0FMahpI/nnu/i4YpkiEILoidVktY6plrnnmxK oL3ffjcQBAtWWFov94SRqZ0NDNiLS5uAmbQLycvC9oCfxrkxEOIQZydmpZk8trUMh0XV JTuF1tgHBHd+O/WIeSOXFWMBQlTHiE49Dc7onWQNlSNWF7hLHBoB/chqcvS+KU+TXFDk y8YZv5AiS8PFjnSUbHdhAkRgtmUBh13pK5A8J9EZDyzXNxEJPblJ5a1oHJZCjhqiZthP DoJcFp04rn6giPb7H7kjX9iM6rQTA9sgoBaY8CLq+5JP9cBPz1HgqH5NDrqxyTA76r+R hpMA== X-Gm-Message-State: ACrzQf24R0GWS1jXDu9Qk0GCQnt2qTHoAbGhlEVb36fBbU+kD8Rnv5kG 3H6Ft/th0aq8e63TJudn54Xm22tWgzixZSkiMTA= X-Google-Smtp-Source: AMsMyM4WjBmiGjekAzVkfe7dPjh1er0/WHYf0sefgWxPknTa3bD9HsNHOcz0eiPA4VeIxqJ3wUX+Y7IZV+uXF5OPjUs= X-Received: by 2002:ac8:7d90:0:b0:35b:afd3:20aa with SMTP id c16-20020ac87d90000000b0035bafd320aamr26233513qtd.252.1665643493908; Wed, 12 Oct 2022 23:44:53 -0700 (PDT) MIME-Version: 1.0 References: <20221012235037.3293072-1-abdullah.sevincer@intel.com> <20221012235037.3293072-4-abdullah.sevincer@intel.com> In-Reply-To: <20221012235037.3293072-4-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Thu, 13 Oct 2022 12:14:28 +0530 Message-ID: Subject: Re: [PATCH v2 4/4] event/dlb2: fix port cos override calculation To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Oct 13, 2022 at 5:21 AM Abdullah Sevincer wrote: > > This commit fixes a calculation error > of total number of ldb ports during port cos > override from dlb2 event structure. > > Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") > Cc: stable@dpdk.org > > Signed-off-by: Abdullah Sevincer Series applied to dpdk-next-net-eventdev/for-main. Thanks I have updated the git commit log. Please check changes and try to do similar for new patches commit fa8dd9829c9e83154be8b9c8da65b4698e6a898b (HEAD -> for-main) Author: Abdullah Sevincer Date: Wed Oct 12 18:50:37 2022 -0500 event/dlb2: fix port COS override calculation Fix the calculation error of the total number of LDB ports during port COS override from dlb2 event structure. Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") Cc: stable@dpdk.org Signed-off-by: Abdullah Sevincer commit 67332a696bef5b92dee0d1479a0895ad149883cd Author: Abdullah Sevincer Date: Wed Oct 12 18:50:36 2022 -0500 event/dlb2: remove COS from devargs Since COS is now per port specific only and supported through port_cos in dev_args, there is no need to have a COS argument in dev_args. Signed-off-by: Abdullah Sevincer commit f83ab599df9fe2c62208d0815715e53117e9958f Author: Abdullah Sevincer Date: Wed Oct 12 18:50:35 2022 -0500 event/dlb2: validate producer coremask Add checks during port probing for validating producer core masks if they are a subset of EAL coremask. Error is returned if producer coremask is not a subset of EAL coremask. Signed-off-by: Abdullah Sevincer commit 4346d7f5424f4b97ec530ee5320ea931f4179230 Author: Abdullah Sevincer Date: Wed Oct 12 18:50:34 2022 -0500 event/dlb2: remove COS from port probing Remove COS (class of service) from port probing criteria and apply enhancements for selection of ports from best COS when default COS (255) is used. Signed-off-by: Abdullah Sevincer > --- > drivers/event/dlb2/dlb2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c > index b200c9484e..02f0e57208 100644 > --- a/drivers/event/dlb2/dlb2.c > +++ b/drivers/event/dlb2/dlb2.c > @@ -848,10 +848,11 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2, > } > > cfg->cos_strict = 0; /* Best effort */ > - cfg->num_cos_ldb_ports[0] = resources_asked->num_ldb_ports - cos_ports; > + cfg->num_cos_ldb_ports[0] = dlb2->cos_ports[0]; > cfg->num_cos_ldb_ports[1] = dlb2->cos_ports[1]; > cfg->num_cos_ldb_ports[2] = dlb2->cos_ports[2]; > cfg->num_cos_ldb_ports[3] = dlb2->cos_ports[3]; > + cfg->num_ldb_ports = resources_asked->num_ldb_ports - cos_ports; > > if (device_version == DLB2_HW_V2) > cfg->num_ldb_credits = resources_asked->num_ldb_credits; > -- > 2.25.1 >