From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11EB4A0350 for ; Fri, 26 Jun 2020 06:45:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2F7C1B75C; Fri, 26 Jun 2020 06:45:50 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 1737525B3; Fri, 26 Jun 2020 06:45:48 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id z2so7432567ilq.0; Thu, 25 Jun 2020 21:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXkOwGoEohKPtttOvsv+wVIwfkVv0Z79MgjF2VpAjUM=; b=djvnprNQu2JY+koUW8qEJ5bUtMpd8XeG2PvS7+VU/WS73U9tx2d/0l3MVF6y0+J9aQ IELs3lTQMxwv1DhRZ9TeMf1OB4Owhbo2MbYcvJ2w9Aw96B2nublOomRoFFg3cYuFypSj xmkQOivLOFxPC0w6j4Uu3QQmh4Jj9Ckcanjx+DEr8PcUSaf+PAHkWg0Z1ebme5P4wRO5 HlV2rq7kQNqnY1DAQTpY1uRbaMWRyKUKcBpofx9He6N4nJtFoXMGNdwj95Cnef0U+5EJ eTZYpaitOVfSVQ63KWKDnZkXjUG9Skkjk6hon+1X2IFB/4Mj/8vf85U8GydeLwbNzRjW lsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXkOwGoEohKPtttOvsv+wVIwfkVv0Z79MgjF2VpAjUM=; b=oXfGozXmyqUGWgpnYzO0N+vgvkwA/JFM/YKScR5p2rW5m7a/y1kIJYtNfRMqdQaZUO YbdFLrqEjnpQJAnMn8NNzxVQfwB0MKUSTtOWgZwR4ZDA8VVuVGwjhyC4r4s4aVFLjHtO ooSKxhLwrc6/aK/8Qf9LFt8+9ZwmsJSGv0CnS+CC3g9aWKUq9c6wNE+3PcpsF/tZwhoP GtUVDeT0Uu8Z7OWvLhusPkVYhTOhpttIn9abiqVpIHn7G1BvoDU6YqT74wQVqulKluxP c362/v7HvCDeb2W1p5IhmPmnLI5fRKUG5SHIEcsXRt+NktmyisVr4uoSN8iB/km2lhiX P9dg== X-Gm-Message-State: AOAM532xEL6ELBhaJJCw4eyKkAmiFBZede20vGpX7MWI79+PPKbtxgcz cJjwXjnNln3F3SmDaR6LueyP+6gWmotHgJiShsA= X-Google-Smtp-Source: ABdhPJywe127rZG0A+eGie6wyKcHt9O9eZQv7VsCXW3NnRs8rDBwu/rwGaBhelaW+i+/qTXA8pjAzHt2fhFtzuRlh8k= X-Received: by 2002:a92:2d4:: with SMTP id 203mr1274695ilc.60.1593146747367; Thu, 25 Jun 2020 21:45:47 -0700 (PDT) MIME-Version: 1.0 References: <20200616094700.31749-1-david.marchand@redhat.com> In-Reply-To: From: Jerin Jacob Date: Fri, 26 Jun 2020 10:15:30 +0530 Message-ID: To: Liron Himi Cc: David Marchand , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix non-EAL thread support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Jun 16, 2020 at 3:19 PM Liron Himi wrote: > > > Acked-by: Liron Himi Applied to dpdk-next-net-mrvl/master. Thanks > > -----Original Message----- > From: David Marchand > Sent: Tuesday, 16 June 2020 12:47 > To: dev@dpdk.org > Cc: stable@dpdk.org; Liron Himi ; Natalie Samsonov > Subject: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support > > External Email > > ---------------------------------------------------------------------- > Caught by code inspection, for a non-EAL thread identified with > rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses lcore 0 while there is no guarantee this lcore is used. > > Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index b98b1fd667..9037274327 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -816,7 +816,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev) > unsigned int core_id = rte_lcore_id(); > > if (core_id == LCORE_ID_ANY) > - core_id = 0; > + core_id = rte_get_master_lcore(); > > hif = mrvl_get_hif(priv, core_id); > > @@ -1620,7 +1620,7 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) > > core_id = rte_lcore_id(); > if (core_id == LCORE_ID_ANY) > - core_id = 0; > + core_id = rte_get_master_lcore(); > > hif = mrvl_get_hif(rxq->priv, core_id); > if (!hif) > @@ -1770,7 +1770,7 @@ mrvl_rx_queue_release(void *rxq) > unsigned int core_id = rte_lcore_id(); > > if (core_id == LCORE_ID_ANY) > - core_id = 0; > + core_id = rte_get_master_lcore(); > > if (!q) > return; > -- > 2.23.0 >