From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1AEC42B2C for ; Wed, 17 May 2023 15:15:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D4841611; Wed, 17 May 2023 15:15:39 +0200 (CEST) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by mails.dpdk.org (Postfix) with ESMTP id 97667406B7; Wed, 17 May 2023 15:15:37 +0200 (CEST) Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-77d218b74cdso287391241.0; Wed, 17 May 2023 06:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684329337; x=1686921337; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qrKoAd7acLqfneYm3C6sZuMWwWuDvg+v7/Nx8ctdUUQ=; b=CGIRtZvc1VWgtzWQxeAOngAbBSHP1te/yMssmnU5YWXr+ajQ7nf9pGpSuu6lXYCwlN ymBYHyUmlgBNa6VF2J6uaIncL+bWJNBSa24BrMt0YZkgO3mhCmvHRGhW9BpSU3pg6u43 Stv6gGRRiWK56m9kBWIyoKBua7/zUk1tisXd18UsjKIGb0Ysp+S1YWsx+pcs7RGPQxWP LMuzTCW+yP+Ze8jxUD0m3/DuIjSPxkxtvejERr27ZkY4IY/WGsEEuEs30rcgAXhThb7D f493c9LH1D8/TFw6EUxPJUuc6c97xdYcCsw58zCsm9ImEGnsprtiy45fRr+HWpCCVCrn WSvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684329337; x=1686921337; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qrKoAd7acLqfneYm3C6sZuMWwWuDvg+v7/Nx8ctdUUQ=; b=lJE1XwlL1oxOqhP6uuArzAL3MCcmcKE2IFiNyslP2wJdbjakFr+bCGKcDu42SlVSmb Vsr7p7RoimYSa3DkM6bx7UwuiEt1wtWHChiFiy2LdwmfJEmcLw42IWolpwewg6u//XcD +ToeJEbs0m74RtSAzsFz7SBKQgRuTqLPu5iD6EqUsBZXWRamnInomwXr5B9QIbqEy/Ur u4VdO03hK6QBt2qLjNWK5D9d3cUdYQ7LjgLpvLspy23YYjEt6L7pPxhNQygW91EIDDz7 NPqUhxVz0BddPfQfG+TP29dpIpysCvEnFy21QETOKRIChx3HsblOxvje35duq6Pr4v4U QYJg== X-Gm-Message-State: AC+VfDz45Jf5sSlX62Xj/VdwMV9TAc5EZaNez7baNf4IKWzW5TOaA0yX X1laGiuSSr85FRBCUV99lk7in8AhONIY72lStEmjTb2P4y1CmQ== X-Google-Smtp-Source: ACHHUZ4W4NHGNfIZllZpdMs1hmKcK9q2QQrg4hYDzlOb5VtgD6Mh2EwhazHPBTFIKGUhsBCdAHBocRQSQOijnOv/akM= X-Received: by 2002:a67:f946:0:b0:436:4dda:ee63 with SMTP id u6-20020a67f946000000b004364ddaee63mr5778694vsq.0.1684329336673; Wed, 17 May 2023 06:15:36 -0700 (PDT) MIME-Version: 1.0 References: <9e4d4654e6a1d7f6c5fb69ad01421117b8599f41.1682576830.git.sthotton@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 17 May 2023 18:45:10 +0530 Message-ID: Subject: Re: [PATCH v1] event/cnxk: fix setting event attributes in empty get work To: Pavan Nikhilesh Bhagavatula Cc: Shijith Thotton , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Apr 27, 2023 at 12:24=E2=80=AFPM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Shijith Thotton > > Sent: Thursday, April 27, 2023 11:58 AM > > To: Jerin Jacob Kollanukkaran > > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > > Nikhilesh Bhagavatula ; stable@dpdk.org > > Subject: [PATCH v1] event/cnxk: fix setting event attributes in empty g= et > > work > > > > Even when no events are dequeued, it is important to update event > > attributes as they provide valuable information for checking the work > > slot state and other attributes. > > > > Fixes: c0a9774f030d ("event/cnxk: move post-processing to separate > > function") > > > > Signed-off-by: Shijith Thotton > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks > > > --- > > drivers/event/cnxk/cn10k_worker.h | 3 +++ > > drivers/event/cnxk/cn9k_worker.h | 6 ++++-- > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/event/cnxk/cn10k_worker.h > > b/drivers/event/cnxk/cn10k_worker.h > > index 06c71c6092..beae2be903 100644 > > --- a/drivers/event/cnxk/cn10k_worker.h > > +++ b/drivers/event/cnxk/cn10k_worker.h > > @@ -282,6 +282,9 @@ cn10k_sso_hws_get_work_empty(struct > > cn10k_sso_hws *ws, struct rte_event *ev, > > ws->gw_rdata =3D gw.u64[0]; > > if (gw.u64[1]) > > cn10k_sso_hws_post_process(ws, gw.u64, flags); > > + else > > + gw.u64[0] =3D (gw.u64[0] & (0x3ull << 32)) << 6 | > > + (gw.u64[0] & (0x3FFull << 36)) << 4 | (gw.u64= [0] & > > 0xffffffff); > > > > ev->event =3D gw.u64[0]; > > ev->u64 =3D gw.u64[1]; > > diff --git a/drivers/event/cnxk/cn9k_worker.h > > b/drivers/event/cnxk/cn9k_worker.h > > index 1ce4b044e8..47eea70b5f 100644 > > --- a/drivers/event/cnxk/cn9k_worker.h > > +++ b/drivers/event/cnxk/cn9k_worker.h > > @@ -353,8 +353,10 @@ cn9k_sso_hws_get_work_empty(uint64_t base, > > struct rte_event *ev, > > #endif > > > > if (gw.u64[1]) > > - cn9k_sso_hws_post_process(gw.u64, mbuf, flags, > > lookup_mem, > > - tstamp); > > + cn9k_sso_hws_post_process(gw.u64, mbuf, flags, > > lookup_mem, tstamp); > > + else > > + gw.u64[0] =3D (gw.u64[0] & (0x3ull << 32)) << 6 | > > + (gw.u64[0] & (0x3FFull << 36)) << 4 | (gw.u64= [0] & > > 0xffffffff); > > > > ev->event =3D gw.u64[0]; > > ev->u64 =3D gw.u64[1]; > > -- > > 2.25.1 >