From: Jerin Jacob <jerinjacobk@gmail.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: jerinj@marvell.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] eventdev/timer: move buffer flush call
Date: Wed, 17 May 2023 19:31:46 +0530 [thread overview]
Message-ID: <CALBAE1NbWKxM+-3BT=0t7EgJa-PnsRwLWBv55J8rB5tyUKtYuQ@mail.gmail.com> (raw)
In-Reply-To: <20230412195637.450033-1-erik.g.carrillo@intel.com>
On Thu, Apr 13, 2023 at 1:26 AM Erik Gabriel Carrillo
<erik.g.carrillo@intel.com> wrote:
>
> The SW event timer adapter attempts to flush its event buffer on every
> adapter tick. If events remain in the buffer after the attempt, another
> attempt to flush won't occur until the next adapter tick, which delays
> the enqueue of those events to the event device unecessarily.
typo: unecessarily
Updated the git commit as follows and applied to
dpdk-next-net-eventdev/for-main. Thanks
eventdev/timer: fix buffer flush
The SW event timer adapter attempts to flush its event buffer on every
adapter tick. If events remain in the buffer after the attempt, another
attempt to flush won't occur until the next adapter tick, which delays
the enqueue of those events to the event device unnecessarily.
Move the buffer flush call so that it happens with every invocation of
the service function, rather than on every adapter tick, to avoid the
delay.
Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter")
Cc: stable@dpdk.org
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> Move the buffer flush call so that it happens with every invocation of
> the service function, rather than on every adapter tick, to avoid the
> delay.
>
> Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> lib/eventdev/rte_event_timer_adapter.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c
> index 23eb1d4a7d..427c4c6287 100644
> --- a/lib/eventdev/rte_event_timer_adapter.c
> +++ b/lib/eventdev/rte_event_timer_adapter.c
> @@ -855,17 +855,18 @@ swtim_service_func(void *arg)
> sw->n_expired_timers);
> sw->n_expired_timers = 0;
>
> - event_buffer_flush(&sw->buffer,
> - adapter->data->event_dev_id,
> - adapter->data->event_port_id,
> - &nb_evs_flushed,
> - &nb_evs_invalid);
> -
> - sw->stats.ev_enq_count += nb_evs_flushed;
> - sw->stats.ev_inv_count += nb_evs_invalid;
> sw->stats.adapter_tick_count++;
> }
>
> + event_buffer_flush(&sw->buffer,
> + adapter->data->event_dev_id,
> + adapter->data->event_port_id,
> + &nb_evs_flushed,
> + &nb_evs_invalid);
> +
> + sw->stats.ev_enq_count += nb_evs_flushed;
> + sw->stats.ev_inv_count += nb_evs_invalid;
> +
> rte_event_maintain(adapter->data->event_dev_id,
> adapter->data->event_port_id, 0);
>
> --
> 2.23.0
>
prev parent reply other threads:[~2023-05-17 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 19:56 Erik Gabriel Carrillo
2023-05-17 14:01 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NbWKxM+-3BT=0t7EgJa-PnsRwLWBv55J8rB5tyUKtYuQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).