From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH 15/20] net/cnxk: use raw mbuf free on inline sec err
Date: Thu, 17 Feb 2022 19:15:17 +0530 [thread overview]
Message-ID: <CALBAE1O408Fs3WCQsjAfZDZ2DSX7jK4+Jqu5UBRo0FxDj7iJBg@mail.gmail.com> (raw)
In-Reply-To: <20220207072932.22409-15-ndabilpuram@marvell.com>
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
You could change the subject as net/cnxk: fix inline IPsec security
error handling
>
> Use raw mbuf free on inline sec error to simulate
sec- > security
> HW NPA free instead of doing rte_pktmbuf_free(). This
> is needed as the callback will not be called from
> DPDK lcore.
>
> Fixes: 69daa9e5022b ("net/cnxk: support inline security setup for cn10k")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/cnxk/cn10k_ethdev_sec.c | 37 ++++++++++++++++++++++++++++++++-----
> 1 file changed, 32 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_sec.c
> index ac45056..044b20c 100644
> --- a/drivers/net/cnxk/cn10k_ethdev_sec.c
> +++ b/drivers/net/cnxk/cn10k_ethdev_sec.c
> @@ -138,6 +138,20 @@ static const struct rte_security_capability cn10k_eth_sec_capabilities[] = {
> }
> };
>
> +static inline void
> +cnxk_pktmbuf_free_no_cache(struct rte_mbuf *mbuf)
> +{
> + struct rte_mbuf *next;
> +
> + if (!mbuf)
> + return;
> + do {
> + next = mbuf->next;
> + roc_npa_aura_op_free(mbuf->pool->pool_id, 1, (rte_iova_t)mbuf);
> + mbuf = next;
> + } while (mbuf != NULL);
> +}
> +
> void
> cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)
> {
> @@ -148,6 +162,7 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)
> struct cpt_cn10k_res_s *res;
> struct rte_eth_dev *eth_dev;
> struct cnxk_eth_dev *dev;
> + static uint64_t warn_cnt;
> uint16_t dlen_adj, rlen;
> struct rte_mbuf *mbuf;
> uintptr_t sa_base;
> @@ -161,7 +176,7 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)
> /* Event from inbound inline dev due to IPSEC packet bad L4 */
> mbuf = (struct rte_mbuf *)(gw[1] - sizeof(struct rte_mbuf));
> plt_nix_dbg("Received mbuf %p from inline dev inbound", mbuf);
> - rte_pktmbuf_free(mbuf);
> + cnxk_pktmbuf_free_no_cache(mbuf);
> return;
> case RTE_EVENT_TYPE_CPU:
> /* Check for subtype */
> @@ -212,17 +227,29 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args)
> case ROC_IE_OT_UCC_ERR_SA_OVERFLOW:
> desc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;
> break;
> + case ROC_IE_OT_UCC_ERR_PKT_IP:
> + warn_cnt++;
> + if (warn_cnt % 10000 == 0)
> + plt_warn("Outbound error, bad ip pkt, mbuf %p,"
> + " sa_index %u (total warnings %" PRIu64 ")",
> + mbuf, sess_priv.sa_idx, warn_cnt);
> + desc.subtype = RTE_ETH_EVENT_IPSEC_UNKNOWN;
> + break;
> default:
> - plt_warn("Outbound error, mbuf %p, sa_index %u, "
> - "compcode %x uc %x", mbuf, sess_priv.sa_idx,
> - res->compcode, res->uc_compcode);
> + warn_cnt++;
> + if (warn_cnt % 10000 == 0)
> + plt_warn("Outbound error, mbuf %p, sa_index %u,"
> + " compcode %x uc %x,"
> + " (total warnings %" PRIu64 ")",
> + mbuf, sess_priv.sa_idx, res->compcode,
> + res->uc_compcode, warn_cnt);
> desc.subtype = RTE_ETH_EVENT_IPSEC_UNKNOWN;
> break;
> }
>
> desc.metadata = (uint64_t)priv->userdata;
> rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_IPSEC, &desc);
> - rte_pktmbuf_free(mbuf);
> + cnxk_pktmbuf_free_no_cache(mbuf);
> }
>
> static int
> --
> 2.8.4
>
next prev parent reply other threads:[~2022-02-17 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220207072932.22409-1-ndabilpuram@marvell.com>
2022-02-07 7:29 ` [PATCH 12/20] net/cnxk: fix inline device RQ tag mask Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 13/20] net/cnxk: register callback early to handle initial packets Nithin Dabilpuram
2022-02-07 7:29 ` [PATCH 15/20] net/cnxk: use raw mbuf free on inline sec err Nithin Dabilpuram
2022-02-17 13:45 ` Jerin Jacob [this message]
[not found] ` <20220222193512.19292-1-ndabilpuram@marvell.com>
2022-02-22 19:35 ` [PATCH v2 12/21] net/cnxk: fix inline device RQ tag mask Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 13/21] net/cnxk: register callback early to handle initial packets Nithin Dabilpuram
2022-02-22 19:35 ` [PATCH v2 15/21] net/cnxk: fix inline IPsec security error handling Nithin Dabilpuram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1O408Fs3WCQsjAfZDZ2DSX7jK4+Jqu5UBRo0FxDj7iJBg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).