From: Jerin Jacob <jerinjacobk@gmail.com>
To: Volodymyr Fialko <vfialko@marvell.com>
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Ray Kinsella <mdr@ashroe.eu>,
jerinj@marvell.com, anoobj@marvell.com, stable@dpdk.org
Subject: Re: [PATCH] event/cnxk: fix SSO return code at fini
Date: Fri, 3 Mar 2023 21:04:02 +0530 [thread overview]
Message-ID: <CALBAE1OrHJH-XmX__YTeSCCf+Q5uRbuE9aCCOdF7w9dHJZW3MQ@mail.gmail.com> (raw)
In-Reply-To: <20230302105832.3955684-1-vfialko@marvell.com>
On Thu, Mar 2, 2023 at 4:30 PM Volodymyr Fialko <vfialko@marvell.com> wrote:
>
> dev_fini() can return EAGAIN in case if LF is active(used by other
> devices). Ignoring return code leads to early free of resources that are
> still in use.
>
> Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/event/cnxk/cnxk_eventdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index 9815e84c24..6aecccb45d 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -670,9 +670,8 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)
>
> cnxk_tim_fini();
> roc_sso_rsrc_fini(&dev->sso);
> - roc_sso_dev_fini(&dev->sso);
>
> - return 0;
> + return roc_sso_dev_fini(&dev->sso);
> }
>
> int
> --
> 2.34.1
>
prev parent reply other threads:[~2023-03-03 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 10:58 Volodymyr Fialko
2023-03-03 15:34 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OrHJH-XmX__YTeSCCf+Q5uRbuE9aCCOdF7w9dHJZW3MQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mdr@ashroe.eu \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).