* [PATCH] event/cnxk: fix SSO return code at fini
@ 2023-03-02 10:58 Volodymyr Fialko
2023-03-03 15:34 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Volodymyr Fialko @ 2023-03-02 10:58 UTC (permalink / raw)
To: dev, Pavan Nikhilesh, Shijith Thotton, Ray Kinsella
Cc: jerinj, anoobj, Volodymyr Fialko, stable
dev_fini() can return EAGAIN in case if LF is active(used by other
devices). Ignoring return code leads to early free of resources that are
still in use.
Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup")
Cc: stable@dpdk.org
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
drivers/event/cnxk/cnxk_eventdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
index 9815e84c24..6aecccb45d 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -670,9 +670,8 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)
cnxk_tim_fini();
roc_sso_rsrc_fini(&dev->sso);
- roc_sso_dev_fini(&dev->sso);
- return 0;
+ return roc_sso_dev_fini(&dev->sso);
}
int
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] event/cnxk: fix SSO return code at fini
2023-03-02 10:58 [PATCH] event/cnxk: fix SSO return code at fini Volodymyr Fialko
@ 2023-03-03 15:34 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2023-03-03 15:34 UTC (permalink / raw)
To: Volodymyr Fialko
Cc: dev, Pavan Nikhilesh, Shijith Thotton, Ray Kinsella, jerinj,
anoobj, stable
On Thu, Mar 2, 2023 at 4:30 PM Volodymyr Fialko <vfialko@marvell.com> wrote:
>
> dev_fini() can return EAGAIN in case if LF is active(used by other
> devices). Ignoring return code leads to early free of resources that are
> still in use.
>
> Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/event/cnxk/cnxk_eventdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index 9815e84c24..6aecccb45d 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -670,9 +670,8 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)
>
> cnxk_tim_fini();
> roc_sso_rsrc_fini(&dev->sso);
> - roc_sso_dev_fini(&dev->sso);
>
> - return 0;
> + return roc_sso_dev_fini(&dev->sso);
> }
>
> int
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-03 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 10:58 [PATCH] event/cnxk: fix SSO return code at fini Volodymyr Fialko
2023-03-03 15:34 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).