From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C4D8A0351 for ; Thu, 24 Feb 2022 14:43:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05ED2426FD; Thu, 24 Feb 2022 14:43:12 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 7E731426E6; Thu, 24 Feb 2022 14:43:09 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id d62so2648941iog.13; Thu, 24 Feb 2022 05:43:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CnuSwpMyHPmQkvw9YeMBzURAhKxg1f1IeozuxD0UXr8=; b=UHs3RAUji+B9cKukTycuLqVX4IuPdoTAwHxgeWMWwAM8eqOyvJh857HrInewWYzOux HWbAENH7QKLjWFNMJoz3p/FBQg5Zt5zV3iqw5ZuWjGUK5GPamdJJY/AwUpmxBnFplRiB q9maVhSSTkeer4IthETBqrt2zpb7JztDuwG5+GCMRAGjhUuYwbLxXumL9MQtQDd9MAyW uROjAq/xFS2GrLon6B1xZU9Bokpay0gX0C4dTPdWC96bU3kMgm1Nn04/dvcuI55qv49A 7sQRpgD8yP7z26JVFV+81JleCGbeHTphVHfRP85shmpXzI5E5D5CfZuzVenT+QZrHhGV Oj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CnuSwpMyHPmQkvw9YeMBzURAhKxg1f1IeozuxD0UXr8=; b=fWJmf7RWehDoy/4/K/tN4ne8uE/soill/nYAUFUUVNv6m54taGLSsWj3RnsB++bbUY Idsj6RmgFX1x12GC5ZngfY6h5/u+CBS1RH23UgcPeuQmyeyoDEuU01bM4y8fvL9gS5rM yp7lufBcv3zh9KQfkqsrQEW0LENJUMjun9D1RXKooGyHHe3alN82ZP5LyNkR3DeBIA0N 6LTf9KwGOZ5NeRfufYf0mMUe9LgBKABGBvJu1nRCHV6qTCELDTYedmOm6sa+cstpxT6c ShsbRiRzBdIR2NISq+gvYkxhiB//0+qvsaIH0emgjkgGwGZGtZCTRhG7IATA+5cY0oIL vmTg== X-Gm-Message-State: AOAM532C5xHMhK3yqvMnMAHIc0ZEmmonHUyiOWYjbSQIwlgm5g91x0Ua Cm0wsNQD6NJobdC0ie/Y3vZGDoUSmmWaTjlHcww= X-Google-Smtp-Source: ABdhPJwbRvgA5vZFrgAQ9kupT+T5fbajgz3XmncMJB32+q5NxjcsJYIMo2YB97dOjtVzBPUYdar3GaoTK7+qWV4JAwI= X-Received: by 2002:a02:c609:0:b0:314:cfc7:94fe with SMTP id i9-20020a02c609000000b00314cfc794femr2145390jan.79.1645710188911; Thu, 24 Feb 2022 05:43:08 -0800 (PST) MIME-Version: 1.0 References: <20220224083528.3000787-1-rkudurumalla@marvell.com> In-Reply-To: <20220224083528.3000787-1-rkudurumalla@marvell.com> From: Jerin Jacob Date: Thu, 24 Feb 2022 19:12:43 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: update RSS RETA table To: Rakesh Kudurumalla , Ferruh Yigit Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , Jerin Jacob , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Feb 24, 2022 at 2:05 PM Rakesh Kudurumalla wrote: > > rss reta table is corrupted during > rte_eth_dev_rss_reta_update.This fix restores > previous table entries before updating. > > Fixes: 00242a687de ("net/cnxk: support RETA and RSS hash") > Cc: stable@dpdk.org > > Signed-off-by: Rakesh Kudurumalla Acked-by: Jerin Jacob Updated the git commit as follows and applied to dpdk-next-net-eventdev/for-main. Thanks net/cnxk: fix RSS RETA table update RSS reta table is corrupted during rte_eth_dev_rss_reta_update(). Fix it by restoring previous table entries before updating. Fixes: 00242a687de ("net/cnxk: support RETA and RSS hash") Cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla Acked-by: Jerin Jacob > --- > drivers/net/cnxk/cnxk_ethdev_ops.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c > index b0a16f3c56..f4a0562475 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_ops.c > +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c > @@ -857,6 +857,8 @@ cnxk_nix_reta_update(struct rte_eth_dev *eth_dev, > goto fail; > } > > + roc_nix_rss_reta_get(nix, 0, reta); > + > /* Copy RETA table */ > for (i = 0; i < (int)(dev->nix.reta_sz / RTE_ETH_RETA_GROUP_SIZE); i++) { > for (j = 0; j < RTE_ETH_RETA_GROUP_SIZE; j++) { > -- > 2.25.1 >