From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E54C9A2EFC for ; Tue, 15 Oct 2019 10:16:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B80C31D505; Tue, 15 Oct 2019 10:16:51 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id D76C51D406; Tue, 15 Oct 2019 10:16:48 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id b136so43914660iof.3; Tue, 15 Oct 2019 01:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M+ujsu+mQTBgl/RewJ458+O4cKkAyiLJUmL3naj0VAM=; b=qVMytCS22bfvLEWUhdBc0v1Je8bp1k7BKJIfa/XXuisFF0iUB6Gq1OjtY27WhXMW0M aMyzL+GFFjvYfhDDvUEEcwh1PvA4cNjbyBydEctVqZp4tvyDe2MR7b2idsTvndFjRFpn xASPE0nXSJIotRbmgYw4UgoMA5AMgWWxr09nhy54B/n53TOY8tnseumgn18MPjWOxnqm X5jnX0oj3rPr5vmEFZdxTzE0FpASREr47M2fnv9vZwUF1C68UI2gJ1JJw7JVxs3mDsU3 acN9Mhaa/hVjjUY975iMoiNKDPYdEZhiAKnACwqW7N0LbwAlR4o/P2K2Hyz8p4hTpyH/ /diw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M+ujsu+mQTBgl/RewJ458+O4cKkAyiLJUmL3naj0VAM=; b=OHWtA5rnCQc152q5YwBo5zCJvByL/rSZG5aUExkLvz186TlSUXwB70+DORNBSHnh+R bAo72xNuHfQUoNoUyNTvNozduM+dvsvnzgWMbjcymCFB5cUR/qtM/xHq00VnsNYXAvH+ PNQUDNKTqnn3HIayhlfcxMGnPeEyTY1gT3GOZ7GMDyReJoEdW4jQObuAbLhelc9SxisT WZfhZ1vN3/PLz1t4HA3pCdWEKYjR+zBhys3mv3A+1z/xytda3ix2KuFBTw4gx61wsdYX 7PM0MvXEC+mtkeDOG9XF8hN9lD2BpEozeuRySh9mfCmzSg1i1U3EUbVid50zgmM/7K1t CONQ== X-Gm-Message-State: APjAAAUcPo02wI8f5EgyZfzl7wlhl4BQV+2TbbdC4BeKC88FjMPzjXvd c50bWtw8+UnHX6p1sIiC19jTjmM7Np+OMPvwXho= X-Google-Smtp-Source: APXvYqw20MOo9XSars9m7SSLZdeY1w5D0yp09dDMz3TYF1duc08gCZ4elooBVK+FFqrSBRd7Nd+Nxcha1KFzA2QSN1s= X-Received: by 2002:a92:ce41:: with SMTP id a1mr4738997ilr.60.1571127408009; Tue, 15 Oct 2019 01:16:48 -0700 (PDT) MIME-Version: 1.0 References: <20191015070214.93403-1-asomalap@amd.com> In-Reply-To: <20191015070214.93403-1-asomalap@amd.com> From: Jerin Jacob Date: Tue, 15 Oct 2019 13:46:36 +0530 Message-ID: To: asomalap@amd.com Cc: "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 5/6] crypto/ccp: enable IOMMU for CCP X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Oct 15, 2019 at 12:32 PM wrote: > > From: Amaranath Somalapuram > > CCP use vdev framework, and vdev framework don=E2=80=99t support IOMMU. > Adding custom IOMMU support for AMD CCP drives. > Cc: stable@dpdk.org > > + if (iommu_mode =3D=3D 2) > + pci->kdrv =3D RTE_KDRV_VFIO; > + else if (iommu_mode =3D=3D 0) > + pci->kdrv =3D RTE_KDRV_IGB_UIO; > + else if (iommu_mode =3D=3D 1) > + pci->kdrv =3D RTE_KDRV_UIO_GENERIC; The crypto driver should not have iommu mode-specific handling. I am not sure about the problem statement. If the problem is, iommu support for PCI based vdev device then move the solution to common layer so that everyone can use it. If not, please share the problem statement