From: Jerin Jacob <jerinjacobk@gmail.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH] drivers: fix cnxk event qos devarg processing
Date: Mon, 13 Jun 2022 11:28:23 +0530 [thread overview]
Message-ID: <CALBAE1OzJhpBHCuHc3+GsYHawR-+huL-dmbKQ7ToRr1c2iBbqg@mail.gmail.com> (raw)
In-Reply-To: <9da85a53252e304aef90f0e54805feaee61b75c5.1653030578.git.sthotton@marvell.com>
On Fri, May 20, 2022 at 12:41 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Fixed qos parameters getting over written and IAQ/TAQ threshold
> calculation.
>
> Fixes: 910da32c53a9 ("event/cnxk: add device start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/common/cnxk/roc_sso.c | 4 ++--
> drivers/event/cnxk/cnxk_eventdev.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c
> index 358d37a9f2..8251c967fb 100644
> --- a/drivers/common/cnxk/roc_sso.c
> +++ b/drivers/common/cnxk/roc_sso.c
> @@ -406,10 +406,10 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos,
> }
> req->grp = qos[i].hwgrp;
> req->xaq_limit = (nb_xaq * (xaq_prcnt ? xaq_prcnt : 100)) / 100;
> - req->taq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
> + req->iaq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK *
> (iaq_prcnt ? iaq_prcnt : 100)) /
> 100;
> - req->iaq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
> + req->taq_thr = (SSO_HWGRP_TAQ_MAX_THR_MASK *
> (taq_prcnt ? taq_prcnt : 100)) /
> 100;
> }
> diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
> index b66f241ef8..2455b7be2d 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.c
> +++ b/drivers/event/cnxk/cnxk_eventdev.c
> @@ -513,10 +513,10 @@ cnxk_sso_start(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn,
>
> plt_sso_dbg();
> for (i = 0; i < dev->qos_queue_cnt; i++) {
> - qos->hwgrp = dev->qos_parse_data[i].queue;
> - qos->iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
> - qos->taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
> - qos->xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
> + qos[i].hwgrp = dev->qos_parse_data[i].queue;
> + qos[i].iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt;
> + qos[i].taq_prcnt = dev->qos_parse_data[i].taq_prcnt;
> + qos[i].xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt;
> }
> rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt,
> dev->xae_cnt);
> --
> 2.25.1
>
prev parent reply other threads:[~2022-06-13 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 7:11 Shijith Thotton
2022-06-13 5:58 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OzJhpBHCuHc3+GsYHawR-+huL-dmbKQ7ToRr1c2iBbqg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).