From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9025EA00C3 for ; Fri, 14 Oct 2022 06:26:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8693B42BF0; Fri, 14 Oct 2022 06:26:52 +0200 (CEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id 63CBB400D4; Fri, 14 Oct 2022 06:26:50 +0200 (CEST) Received: by mail-qt1-f177.google.com with SMTP id g11so3032364qts.1; Thu, 13 Oct 2022 21:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PNBaOrgp38DcVyvIp+yTlKcL2AB3pMLrvP7xYgzUhGE=; b=QDmSPEYXcF5nPsBIr1uRg6vRmkhPk03G/097fOVou1UoLmh/cDl13eMKOeo1OxJenJ mXPvZ5YbPh9E/FyTFhMxizdc61RyU/ldoFxnzrMclKAoMiz93+2Mwd8Cgd0NiY9v97qR JJ9TV+Uc3j4waMS/Zg+C6d0U+ze5Ny1b2uZk+x5i6QtOZma30MEsXGc+UNFNP1dPW/MY xx4/E0rqLk3L/QAw7saShgxyAUQESsQZtZPtuJE8WpMrUtgz1Wc8KGZG5+2AloV+KJ2o rMSuKF+YHbjPHfs1OOZWDsuzExScR9dv94xxUETikT/fMgNtFpiSpxlbZBhiQmo9neNl 6j8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PNBaOrgp38DcVyvIp+yTlKcL2AB3pMLrvP7xYgzUhGE=; b=N0SZSMLukywApPPuOmj7gR3fLCNauNTtXjZPIFSdoc2GC5FhrhS7u8oigInuctKUWm DEB8E5VCFnSLfWqm8nqbW6mY/8ZoMTKhs+oc7bq1bDxUDwN+Me1ubmQ1aMXfyWsvj5Af yCMQnfSPzKTUyYIDa74etowXL+/zzR0EuKPdlz2e4/CtRUxwv+MkNOQkLGt4D2cOLqpi um79czjT7xNHGwvAGVR3bjbyW0qmVmv4moBHFLwXdFq/xEqAzW3FWYlla1iOl74dOIyF LHE/eg5DlP9UvKJ6ERS++j8I6peZvMKr2hGsxg0WTt7NXh5+bEnSglCYTZ5r7a+EuW0q OL+w== X-Gm-Message-State: ACrzQf3TkNDRbElOezGFDSQLsDGvXDraoy6lTlqn9F8g1k/AkvXf2GeG Cqqja3he+KQe9i2XHU733IlsGawwUJCZjAXxF2w= X-Google-Smtp-Source: AMsMyM6kDEJk4gGU7keRm1hB85F3SshwkbpqiHtYGb//U0T2Tsm7s3Sgsf9ClLfRI4INaQdBsXnj+lQ/Gh5/7WLfDDA= X-Received: by 2002:a05:622a:48d:b0:39c:b642:824d with SMTP id p13-20020a05622a048d00b0039cb642824dmr2717939qtx.109.1665721609679; Thu, 13 Oct 2022 21:26:49 -0700 (PDT) MIME-Version: 1.0 References: <20220921120359.2201131-1-david.marchand@redhat.com> <20221012123112.2951802-1-david.marchand@redhat.com> <20221012123112.2951802-6-david.marchand@redhat.com> In-Reply-To: From: Jerin Jacob Date: Fri, 14 Oct 2022 09:56:23 +0530 Message-ID: Subject: Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points To: David Marchand Cc: Harman Kalra , Jerin Jacob Kollanukkaran , Sunil Kumar Kori , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Oct 14, 2022 at 12:41 AM David Marchand wrote: > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > With the whole traces fixes series applied first, then the new "trace: > > > take live traces via telemetry" patch applied, I can't reproduce your issue. > > > > > > > > > > Yes, you replicated the same scenario what I tried. > > Sorry, I realized that actually it's not an issue, traces generated after /trace/save are getting > > appended but in the same file (timestamped on /trace/save) on rte_eal_cleanup(). > > > > I assumed that trace dir generated with a timestamp will include all the trace points emitted > > before that timestamp. But in the above scenario same trace dir includes trace points emitted > > after this timestamp. I think this is bit confusing. Shall we add a logic where if already_done is > > set, rename the original trace dir to latest timestamp? > > Afaiu, the behavior before this series was the same. > An application calling rte_trace_save() would always save to a single directory. > One thing that changed though is that the directory is timestamped > with the time of the first call to rte_trace_save. > Before the seriesn the timestamp was based on the time when the trace > subsystem was initialised. > > > We can go with what you describe (which makes sense to me). > But I'd like to get a ack from traces maintainers before looking into it. IMO, We can remove "already_done" logic, whenever, rte_trace_save() called, it creates the directory of that timestamp and copies the trace buffers. Since we have "overwrite" and "discard" modes, it is better to not add "already_done" dogic in rte_trace_save(). > > > -- > David Marchand >