From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AD0BA0553 for ; Mon, 13 Jun 2022 14:45:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42E1D410DD; Mon, 13 Jun 2022 14:45:16 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id 9F9D0400EF; Mon, 13 Jun 2022 14:45:13 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id l192so1735688qke.13; Mon, 13 Jun 2022 05:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VD+f5ztL0FH2t1OD4NrVQ23Mvs3Tsq045MJzsEjtGd8=; b=g8VG6058V7jJCU6M7c3fKam+gS9/EKplfnULIerBPodfIWyxoPyn90tTUOEIEcwI5e zXCfKfG22CSW5LGeBPogS/5sZDLTuMJa1tvf9wLeBcS/sgG2bfCsaE56y53moRgl686a nNJqH5V+B/n0wBnTE5x1f1RLVmSucBwVaDCsf00XBakf/nB5rA96nBuy9GJDMxfnA8V8 Ls/aN73FPdTCmtVBQELA+G092j61FMWqQkNSb686Gp8jj6+txuOq5RpD6ocspmhDBLj0 mD/Ynt33WR+QCRN4TXv2ieJAyJJoodnKJbylkJVxcoKgUVe3HW154U8jwZ/+8rwoSk2S GJ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VD+f5ztL0FH2t1OD4NrVQ23Mvs3Tsq045MJzsEjtGd8=; b=fUQiw3Gn2cuM0CcPFWHc+ieZX2RpdZqhzhs9xtEsJ2EL04at9bHM4UpPMfeUQp3XVa 07ZIXHCs8XJSmHO9LvjEAahn91PalEi5p9oNG+At+aL79GRkfSIHRjx3sQ+ZI/lTW5xn Fl1CMfvWolZR0ahiolktz4fgnSoLlU38xE5k7+/5Nw0+jaDEQYTJqMHj9JAGHIAM1MKa AZisQRj81KOA6kOqfRAKr6VW8UPno3U2UdP+SpEqHQF1oxjwb8WvWEDjLYVudJ3ls8nA tPiDhYa+uLQyToKQRE0ILCw+oS+8yKADOh2s4J8K7y5MAvL2fseHeC9768TD81k0f/u8 Gz7Q== X-Gm-Message-State: AOAM530j37xbNGhxMGo0nL4Udza3xtiNDj5BULmriQKhS8O2eEF1xt79 7nDmhIvaAQDS3hjXNnQMtJb5JUUCF/pO9u9JyjtZmNsxwOc= X-Google-Smtp-Source: ABdhPJz7q9+MXs6bCVl0KroVgg64IcWkL/q3klD7tB0JTdD2f7Zb8Qj3wMLFyJYD21ynG0hMNd+X2+PdJ1CMn8bAIAE= X-Received: by 2002:ae9:e851:0:b0:6a7:5a0f:f7b9 with SMTP id a78-20020ae9e851000000b006a75a0ff7b9mr10220173qkg.316.1655124313019; Mon, 13 Jun 2022 05:45:13 -0700 (PDT) MIME-Version: 1.0 References: <20220519122151.3119730-1-david.marchand@redhat.com> In-Reply-To: <20220519122151.3119730-1-david.marchand@redhat.com> From: Jerin Jacob Date: Mon, 13 Jun 2022 18:14:46 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: fix crash in IPsec telemetry To: David Marchand Cc: dpdk-dev , dpdk stable , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Ankur Dwivedi , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, May 19, 2022 at 5:52 PM David Marchand wrote: > > Calling this telemetry callback with no argument caused a crash. > > Fixes: 41cc645c214f ("net/cnxk: add inline IPsec telemetry for CN9K") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c > index dfad5af8fe..bfdbd1ee5d 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c > +++ b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c > @@ -229,6 +229,9 @@ ethdev_sec_tel_handle_info(const char *cmd __rte_unused, const char *params, > uint32_t i; > int ret; > > + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) > + return -EINVAL; > + > port_id = strtoul(params, &end_p, 0); > if (errno != 0) > return -EINVAL; > -- > 2.36.1 >