From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 179A8423FE for ; Tue, 17 Jan 2023 16:19:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E741C400EF; Tue, 17 Jan 2023 16:19:41 +0100 (CET) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mails.dpdk.org (Postfix) with ESMTP id 70EBD400D4; Tue, 17 Jan 2023 16:19:41 +0100 (CET) Received: by mail-vs1-f51.google.com with SMTP id n190so28629969vsc.11; Tue, 17 Jan 2023 07:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Mjb50kGDjtgzfigXCrVHbnnTr+/kLd+bc7mCZ5khkcw=; b=dMtTc17JWPwmVqXx5LE/cf7kjjh78f6+EZLttFcMZkXqP+FUQfbCf3YBykoTZknzQI wVCILRgTX61EYapqKtmTUGZG/mTGfsoSUd8MY3seobbZYdOYfR8coyWMrC3VUMFtdljT n0jCA0jr7c4ERA80gzml7325UPi6Y2BDthVdooCsBNdO1W2bHv1zf3T+UFqcPFSdQwKT FvPfrV4hvJse8eKeExwi9X+LdYLqjtvVmuu+ZX0iWT93oc4Du5oV6b1OyuEOk/PMX6d8 Z/k340peeKlUrLFO0aZQk7J+EfGA0ouZaiZ/UOHvK2cWD+RIGT2+bsI9iXwQLno3i+1F wLZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mjb50kGDjtgzfigXCrVHbnnTr+/kLd+bc7mCZ5khkcw=; b=ZWgyFADzoVKuCRPHl06QFVGhWW9Q8hgf073t7+/jmLlkoibvSovz+++gxO6rgWhS4u ljQdkuzGAz/qpnY5TY5RPSkcftW2zkvKTdxIVr9y4CgkEBLKPgryaamZj7vWQnCkB1+f jLzJcXY2i8f60Nn8T5+Krult3+GcNkCUKqgDcTsRhT5b3Djrpv9RH7GANsQAFci6iPjS NMEdDif1QpDOqlYqDtjoVcdKyEjWLx/iSxmEgLuTBJoifhJjOHwBLNyEmIp9/f3VftrO Ow6cIPntZkAnPfN/BKK2o9gP+Oi3/yY2W3ZH3Qgf4fuGLXN3dci38WMzWa5cc+bJXhKh fJ4A== X-Gm-Message-State: AFqh2korAxU3Qsy0u00a/2YCsFzvAxulPG9bKNCO+0u7dRXH2218RboB Io096LR7uhI4DMO1tSMG5uo9xcHkqYJChphr/U0= X-Google-Smtp-Source: AMrXdXu6fs4wvlr8THYS3dp6JbAJRohnHFdUVqJE9zJ7doDyW2k5KY46t543vamFrryHjVDfZ1Lwod+MUYEdVCziiDg= X-Received: by 2002:a05:6102:5124:b0:3d3:c7fb:d602 with SMTP id bm36-20020a056102512400b003d3c7fbd602mr437699vsb.31.1673968780760; Tue, 17 Jan 2023 07:19:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Tue, 17 Jan 2023 20:49:14 +0530 Message-ID: Subject: Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get To: Shijith Thotton Cc: ganapati.kundapura@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com, dev@dpdk.org, stable@dpdk.org, Naga Harish K S V Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton wrote: > > The API to get rx adapter instance is returning error for event devices > with internal port capability and eth_rx_adapter_instance_get op > undefined. But as the Rx adapter is internally maintaining the queue > information needed to find the instance id, event devices can opt out > from defining the op. Modified code to match this logic. > > Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API") > > Signed-off-by: Shijith Thotton @Naga Harish K, S V (rx_adapter maintainer) please review this patch. > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index cf7bbd4d69..170823a03c 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id, > if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id, > eth_dev_id, > &caps)) { > - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) { > - ret = rxa_dev_instance_get(rx_adapter) ? > - rxa_dev_instance_get(rx_adapter) > - (eth_dev_id, > - rx_queue_id, > - rxa_inst_id) > - : -EINVAL; > - } > + if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT && > + rxa_dev_instance_get(rx_adapter)) > + ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id, > + rxa_inst_id); > } > > /* return if entry found */ > -- > 2.25.1 >