From: Jerin Jacob <jerinjacobk@gmail.com> To: Satheesh Paul <psatheesh@marvell.com>, Ferruh Yigit <ferruh.yigit@xilinx.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] net/cnxk: fix error message setting on failure Date: Tue, 3 May 2022 11:39:57 +0530 Message-ID: <CALBAE1PHRZLM64y1MghSn0n+CLB+ipBaj7=1BpSZDBpOVnh43Q@mail.gmail.com> (raw) In-Reply-To: <20220419063438.269086-1-psatheesh@marvell.com> On Tue, Apr 19, 2022 at 12:04 PM <psatheesh@marvell.com> wrote: > > From: Satheesh Paul <psatheesh@marvell.com> > > Set the error message with rte_flow_error_set() api > when flow parsing fails. > > Fixes: 8c009b4505e ("net/cnxk: support flow API") > Cc: stable@dpdk.org > > Signed-off-by: Satheesh Paul <psatheesh@marvell.com> > Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com> Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/cnxk/cnxk_flow.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c > index 8763ca63d6..2b13352312 100644 > --- a/drivers/net/cnxk/cnxk_flow.c > +++ b/drivers/net/cnxk/cnxk_flow.c > @@ -297,7 +297,14 @@ cnxk_flow_validate(struct rte_eth_dev *eth_dev, > return rc; > } > > - return roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow); > + rc = roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow); > + > + if (rc) { > + rte_flow_error_set(error, 0, rc, NULL, > + "Flow validation failed"); > + return rc; > + } > + return 0; > } > > struct roc_npc_flow * > -- > 2.25.4 >
prev parent reply other threads:[~2022-05-03 6:10 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-19 6:34 psatheesh 2022-05-03 6:09 ` Jerin Jacob [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALBAE1PHRZLM64y1MghSn0n+CLB+ipBaj7=1BpSZDBpOVnh43Q@mail.gmail.com' \ --to=jerinjacobk@gmail.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@xilinx.com \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=psatheesh@marvell.com \ --cc=skori@marvell.com \ --cc=skoteshwar@marvell.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git