patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: psatheesh@marvell.com
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	 Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter reset
Date: Fri, 16 Sep 2022 21:43:34 +0530	[thread overview]
Message-ID: <CALBAE1PWE4pLjBnpvErD=-O73iSTduB3O4d2_Bdq5ds0OOVs8A@mail.gmail.com> (raw)
In-Reply-To: <20220913051019.331807-1-psatheesh@marvell.com>

On Tue, Sep 13, 2022 at 10:40 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Added code to clear counters upon flow deletion.
>
> Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

Please use Kiran Kumar K as it is consistent across tree.

Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: fix missing flow counter reset

    Added code to clear counters upon flow deletion.

    Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
    Cc: stable@dpdk.org

    Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
    Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
>  drivers/common/cnxk/roc_npc_mcam.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
> index 82a9756189..4bea6719c5 100644
> --- a/drivers/common/cnxk/roc_npc_mcam.c
> +++ b/drivers/common/cnxk/roc_npc_mcam.c
> @@ -850,8 +850,10 @@ npc_flow_free_all_resources(struct npc *npc)
>         for (idx = 0; idx < npc->flow_max_priority; idx++) {
>                 while ((flow = TAILQ_FIRST(&npc->flow_list[idx])) != NULL) {
>                         npc_rss_group_free(npc, flow);
> -                       if (flow->ctr_id != NPC_COUNTER_NONE)
> +                       if (flow->ctr_id != NPC_COUNTER_NONE) {
> +                               rc |= npc_mcam_clear_counter(npc, flow->ctr_id);
>                                 rc |= npc_mcam_free_counter(npc, flow->ctr_id);
> +                       }
>
>                         npc_delete_prio_list_entry(npc, flow);
>
> --
> 2.35.3
>

      reply	other threads:[~2022-09-16 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  5:10 psatheesh
2022-09-16 16:13 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1PWE4pLjBnpvErD=-O73iSTduB3O4d2_Bdq5ds0OOVs8A@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=psatheesh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).