From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: "Jiang, Cheng1" <cheng1.jiang@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"anoobj@marvell.com" <anoobj@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v2] app/dma-perf: fix physical address seg-fault
Date: Wed, 4 Oct 2023 18:30:21 +0530 [thread overview]
Message-ID: <CALBAE1PYxQwqbn+ci+oELdJL1ZH13S=HyFt40xZa2_iw3H4dJQ@mail.gmail.com> (raw)
In-Reply-To: <MN2PR12MB3085D5B8B0DB13CC9AE58AA482CBA@MN2PR12MB3085.namprd12.prod.outlook.com>
On Wed, Oct 4, 2023 at 3:46 PM Varghese, Vipin <Vipin.Varghese@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Jerrin,
>
> Apologies for the delay, I missed on the comment
>
> ```
> > for (i = 0; i < nr_buf; i++) {
> > + void *src = rte_pktmbuf_mtod(dsts[i], void *);
> > + void *dst = rte_pktmbuf_mtod(srcs[i], void *);
>
> Use _const_ in fast path if src and dst in not changing as better optimization hint to compiler.
> ```
>
> Thanks for the suggestion, but may I ask this differently `rte_memcpy` is defined with `always_inline` and all places where src used is with `const *`. Hence I have different view there as `setting const * for always_inline definition has the same effect too`.
Yeah, most likely. However, Is the above behavior is documented in
gcc/clang? if not, the compiler is free to change as it deemed to fit
based on the register allocation and optimization flags etc.
next prev parent reply other threads:[~2023-10-04 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 7:18 [PATCH] " Vipin Varghese
2023-08-16 7:26 ` [EXT] " Anoob Joseph
2023-08-16 7:31 ` Varghese, Vipin
2023-08-16 9:24 ` [PATCH v2] " Vipin Varghese
2023-08-16 9:35 ` Vipin Varghese
2023-08-16 9:42 ` Vipin Varghese
2023-08-16 10:12 ` Jerin Jacob
2023-08-16 10:46 ` [EXT] " Anoob Joseph
2023-09-21 2:28 ` Jiang, Cheng1
2023-10-04 9:00 ` Varghese, Vipin
2023-10-04 13:00 ` Jerin Jacob [this message]
2023-10-19 4:19 ` [PATCH v3] " Vipin Varghese
2023-10-24 2:16 ` lihuisong (C)
2023-11-14 14:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PYxQwqbn+ci+oELdJL1ZH13S=HyFt40xZa2_iw3H4dJQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=Ferruh.Yigit@amd.com \
--cc=Vipin.Varghese@amd.com \
--cc=anoobj@marvell.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).