From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A06CEA0032 for ; Wed, 16 Mar 2022 05:43:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB8B041143; Wed, 16 Mar 2022 05:43:27 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id EF4C840395; Wed, 16 Mar 2022 05:43:25 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id q11so1112011iod.6; Tue, 15 Mar 2022 21:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=N3m86v1L4DPOD93algwX9+O9nHx1U0MdDqWoAfjq72w=; b=AeTlH7Uq3o6P8h4ti+yoG7IQMrx3fDMJCD/KOhThnTlBx3zU7tCtLhgIZqT6yP4JLi oMmYCKqKJxEMMPgCg08v2X4aHPhqxYsyNCqtYMDaEjLopGIXMv74TrpJ0do39bYwEfCe U6ACMRbFtHfq10vbplsz8F1gA6LoadqIiCnZmizeFebmxFxE7GhI3qrWwgzrF4hGGK/2 +O6XgnYyH6ts+cD05tSxm7wVy7/TQX5gKLIt7wBw1D/ScxFGmU6OPIYW5sH99FhYJGG/ wK28D8f1kD63/iOqGOXPYADlbyVRFk8f2wWdIqLfk+jcLZLlqvkQtNVkZajF7ma/jiFN MIhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=N3m86v1L4DPOD93algwX9+O9nHx1U0MdDqWoAfjq72w=; b=TLWwNGVUKTz9LsZbri+OCBCo428BuW/6ECZt0sFL8FUq4y9aujgds7xoctBlup91Ht yNbDDlgQzSX/rD4q/mlz6UCshzXH2n5qvoy2JLNxwFOGJWkrmQP+K9cR/Us0XDMG4i6h beoqSbzo1RWJyxOpdBWwXrTulw4EkNIxCtV5FLuL3om4OWTW+OzxxNm9diFQpnHo8Rx4 b4VAGchEmwUnjPgNoq7WVNPrjNMZBqMLmR78IYX0heHcAM6hKWTpQihpLtyjQToiZYq8 weE7sFF8iC7efGHvpsvxYK2wBF8ERfX0QwB4LoW8QmZfduhDZuDXpNTLGrL7gOufILWY YLAQ== X-Gm-Message-State: AOAM532Id93mOzng3iaL3xHCTvrPFVjyT7LoOVSt+KamKlbB4ZI/R6yy tQyRgLt6QYWYSl0jn+vmc+ajT06znx3ZQWOqA9M= X-Google-Smtp-Source: ABdhPJwAtEHLUeACc4Y9M1B0wzGQZhJ0qRwmutpemEkAY3Ga5xzm/BirdknnZH7ub8AMjbxE6MewsOM1f8NFRfGoFr0= X-Received: by 2002:a05:6638:16c5:b0:319:e32b:98e3 with SMTP id g5-20020a05663816c500b00319e32b98e3mr15526768jat.123.1647405805209; Tue, 15 Mar 2022 21:43:25 -0700 (PDT) MIME-Version: 1.0 References: <20220304142337.911828-1-rkudurumalla@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 16 Mar 2022 10:12:59 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: fix error when compiled for x86 To: "Gao, DaxueX" Cc: Rakesh Kudurumalla , "Jiang, YuX" , "Yigit, Ferruh" , "thomas@monjalon.net" , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "dev@dpdk.org" , "jerinj@marvell.com" , "stable@dpdk.org" , "Tu, Lijuan" , "Sun, QingX" , Rosen Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 16, 2022 at 9:02 AM Gao, DaxueX wrote: > > > -----Original Message----- > > From: Jerin Jacob > > Sent: 2022=E5=B9=B43=E6=9C=8810=E6=97=A5 16:49 > > To: Jiang, YuX > > Cc: Rakesh Kudurumalla ; Nithin Dabilpuram > > ; Kiran Kumar K ; > > Sunil Kumar Kori ; Satha Rao ; > > dev@dpdk.org; jerinj@marvell.com; stable@dpdk.org; Yigit, Ferruh > > > > Subject: Re: [PATCH] net/cnxk: fix error when compiled for x86 > > > > On Thu, Mar 10, 2022 at 7:06 AM Jiang, YuX wrote: > > > > > > Hi maintainers, > > > > > > Who can give acked-by for this patch? > > > May I know this patch can be merged into 22.03 or not? > > > > > > Acked-by: Jerin Jacob Updated the git commit as fo= llows > > and applied to dpdk-next-net-mrvl/for-next-net. Thanks > > > > net/cnxk: fix build error with optimization > > > > Fix the following build error seen with --optimization=3D1 and > > GCC 10.3.0. > > > > ../drivers/net/cnxk/cnxk_ethdev_mtr.c: In function > > =E2=80=98cnxk_nix_mtr_policy_validate=E2=80=99: > > ../lib/ethdev/rte_mtr_driver.h:188:10: error: =E2=80=98str=E2=80=99= may be used > > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > > > > ../drivers/net/cnxk/cn10k_rx.h:149:2 error: =E2=80=98frag_ptr=E2=80= =99 may be > > used uninitialized in this function > > > > Bugzilla ID: 939 > > Fixes: b526599020ef ("net/cnxk: fix build with GCC 12") > > Cc: stable@dpdk.org > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Rakesh Kudurumalla > > Tested-by: Daxue Gao > > Acked-by: Jerin Jacob > > > > > > > > > > > -----Original Message----- > > > > From: Rakesh Kudurumalla > > > > Sent: 2022=E5=B9=B43=E6=9C=884=E6=97=A5 22:24 > > > > To: Nithin Dabilpuram ; Kiran Kumar K > > > > ; Sunil Kumar Kori ; > > > > Satha Rao > > > > Cc: dev@dpdk.org; jerinj@marvell.com; Rakesh Kudurumalla > > > > ; stable@dpdk.org; Yigit, Ferruh > > > > > > > > Subject: [PATCH] net/cnxk: fix error when compiled for x86 > > > > > > > > fix error when compiled for x86 platform when compiled with > > > > optimization flag enabled > > > > error: =E2=80=98str=E2=80=99 may be used uninitialized in this func= tion > > > > error: =E2=80=98frag_ptr=E2=80=99 may be used uninitialized in this= function > > > > > > > > Bugzilla ID: 939 > > > > Fixes: b526599020ef ("net/cnxk: fix build with GCC 12") > > > > Cc: stable@dpdk.org > > > > > > > > Reported-by: Ferruh Yigit > > > > Signed-off-by: Rakesh Kudurumalla > > > > --- > [Gao, DaxueX] > > Hi Rakesh, Jacob and All, > > This patch http://patchwork.dpdk.org/project/dpdk/patch/20220304142337.91= 1828-1-rkudurumalla@marvell.com/ has been merged to DPDK 22.03 latest main = branch. > It can resolve old problem, but introduce new problem, please check your = code, thanks. > Notes: RHEL8.4 passed, Ubuntu20.04 failed. The error is coming from drivers/raw/ifpga/ifpga_rawdev.c: + rosen.xu@intel.com > > Bad commit: http://git.dpdk.org/dpdk/commit/?id=3D68f8a52a6b0ad6b77772d45= 64928aebb21c2ca66 > OS: Ubuntu20.04/5.8.0-48-generic > Compiler: gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 > > Error info: > [2302/3456] Compiling C object drivers/libtmp_rte_raw_ifpga.a.p/raw_ifpga= _ifpga_rawdev.c.o > FAILED: drivers/libtmp_rte_raw_ifpga.a.p/raw_ifpga_ifpga_rawdev.c.o > gcc -Idrivers/libtmp_rte_raw_ifpga.a.p -Idrivers -I../drivers -Idrivers/r= aw/ifpga -I../drivers/raw/ifpga -Idrivers/raw/ifpga/base -I../drivers/raw/i= fpga/base -Idrivers/net/ipn3ke -I../drivers/net/ipn3ke -Idrivers/net/i40e -= I../drivers/net/i40e -Ilib/rawdev -I../lib/rawdev -I. -I.. -Iconfig -I../co= nfig -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../li= b/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/ea= l/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/k= vargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Il= ib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -= Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib= /meter -Ilib/pci -I../lib/pci -Idrivers/bus/pci -I../drivers/bus/pci -I../d= rivers/bus/pci/linux -Idrivers/bus/vdev -I../drivers/bus/vdev -Idrivers/bus= /ifpga -I../drivers/bus/ifpga -Idrivers/net/i40e/base -I../drivers/net/i40e= /base -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/sched -I../lib/= sched -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Wi= nvalid-pch -Wextra -Werror -O1 -include rte_config.h -Wcast-qual -Wdeprecat= ed -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -W= missing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith = -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-= packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-= zero-length-bounds -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL= _API -DALLOW_INTERNAL_API -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE= =3Dpmd.raw.ifpga -MD -MQ drivers/libtmp_rte_raw_ifpga.a.p/raw_ifpga_ifpga_r= awdev.c.o -MF drivers/libtmp_rte_raw_ifpga.a.p/raw_ifpga_ifpga_rawdev.c.o.d= -o drivers/libtmp_rte_raw_ifpga.a.p/raw_ifpga_ifpga_rawdev.c.o -c ../drive= rs/raw/ifpga/ifpga_rawdev.c > ../drivers/raw/ifpga/ifpga_rawdev.c: In function =E2=80=98ifpga_rawdev_fi= ll_info=E2=80=99: > ../drivers/raw/ifpga/ifpga_rawdev.c:314:8: error: =E2=80=98vendor_id=E2= =80=99 may be used uninitialized in this function [-Werror=3Dmaybe-uninitia= lized] > 314 | if (vendor_id =3D=3D 0x8086 && > | ^ > ../drivers/raw/ifpga/ifpga_rawdev.c:316:23: error: =E2=80=98dev_id=E2=80= =99 may be used uninitialized in this function [-Werror=3Dmaybe-uninitializ= ed] > 315 | (dev_id =3D=3D 0x0CF8 || > | ~~~~~~~~~~~~~~~~~~~~ > 316 | dev_id =3D=3D 0x0D58 || > | ~~~~~~~~~~~~~~~~~^~ > 317 | dev_id =3D=3D 0x1580)) { > | ~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > [2311/3456] Compiling C object drivers/libtmp_rte_raw_ntb.a.p/raw_ntb_ntb= .c.o > ninja: build stopped: subcommand failed. > > Best regards, > Daxue Gao