From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D654A0526 for ; Tue, 21 Jul 2020 14:13:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D17841BFF9; Tue, 21 Jul 2020 14:13:08 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 3239D1BFF9; Tue, 21 Jul 2020 14:13:07 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id o3so16135658ilo.12; Tue, 21 Jul 2020 05:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X7nSYZQPXcN3Q4d7EcnoL1HUI+LCF81AIGGXgpLA+rI=; b=oDGzipj9GpI4vfF8BRmkz74ow0Kla16TA7qpySed+wvcLAfICVoNGLaTatyJYG9/hu XpWMTbgR8tJDw58GWOjmiez8lon/AlnO96KqMJ36KKqnwOkBci9CyaT56zh/xvd32U7m koOQz8oIvbaYwWE2xMdM0rgaIkESa580145w/UukbiygT9rbL6fiHlTIbX/2T+OiOf+D SmPksqIcQHxRrtXRgCghVy1KhOrxHJWxDT8X27HDu/IQ4V1AO2AkcbktHqarq+d1fVAv hi1Ld2YMr++eHaHTWn9ss1ZeShuxhx/ASNxpjAIXGt6OxpePB6Ps0zxKTbyHImwNJ++r IZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X7nSYZQPXcN3Q4d7EcnoL1HUI+LCF81AIGGXgpLA+rI=; b=PcYVS/42KNecioBLrruNYLbHGOyV0nfm4cqmedMnlvd4cD/8UlyLK9ddeZglyuKyKd TAt4ksipocCN6in9dUT0qphcagAeo7DHSTrLzksuqVJBiPRYkeCiMeK2FyguBIGeOVMP QBh9pSZ0+b8HVKxJC8q4fGOkQPgWUk7f5eP1xFRbo1I0n3solZvYNA63OkHWhxJPa6OF 3pHqFgtEovzVB5cVobAw3XqhK+dbT34WaTuDK9ieWQHZ8TxydjeNJoQDjdQI/RPKnAdZ 1tuAmj9Hfz+I+71uah82SRK+yix7osYLiWf8aM50Bv3Y0kR0tZO4H9TXs/4hPC9ek1PJ fMOg== X-Gm-Message-State: AOAM533/8/TvuZ1VCNZHb+8jXZSTRpxYNgY+aT/2FHpj0kaTsBZwN1e1 7+7P6hi6kaQZfxsOJNU1e7A//08bbfUN2jX8c/A= X-Google-Smtp-Source: ABdhPJz+ON++pxzuSSgjrg2ult6lJL9Ejmc9L7AiEBc7H6aVWSxXVHVKZszuhGHU/kxOtFnVhAinIvhPow1bI0+vvBc= X-Received: by 2002:a92:1547:: with SMTP id v68mr28761018ilk.294.1595333586412; Tue, 21 Jul 2020 05:13:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Tue, 21 Jul 2020 17:42:50 +0530 Message-ID: To: wangyunjian Cc: dpdk-dev , Rasesh Mody , Shahed Shaikh , "Lilijun (Jerry)" , xudingke , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/qede: remove dead code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Jul 17, 2020 at 4:47 PM wangyunjian wrote: > > From: Yunjian Wang > > This patch fixes (Logically dead code) coverity issue. > > Coverity issue: 261777, 261778 > Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") > Cc: stable@dpdk.org @Rasesh Mody Could you Ack this change to merge it? > Signed-off-by: Yunjian Wang > --- > drivers/net/qede/qede_rxtx.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c > index 9878ba50e..ea264f59d 100644 > --- a/drivers/net/qede/qede_rxtx.c > +++ b/drivers/net/qede/qede_rxtx.c > @@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev) > > for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { > fp = &qdev->fp_array[sb_idx]; > - if (!fp) > - continue; > fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info), > RTE_CACHE_LINE_SIZE); > if (!fp->sb_info) { > @@ -678,8 +676,6 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) > > for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { > fp = &qdev->fp_array[sb_idx]; > - if (!fp) > - continue; > DP_INFO(edev, "Free sb_info index 0x%x\n", > fp->sb_info->igu_sb_id); > if (fp->sb_info) { > -- > 2.23.0 > >