patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/octeontx2: fix get supported ptype callback
@ 2019-12-12 17:58 Harman Kalra
  2020-01-13  9:31 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Harman Kalra @ 2019-12-12 17:58 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran, Nithin Kumar Dabilpuram,
	Kiran Kumar Kokkilagadda
  Cc: dev, Harman Kalra, stable

Setting up supported ptypes using testpmd command is failing
because supported_ptypes_get callback will never return ptypes
supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags
is zero by default in testpmd.

Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types")
Cc: stable@dpdk.org

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 drivers/net/octeontx2/otx2_lookup.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
index bcf2ff4e8..568557116 100644
--- a/drivers/net/octeontx2/otx2_lookup.c
+++ b/drivers/net/octeontx2/otx2_lookup.c
@@ -17,7 +17,7 @@
 const uint32_t *
 otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
 {
-	struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
+	RTE_SET_USED(eth_dev);
 
 	static const uint32_t ptypes[] = {
 		RTE_PTYPE_L2_ETHER_QINQ, /* LB */
@@ -56,10 +56,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
 		RTE_PTYPE_UNKNOWN,
 	};
 
-	if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F)
-		return ptypes;
-	else
-		return NULL;
+	return ptypes;
 }
 
 int
-- 
2.18.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/octeontx2: fix get supported ptype callback
  2019-12-12 17:58 [dpdk-stable] [PATCH] net/octeontx2: fix get supported ptype callback Harman Kalra
@ 2020-01-13  9:31 ` " Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2020-01-13  9:31 UTC (permalink / raw)
  To: Harman Kalra, Ferruh Yigit
  Cc: Jerin Jacob Kollanukkaran, Nithin Kumar Dabilpuram,
	Kiran Kumar Kokkilagadda, dev, stable

On Thu, Dec 12, 2019 at 11:29 PM Harman Kalra <hkalra@marvell.com> wrote:
>
> Setting up supported ptypes using testpmd command is failing
> because supported_ptypes_get callback will never return ptypes
> supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags
> is zero by default in testpmd.
>
> Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types")
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks

> ---
>  drivers/net/octeontx2/otx2_lookup.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
> index bcf2ff4e8..568557116 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -17,7 +17,7 @@
>  const uint32_t *
>  otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
>  {
> -       struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
> +       RTE_SET_USED(eth_dev);
>
>         static const uint32_t ptypes[] = {
>                 RTE_PTYPE_L2_ETHER_QINQ, /* LB */
> @@ -56,10 +56,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)
>                 RTE_PTYPE_UNKNOWN,
>         };
>
> -       if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F)
> -               return ptypes;
> -       else
> -               return NULL;
> +       return ptypes;
>  }
>
>  int
> --
> 2.18.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 17:58 [dpdk-stable] [PATCH] net/octeontx2: fix get supported ptype callback Harman Kalra
2020-01-13  9:31 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox