From: Jerin Jacob <jerinjacobk@gmail.com> To: Nithin Dabilpuram <ndabilpuram@marvell.com> Cc: Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, dpdk-dev <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>, dpdk stable <stable@dpdk.org> Subject: Re: [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path Date: Tue, 3 May 2022 23:06:59 +0530 Message-ID: <CALBAE1Poqe=8GBQi3RcRtiS0=0K8Qzne6Zt86Km=hd-wPiwNUA@mail.gmail.com> (raw) In-Reply-To: <20220422104709.20722-28-ndabilpuram@marvell.com> On Fri, Apr 22, 2022 at 4:20 PM Nithin Dabilpuram <ndabilpuram@marvell.com> wrote: > > Fix multi-seg extraction in vwqe path to avoid updating mbuf[] > array until it is used via cq0 path. > > Fixes: 7fbbc981d54f ("event/cnxk: support vectorized Rx event fast path") > Cc: pbhagavatula@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> Please fix following check-gitlog.sh errors Wrong headline prefix: net/cnxk: add receive channel backpressure for SDP Is it candidate for Cc: stable@dpdk.org backport? common/cnxk: fix SQ flush sequence common/cnxk: fix issues in soft expiry disable path net/cnxk: optimize Rx fast path for security pkts > --- > drivers/net/cnxk/cn10k_rx.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h > index 00bec01..5ecb20f 100644 > --- a/drivers/net/cnxk/cn10k_rx.h > +++ b/drivers/net/cnxk/cn10k_rx.h > @@ -1673,10 +1673,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, > vst1q_u64((uint64_t *)mbuf2->rearm_data, rearm2); > vst1q_u64((uint64_t *)mbuf3->rearm_data, rearm3); > > - /* Store the mbufs to rx_pkts */ > - vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > - vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > - > if (flags & NIX_RX_MULTI_SEG_F) { > /* Multi segment is enable build mseg list for > * individual mbufs in scalar mode. > @@ -1695,6 +1691,10 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, > mbuf3, mbuf_initializer, flags); > } > > + /* Store the mbufs to rx_pkts */ > + vst1q_u64((uint64_t *)&mbufs[packets], mbuf01); > + vst1q_u64((uint64_t *)&mbufs[packets + 2], mbuf23); > + > /* Mark mempool obj as "get" as it is alloc'ed by NIX */ > RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1); > RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1); > -- > 2.8.4 >
prev parent reply other threads:[~2022-05-03 17:37 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20220422104709.20722-1-ndabilpuram@marvell.com> 2022-04-22 10:46 ` [PATCH v2 12/28] net/cnxk: add barrier after meta batch free in scalar Nithin Dabilpuram 2022-04-22 10:46 ` [PATCH v2 14/28] net/cnxk: fix roundup size with transport mode Nithin Dabilpuram 2022-04-22 10:47 ` [PATCH v2 28/28] net/cnxk: fix multi-seg extraction in vwqe path Nithin Dabilpuram 2022-04-22 10:54 ` Pavan Nikhilesh Bhagavatula 2022-05-03 17:36 ` Jerin Jacob [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALBAE1Poqe=8GBQi3RcRtiS0=0K8Qzne6Zt86Km=hd-wPiwNUA@mail.gmail.com' \ --to=jerinjacobk@gmail.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=pbhagavatula@marvell.com \ --cc=skori@marvell.com \ --cc=skoteshwar@marvell.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git