From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5B241DC9 for ; Fri, 3 Mar 2023 16:55:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E43F8427E9; Fri, 3 Mar 2023 16:55:29 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id 5BC5F40ED9; Fri, 3 Mar 2023 16:55:27 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id o2so2775707vss.8; Fri, 03 Mar 2023 07:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xjk9LYJJ/FDQV+WpWs5Oy2nboOJRsu/gFKPGTXGpaAQ=; b=NdijDEhepWX7V9QCxHbuvhafFfzRVwRGfS8kgNkz0R1KtHBcoYb7C57W/YqTIqrVfU CGHrkeQ5p/+dJbHxC9J24pe2JXV0RZpDAGMsJuRPN0dUIUcVcQ8e9H2iDvGflUeSs24x QFGFct4u7TZicgAPVxqTKSY1mUG+VKOKtUNkkLcRYUzu823Q3KHK19o1Y1u7ePMwwb3G 4U5brswJW2F8RLPNCkrGQRRPGHSlPBDumqo+TTZ+fXrDpAQtdH6xgZSEtRTRGIyvvgfu cO0bLyfJsr9kJ7Tvr+KF6UIL/j9vdG1P1G+DzSCG4CKKht4xWnCTLFw1pI2OpzmOGjD8 jHuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xjk9LYJJ/FDQV+WpWs5Oy2nboOJRsu/gFKPGTXGpaAQ=; b=yb/VViFVJ7QzYjZFAuXSQZYXZnwmv6trCh8Uag+OXRu5yUb1DsziWp5eVdNn7k/OLG sfYV5AwALRhhry3IVDbIrvaIgoHmktamsTzlAVYfz3uJH5qvXNkUcL8aQl2DOoMnyWzD w84vcWI6Ex5aVpw+A7NBv6C6Z91iXgm9vTJuTtyJP9r57ewxO91X0nyXRzmQ7KGljGvd on7L8WcqpU2PftpgnQbGQhfF3oT9yxWMgTNlgI6iuebv7thDaxBZjOb19Gwwh3aknBEw L4i5Shpi+vpgBmUCwS59W+0f8djFWUtduIfcTmjigAH2efFqQSl5bnjnvebRnlNnziRk 7Rdw== X-Gm-Message-State: AO0yUKV+Z4PnpJ+vEmqDqzZnP1Q4wTtOPIOM0jfzgFSayqkYtzSq/pd7 VjG5O9cH5q4H2NOncwvA0uXSuyv/g53SRv77who= X-Google-Smtp-Source: AK7set+JoQJHGehHhZPRDyyt7s/vD8e/+2UhA3+UVwMEe+CdeZ9HvMo1Pct2788JWTE8s3Nu7mztOx8vqsHXIvsENpY= X-Received: by 2002:a67:e053:0:b0:415:48dd:e0b9 with SMTP id n19-20020a67e053000000b0041548dde0b9mr1591559vsl.3.1677858926673; Fri, 03 Mar 2023 07:55:26 -0800 (PST) MIME-Version: 1.0 References: <20230228213123.371897-1-abdullah.sevincer@intel.com> In-Reply-To: <20230228213123.371897-1-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Fri, 3 Mar 2023 21:25:00 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev: fix invalid memory free operation To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, pbhagavatula@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 1, 2023 at 3:01=E2=80=AFAM Abdullah Sevincer wrote: > > This commit fixes invalid memory free operation > caused by extending xstats ID width from 32 to 64 bits. > > Telemetry application crashed when freeing memory, > hence, the telemetry app could not display xstats. > > Fixes: 1bdfe4d76e98 ("eventdev: increase xstats ID width to 64 bits") > Cc: stable@dpdk.org > > Signed-off-by: Abdullah Sevincer Looks good to me. Acked-by: Jerin Jacob Updated the git commit as follows and applied to dpdk-next-net-eventdev/for-main. Thanks eventdev: fix invalid memory free operation Fixe the invalid memory free operation caused by extending xstats ID width from 32 to 64 bits. Telemetry application crashed when freeing memory, hence, the telemetry app could not display xstats. Fixes: 1bdfe4d76e98 ("eventdev: increase xstats ID width to 64 bits") Cc: stable@dpdk.org Signed-off-by: Abdullah Sevincer Acked-by: Jerin Jacob > --- > lib/eventdev/rte_eventdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index 71a29f3506..6ab4524332 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -1725,7 +1725,7 @@ eventdev_build_telemetry_data(int dev_id, > if (xstat_names =3D=3D NULL) > return -1; > > - ids =3D malloc((sizeof(unsigned int)) * num_xstats); > + ids =3D malloc((sizeof(uint64_t)) * num_xstats); > if (ids =3D=3D NULL) { > free(xstat_names); > return -1; > -- > 2.25.1 >