From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 001FE1B29A for ; Fri, 26 Jan 2018 14:51:37 +0100 (CET) Received: by mail-lf0-f66.google.com with SMTP id o89so754593lfg.10 for ; Fri, 26 Jan 2018 05:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SCvFceNQXbj51uN+Atvp4vrx7CbTNZmupkF/0w+BHgU=; b=g5+GueIy22sYsmOO6HxCsTm5U+TtgeqyWYrX3lJWPvkYboO1ItciuZbiMjVVLTiCAW 9cso92YAMTEHliPEBpRewE31PtNnk3NBJM/m3sVDL7hvZXK+fg6erIctlWxxj95SY5UM 6GE9EVMOYYmKDg4XgD+8WJ3Gah13yRR2rXGRHQfbXQELdhFwHxdveLui43U24kfM6osk b6TRlEpAJTIDXDOmTcj23cOHqTLtWi1ntbbN8nN4f0gPRz1tIsw62/ohX3Eo9yVXbYON 5V2f88Oz1bWgpBR5XT3ntPbK8192SQSXLlG9aFg/Pk0I72ghug7fOGdMVwWAzZS6D9C8 hxhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SCvFceNQXbj51uN+Atvp4vrx7CbTNZmupkF/0w+BHgU=; b=VjFTZLYYICC7F1Ow9P2w+6j09glJ3knbKS4IWObIxQYLHIJPEuVfLbXETKgOPMx3jo kYly97vHWDoZvYsIkgSUljNETCH5LGqIWwRs+XK7hsGywYgHrKNnvBobKdyu5S21U3WA T8RC80u4Qkf9jEXoVGDsAI2EBqH/Ny2Hhn/zOV78/tB2Odu/wKMdgy9R5801zj3m/HyJ MLCUIOkvXgMXQUSvLlNMtFGBruLTIAG1ANHHsM1yfb9GET4uwlhwDQnKxJpWYk4kaGuV xpjOdbOl4rUUK66u9+Fa1E8QPP7cEaU+ZsnY0FPmLTMhNn2XQaCjdpiZA1ACrXzHOMZd ZE8A== X-Gm-Message-State: AKwxyte7Un1zXh9rQlrInZX6cdmg9ILivyWiPCjiFW+614yWJdC7G16C Z5BEMBEZFAjDNxFlcGiDyti0aqsfhIvwDDrAD7XFNRAbo/Q= X-Google-Smtp-Source: AH8x2273bi0R1852DrvJv3nDceCVUZH07QrXbKGpfpj+ibfsN68HhxFc4gEy6tkht+9Zu9Dqtnwx4EtVEvp5y/OVXbo= X-Received: by 10.46.101.207 with SMTP id e76mr9127152ljf.115.1516974697479; Fri, 26 Jan 2018 05:51:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.20.202 with HTTP; Fri, 26 Jan 2018 05:51:37 -0800 (PST) In-Reply-To: <1516973949.10752.3.camel@debian.org> References: <1516893132-8257-1-git-send-email-rk@semihalf.com> <1516973949.10752.3.camel@debian.org> From: =?UTF-8?B?UmFmYcWCIEtvemlr?= Date: Fri, 26 Jan 2018 14:51:37 +0100 Message-ID: To: Luca Boccassi Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] net/ena: TX L4 offloads should not be set in RX path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:51:38 -0000 Hello, I send this patch to stable list by mistake. I misunderstood git-send configuration. Currently this patch is under review on dpdk-dev list http://dpdk.org/ml/archives/dev/2018-January/089053.html. I am very sorry about the trouble I caused, I assure you that it will never happen again. Kind regards, Rafal Kozik 2018-01-26 14:39 GMT+01:00 Luca Boccassi : > On Thu, 2018-01-25 at 16:12 +0100, Rafal Kozik wrote: >> Information about received packet type detected by NIC should be >> stored in packet_type field of rte_mbuf. TX L4 offload flags should >> not be set in RX path. Only fields that could be set in of_flags >> during packet receiving are information if L4 and L3 checksum is >> correct. >> >> Fixes: 1173fca25af9 ("ena: add polling-mode driver") >> Cc: stable@dpdk.org >> >> Reported-by: Matthew Smith >> Signed-off-by: Rafal Kozik >> --- >> drivers/net/ena/ena_ethdev.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c >> b/drivers/net/ena/ena_ethdev.c >> index 83e0ae2..1e2af80 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -275,16 +275,17 @@ static inline void ena_rx_mbuf_prepare(struct >> rte_mbuf *mbuf, >> struct ena_com_rx_ctx >> *ena_rx_ctx) >> { >> uint64_t ol_flags = 0; >> + uint32_t packet_type = 0; >> >> if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_TCP) >> - ol_flags |= PKT_TX_TCP_CKSUM; >> + packet_type |= RTE_PTYPE_L4_TCP; >> else if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_UDP) >> - ol_flags |= PKT_TX_UDP_CKSUM; >> + packet_type |= RTE_PTYPE_L4_UDP; >> >> if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV4) >> - ol_flags |= PKT_TX_IPV4; >> + packet_type |= RTE_PTYPE_L3_IPV4; >> else if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV6) >> - ol_flags |= PKT_TX_IPV6; >> + packet_type |= RTE_PTYPE_L3_IPV6; >> >> if (unlikely(ena_rx_ctx->l4_csum_err)) >> ol_flags |= PKT_RX_L4_CKSUM_BAD; >> @@ -292,6 +293,7 @@ static inline void ena_rx_mbuf_prepare(struct >> rte_mbuf *mbuf, >> ol_flags |= PKT_RX_IP_CKSUM_BAD; >> >> mbuf->ol_flags = ol_flags; >> + mbuf->packet_type = packet_type; >> } >> >> static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, > > Hi, > > has a similar/related fix been applied to dpdk/master? > > -- > Kind regards, > Luca Boccassi