[PATCH 20.11] test/crypto: fix return value for SNOW3G

[PATCH 20.11] test/crypto: fix return value for SNOW3G

[Saoirse O'Donovan]

Unit tests were failing due to the return value of the decryption and
authentication functions not being handled correctly. This has now been
modified to return the expected test status.

Fixes: 326e988672aa ("test/crypto: fix bitwise operator in a SNOW3G case")
Cc: stable@dpdk.org

Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
---
 app/test/test_cryptodev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 34d162f48f..2e76763e09 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6386,6 +6386,7 @@ snow3g_hash_test_vector_setup(const struct snow3g_test_data *pattern,
 static int
 test_snow3g_decryption_with_digest_test_case_1(void)
 {
+	int ret;
 	struct snow3g_hash_test_data snow3g_hash_data;
 
 	/*
@@ -6394,8 +6395,9 @@ test_snow3g_decryption_with_digest_test_case_1(void)
 	 */
 	snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data);
 
-	if (test_snow3g_decryption(&snow3g_test_case_7))
-		return TEST_FAILED;
+	ret = test_snow3g_decryption(&snow3g_test_case_7);
+	if (ret != 0)
+		return ret;
 
 	return test_snow3g_authentication_verify(&snow3g_hash_data);
 }
-- 
2.25.1

Re: [PATCH 20.11] test/crypto: fix return value for SNOW3G

[Luca Boccassi]

On Thu, 15 Jun 2023 at 13:09, Saoirse O'Donovan
<saoirse.odonovan@intel.com> wrote:
>
> Unit tests were failing due to the return value of the decryption and
> authentication functions not being handled correctly. This has now been
> modified to return the expected test status.
>
> Fixes: 326e988672aa ("test/crypto: fix bitwise operator in a SNOW3G case")
> Cc: stable@dpdk.org
>
> Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
> ---
>  app/test/test_cryptodev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Thanks, applied.