From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D277743337 for ; Wed, 15 Nov 2023 12:49:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC1B840294; Wed, 15 Nov 2023 12:49:18 +0100 (CET) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by mails.dpdk.org (Postfix) with ESMTP id C010740285 for ; Wed, 15 Nov 2023 12:49:17 +0100 (CET) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-59b5484fbe6so76434447b3.1 for ; Wed, 15 Nov 2023 03:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700048957; x=1700653757; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W3S21e29M8RLJUyrRLBTGFgC637pMfBZ5Cvyo4u7jo4=; b=BxX4jHxIJ/EKbYSB+S0m4YorGzjkSrWZW0ElTzvLYN5EXnwKFjtgbHO2Z2ogKDh1W1 z+nV+J7OK+hKTBjE74UuT5f9kEmXBTmYqU6HfcoMlo+tnZwh6NpZVvcZv/h2/+yeKWM7 blnJ8QvK1+tZ1mYXpluYkBmglxpZ9LLopS5gk722H33n+OXAHBptI02AKHa8T7ApvwOm eSmzExLoJIBiYF3eutZOB4ig43DJGbSuRp7BQCNYASV8TjTwLVRpybYnPfofS+qAdy9Q Uuj6v8kA/ufCgjk2ZzcfBG5g0ceCdvonymWKtjAlIwE6IQ/HaIxSj1+qQWHmQlfD7w3g oBRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700048957; x=1700653757; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W3S21e29M8RLJUyrRLBTGFgC637pMfBZ5Cvyo4u7jo4=; b=YKtfFOQV/uNd1Po1+YU39q/fFLyDOy/zvv2EREAuuEC2PwcFTpojvTY6+cwDcDb1vu uDAuqOVdiVgNaVbShjPo/mAAibA2mdcXEt4IR3OPMAExYjVeBTEhBs9hGDlhty6TPXfH /Lbzm+Dn3WMJxom+yojZpFnlfzc3s1VjMwqDNb6byqZudHi7HbrL33b6CyE5NSfQ1uRT 8fJA6a+01ifoX1K70DCydRs2hlpBKPN0oezIU7EhvXTglRXngNQxBHDj0jRxSd7HIUBS fW+AcgmgxzUhg4sRc8Pj+xK9otn7Dt3jkIurxG/TMAbFDbVwgwG/VZDa2YwJe21CyGaU tuYQ== X-Gm-Message-State: AOJu0YzUJcE2nyC5MeurSq3j0P+L1HrnT0+uUW7pHgysJMc2QuS0jXjA 4r8WxzYCP31HWUSNt3QsiIqGgKVxfCFWP82rWa0C27fIOV8= X-Google-Smtp-Source: AGHT+IFjI7yu2YrFJBE9ZAS4qDemx+OzpSInNlKWtC0/5Xto62kysxGnc0eCgbD31Nmz0ysbvGcQrrP0+VTv6ixDEnw= X-Received: by 2002:a25:69cb:0:b0:d7b:9211:51a5 with SMTP id e194-20020a2569cb000000b00d7b921151a5mr13865528ybc.44.1700048957009; Wed, 15 Nov 2023 03:49:17 -0800 (PST) MIME-Version: 1.0 References: <20231115100539.62098-1-lihuisong@huawei.com> In-Reply-To: <20231115100539.62098-1-lihuisong@huawei.com> From: Luca Boccassi Date: Wed, 15 Nov 2023 11:49:06 +0000 Message-ID: Subject: Re: [PATCH 20.11] net/hns3: fix LRO offload to report To: Huisong Li Cc: stable@dpdk.org, liuyonglong@huawei.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 15 Nov 2023 at 10:05, Huisong Li wrote: > > [upstream commit a4b2c6815abd3e39daca2e2c93334b813e6a0be4] > > Some network engines, like part of HIP09, may not support LRO > offload, but this offload capability is also reported to user. > So this patch determines whether driver reports this capability > based on the capabilities from firmware. > > In addition, some network engines, like HIP08, always support LRO > offload and their firmware don't report this capability. So this > patch has to move getting revision ID codes to earlier stage and set > default capabilities for these network engines based on revision ID. > > Fixes: ab2e2e344163 ("net/hns3: get device capability in primary process") > Fixes: f5ed7d99cf45 ("net/hns3: extract common function to obtain revision ID") > > Signed-off-by: Huisong Li > Signed-off-by: Jie Hai > --- > drivers/net/hns3/hns3_cmd.c | 18 +++++++++-- > drivers/net/hns3/hns3_cmd.h | 1 + > drivers/net/hns3/hns3_ethdev.c | 50 +++++++++++++++++++------------ > drivers/net/hns3/hns3_ethdev.h | 5 ++++ > drivers/net/hns3/hns3_ethdev_vf.c | 28 ++++++----------- > drivers/net/hns3/hns3_rxtx.c | 3 ++ > 6 files changed, 65 insertions(+), 40 deletions(-) Thanks, applied