From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05D94432E4 for ; Thu, 9 Nov 2023 12:34:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F27E1402E5; Thu, 9 Nov 2023 12:34:48 +0100 (CET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id B7B4A40267 for ; Thu, 9 Nov 2023 12:34:47 +0100 (CET) Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-da7238b3eb4so859931276.1 for ; Thu, 09 Nov 2023 03:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699529687; x=1700134487; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SWpr41nG6hwj+4EHAL8uTFop8OuEPxvrQvPvgFTMqEQ=; b=F04Npzv0VpBTAMt19dKdrvZYWf7lEfJlZZ9tbbdASc1DYBtbcYQI8u0Z+XURReZ27n 3WLFp+LvNXGGbmKr0rtY2Nm/PEmTHlMHgDsnUcqqACBqb8nyeO+A75meq/3rH0uhdmdP IjncupJ3MXxFftcZ9R4iTN79pjh/YmszJTARP6jGkvE8qdKb6qY4GEuHN0HM0gUwelyt /fqLpnIFuOUMEY5QV6gbg7OBVlCOv3HdBFV/c59pNtWqZ13IEjiWeOjITSwzZSZbUU2/ MspsUPFzPqhzARFapskv2gV1q9rZA9fvXX1D01+Heou5RQnGpoqCKrpMZumPrC+pZSZi Z2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699529687; x=1700134487; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SWpr41nG6hwj+4EHAL8uTFop8OuEPxvrQvPvgFTMqEQ=; b=fecRdpQgq6PpEfZhUJUsAjVVtwnz4Q/Lw8qXrNoyiIvzpoqo6XUskafCFDf1uOWQ1/ uzvUO0W7aYlFeSexkDmw8Fe8Y/MrHc/GByowlHJYmkzFijWELTXaU/NNuZvGx1FWMI9k 4jq5q5SEmwR4q3qKRr7AVxRGF2V3gpkNn6ujPMAUVn9mzUY5lUz8YUjsPEd94p31pN8p qloyuF0/B7m8HiYlbTJionvmNQIIdCqspUVYNhhx92hl5wdUfwcHxcLpsnC+OBiyK31K ac/ksqXaBlN3SiCkf5ozxJEWi4NfkqBfVcXCVNOrcvW+F8nmmA4VJKRux4vFyjN53nTO to8g== X-Gm-Message-State: AOJu0YxFtm2hsy4/G64SaNhz4cmec8EwE1OrkwC9xVDtx1Lv1dj8wfU/ feA+3uhKBahWYzJGVIVFAvRUo7APadEQ3/OT5UhmSzgEmIcGzg== X-Google-Smtp-Source: AGHT+IFpXEhLba5kgf0b0AjSdwAnTXdDe44xtHA3f3IyQU8RlQ51ueQeqPD5KSGtB7w+sECGo2UG+H8ZsBnavgQ3qHo= X-Received: by 2002:a25:d616:0:b0:da3:7907:6ed with SMTP id n22-20020a25d616000000b00da3790706edmr5219341ybg.19.1699529686969; Thu, 09 Nov 2023 03:34:46 -0800 (PST) MIME-Version: 1.0 References: <20231109023345.3771714-1-chaoyong.he@corigine.com> In-Reply-To: <20231109023345.3771714-1-chaoyong.he@corigine.com> From: Luca Boccassi Date: Thu, 9 Nov 2023 11:34:35 +0000 Message-ID: Subject: Re: [PATCH 20.11] net/nfp: fix reconfigure logic in PF initialization To: Chaoyong He Cc: stable@dpdk.org, oss-drivers@corigine.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 9 Nov 2023 at 02:52, Chaoyong He wrote: > > [ upstream commit 1e80c07472aeed5669c79c0430b8aeece5129a20 ] > > There exists exit point between the reconfigure logic and the store > logic of the PF initialization, this may lead one situation that value > in the config bar is not same with the value stored in the data > structure. > > Fix this by move up the store statement. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") > > Signed-off-by: Chaoyong He > --- > drivers/net/nfp/nfp_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 4b890e3375..102d8f2938 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -746,6 +746,8 @@ nfp_net_start(struct rte_eth_dev *dev) > if (nfp_net_reconfig(hw, new_ctrl, update) < 0) > return -EIO; > > + hw->ctrl = new_ctrl; > + > /* > * Allocating rte mbufs for configured rx queues. > * This requires queues being enabled before > @@ -764,8 +766,6 @@ nfp_net_start(struct rte_eth_dev *dev) > hw->pf_port_idx, 1); > } > > - hw->ctrl = new_ctrl; > - > return 0; > > error: > -- > 2.39.1 Thanks, applied both fixes