From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E3E743BA7 for ; Thu, 7 Mar 2024 10:35:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27B8F40295; Thu, 7 Mar 2024 10:35:49 +0100 (CET) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by mails.dpdk.org (Postfix) with ESMTP id 3746F40272 for ; Thu, 7 Mar 2024 10:35:47 +0100 (CET) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-609f4155b76so2398967b3.1 for ; Thu, 07 Mar 2024 01:35:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709804146; x=1710408946; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qAAR2XinSKF87DI90PZ8+CxcbKvuAbF+xWovxwpZE0w=; b=Pc0xQpDworUzBmGjuCR2PiDpaIu8Tcwbz2xmNcgIJzYqnbK4/HsZgkUo5ToKy/N2oB aUCMSOII2vTR7ewI0VCFBaxCPPtEdFEhse/5Ee9OnetXcnI2q1YHES45pIErC/2i3W4J qTliKW6lNQrfF4o5izfP41cfRNHXlJvLtfuQNy2fq4JtFxWvlVkHvsTuS5veDuMOcTZm NwrtJzs2Z27uJWyP8oGUfXwCLNMiiYyZXuNPaqrCy+45jiJPt2LBOsdfo6Wy7d4EkZ/e wVIIniiMOutvxaeluTkL3OqVXSfjJPMRcsZnWYspqgksMa8z9CzZHJEjyvr4r5J7Nib3 YdPQ== X-Gm-Message-State: AOJu0Yw7UIeVnVBsx/7bgYh3qDLv59zOus1PBuM4Qfzlozy2nz41sWUm XYAMaWGnmuxsZE+D/0JiYmOa0frcop88Wv71Yx9/secwJz7tAyTTu0rtgleFAX8= X-Google-Smtp-Source: AGHT+IEXz+1upO1DREHOigPBwarssK+BPVR8fgfH61mCKZok9wngIqoexaFbsAydTpCH7jHeuauOYA== X-Received: by 2002:a81:6d48:0:b0:609:eb1e:1cf2 with SMTP id i69-20020a816d48000000b00609eb1e1cf2mr1849485ywc.41.1709804146225; Thu, 07 Mar 2024 01:35:46 -0800 (PST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id y76-20020a0dd64f000000b00608aeba302dsm337223ywd.14.2024.03.07.01.35.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 01:35:45 -0800 (PST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-609f4155b76so2398887b3.1 for ; Thu, 07 Mar 2024 01:35:45 -0800 (PST) X-Received: by 2002:a25:abb3:0:b0:dcf:ad31:57c9 with SMTP id v48-20020a25abb3000000b00dcfad3157c9mr15385375ybi.0.1709804145704; Thu, 07 Mar 2024 01:35:45 -0800 (PST) MIME-Version: 1.0 References: <20240307055639.1626192-1-chaoyong.he@corigine.com> <20240307055639.1626192-3-chaoyong.he@corigine.com> In-Reply-To: <20240307055639.1626192-3-chaoyong.he@corigine.com> From: Luca Boccassi Date: Thu, 7 Mar 2024 09:35:34 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 22.11 2/7] net/nfp: fix resource leak for flower firmware To: Chaoyong He Cc: stable@dpdk.org, oss-drivers@corigine.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 7 Mar 2024 at 06:05, Chaoyong He wrote: > > [ upstream commit 7c596721ae5f41d1dbab8b936a4983928d6b5603 ] > > Fix the resource leak problem in the logic of flower firmware > application. > > Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") > > Signed-off-by: Chaoyong He > --- > .../net/nfp/flower/nfp_flower_representor.c | 89 ++++++++++++++++++- > .../net/nfp/flower/nfp_flower_representor.h | 1 + > 2 files changed, 86 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/ne= t/nfp/flower/nfp_flower_representor.c > index 32c4574..854d117 100644 > --- a/drivers/net/nfp/flower/nfp_flower_representor.c > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c > ... > +static void > +nfp_flower_repr_free_all(struct nfp_app_fw_flower *app_fw_flower) > +{ > + uint32_t i; > + struct nfp_flower_representor *repr; > + > + for (i =3D 0; i < MAX_FLOWER_VFS; i++) { > + repr =3D app_fw_flower->vf_reprs[i]; > + if (repr !=3D NULL) { > + nfp_flower_repr_free(repr, NFP_REPR_TYPE_VF); > + app_fw_flower->vf_reprs[i] =3D NULL; > + } > + } > + > + for (i =3D 0; i < NFP_MAX_PHYPORTS; i++) { > + repr =3D app_fw_flower->phy_reprs[i]; > + if (repr !=3D NULL) { > + nfp_flower_repr_free(repr, NFP_REPR_TYPE_PHYS_POR= T); > + app_fw_flower->phy_reprs[i] =3D NULL; > + } > + } Thanks for sending the series, but this causes a compiler warning on Debian stable with gcc 12.2.0: [8/34] Compiling C object drivers/libtmp_rte_net_nfp.a.p/net_nfp_flower_nfp_flower_representor.c.o ../drivers/net/nfp/flower/nfp_flower_representor.c: In function =E2=80=98nfp_flower_repr_free_all=E2=80=99: ../drivers/net/nfp/flower/nfp_flower_representor.c:876:22: warning: iteration 8 invokes undefined behavior [-Waggressive-loop-optimizations] 876 | repr =3D app_fw_flower->phy_reprs[i]; | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/nfp/flower/nfp_flower_representor.c:875:23: note: within this loop