From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C296F43EB4 for ; Sat, 20 Apr 2024 00:21:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EE8D402A5; Sat, 20 Apr 2024 00:21:54 +0200 (CEST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mails.dpdk.org (Postfix) with ESMTP id 2404D402A3 for ; Sat, 20 Apr 2024 00:21:53 +0200 (CEST) Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-de466c641aaso2327364276.3 for ; Fri, 19 Apr 2024 15:21:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713565312; x=1714170112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KOWsC9E3QDf5Xs/qGbcNXzZVdLCNc8OPncRMHAEOdnA=; b=gdhfJEFcmJ0jp7Lu2g1SOL68pRIf0UcSJ10qVH13Ma8ROOBg0aRjUBu0L1W3zvKvVE gpQeiGtsYqHhhJkZJLb3Fk8HZPoBPSSPoD2g5ctdQibVFNs1yPkNx3JlsrmABXjmUgm2 UsOvDFLuIqwdT9QKbBmrDKyvXBoFlgBHOOPzRQ0d8DfRDKo1TcaHWrO8RcpSu2mjwhZd 1kTdkZq09a25nqOeIFwX3jJFRCQLe0Gh+2voauxOdZQEW6Xgi9OTK9MoHq6bIrpsiD4k gX2ED/KvGZUBtiJza/1cwqSwSveDKFh2Cj53r0BjgX6oUc9rTTrWk5RFnrvPofH2uFYP ylYg== X-Forwarded-Encrypted: i=1; AJvYcCUMaDtcB2OzfK1LnqkO/rATYx9NpbPrW6fE/edCufhpQVSXhEfoBFzMfiBIjdWQhKyeoBcgQMw+RufN2JtYiXk= X-Gm-Message-State: AOJu0YyC4FHtcO06HJm9bJ7IVk2WEyhj0w9KNOPuYcsVZE1CikPvbF8e /ZlkqKd2etx9XYb9vXFDY4S+p8FHLyC8ZxWGa1DoHB99G5z86B7KVsztuHC1 X-Google-Smtp-Source: AGHT+IGhMKRUvnfy0N/AOfGwzh/iZStf2dAP+QMiUZGlQNhmdxIErSRMEObtuW/PcWvyCNc7vf+hCQ== X-Received: by 2002:a05:6902:3c9:b0:de4:16b0:c8f6 with SMTP id g9-20020a05690203c900b00de416b0c8f6mr3133175ybs.14.1713565312260; Fri, 19 Apr 2024 15:21:52 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id n195-20020a25d6cc000000b00dc6e5ea9152sm988665ybg.29.2024.04.19.15.21.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 15:21:51 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-617d25b2bc4so26613707b3.2 for ; Fri, 19 Apr 2024 15:21:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXB6E2uA8oQaY6YXfdtFsKxb524O+C5k0FljeLV0XuCKbtlSCFNr7kIgqOcpbzrzUhVKipjYJ2eS3bWNlwJijY= X-Received: by 2002:a05:690c:6904:b0:61a:baf0:a0a5 with SMTP id if4-20020a05690c690400b0061abaf0a0a5mr3833853ywb.34.1713565311356; Fri, 19 Apr 2024 15:21:51 -0700 (PDT) MIME-Version: 1.0 References: <20240419130949.55341-1-dsosnowski@nvidia.com> In-Reply-To: <20240419130949.55341-1-dsosnowski@nvidia.com> From: Luca Boccassi Date: Fri, 19 Apr 2024 23:21:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 22.11] net/mlx5: fix incorrect counter cache dereference To: Dariusz Sosnowski , Ali Alnubani Cc: Matan Azrad , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 19 Apr 2024 at 14:10, Dariusz Sosnowski wrote: > > When counter pool is prepopulated with preallocated counters, > some counters were preloaded to per-queue caches. > Per-queue counter cache can be disabled due to a change introduced in > commit 244dbbf77871 ("net/mlx5: fix flow counter cache starvation"). > Aforementioned preload happened even if counter cache was disabled, > which caused a segmentation fault on the attempt to access the cache. > > This patch adds a missing check for counter cache before preloading. > > Fixes: 244dbbf77871 ("net/mlx5: fix flow counter cache starvation") > > Signed-off-by: Dariusz Sosnowski > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_hws_cnt.c | 38 ++++++++++++++++++--------------- > 1 file changed, 21 insertions(+), 17 deletions(-) Applied and pushed. Ali, is this the issue you mentioned on the validation report? If so is it all green now after this is included?