From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4318A00C4 for ; Fri, 5 Aug 2022 12:04:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E76340C35; Fri, 5 Aug 2022 12:04:04 +0200 (CEST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id C0C55400D5 for ; Fri, 5 Aug 2022 12:04:03 +0200 (CEST) Received: by mail-ej1-f54.google.com with SMTP id uj29so4254026ejc.0 for ; Fri, 05 Aug 2022 03:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=2cguoDsuNLVW2Lmi4g+LREEiNhJK5HbLqNMveA2478o=; b=IoU8unpQLxajkJcimm6cBxKqdpS3Pz5oZ257CPV2i3u8gwfT80LH3r6JcttO6N87Kz MPOCJXnTJh0OF3xPjd0qw9EoCvTIx8KBWyVOFsrpEoca8fI2g/vpXlctGwxCEd5C2jzI Z4lrjdhjPiA7ZUv9/88wpozRh04dRfH5yDG+nXJ+y6VRSgml3T7a0wdMXJrDAv/FZw5t wXn5VTKSeRLzBqBD5HHa5a7fjkpRVmxNIHtAClownafa+j7S6lMiJa0eUM5RGIflU5fy W3hoVAK1A8rTVuMYW3Yfmr3hzpORCsMAttciYu2uduPL8r+9LnP2UQaDovjbygwzoD0V u3jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=2cguoDsuNLVW2Lmi4g+LREEiNhJK5HbLqNMveA2478o=; b=OiUO79B3JhAKcOPXEsfW+1yN81aygEq874bjNvM0fIPt7DVGU0gwewL7w0ugX1I1LL 4jmJ/8NrT4q8r8jt7E6b7S5Dz0HJxEWxy5U698EOBpz8MZnz5ABBmpV5sHyc2g/xlWZJ AXDHiWI8yTSWb1yDa/YqZL/cWfGtpvIBmAOKnsyNrW7oZkHb7zTxmAkQ13A4erbPvM2K yItqhUaBxxG3xSn7H0Hk6/L+mNGCwAAOAIuqG370jpQ2trbil78kdsXzt20vkc6sK3kW h1987/xY0eoZZW0iZsYtPY98i8pgvEM0Un1lUNdPvFSHLg/qhkvHyyAZmzUr+NunzvJm WWMA== X-Gm-Message-State: ACgBeo14LDLzX3oq7+0JSCWdo/RFrARpHkHH7vGjIT8PzRMUcuiW4OBR KPNvXLSxXHt5rYzpy5t+GqLYnUj7xRjhLjTmgZCJ30tn X-Google-Smtp-Source: AA6agR5kkg//0UYjEJzUQCBdpfBVqnxKlDiISLDjXtYwmLTk8Ote7azrnNSC/cUcvJMiAYxiE+VgQbKiBBPRyqkhT9g= X-Received: by 2002:a17:906:4794:b0:730:fdac:dbcb with SMTP id cw20-20020a170906479400b00730fdacdbcbmr1608641ejc.130.1659693843475; Fri, 05 Aug 2022 03:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20220805022127.757324-1-wenwux.ma@intel.com> In-Reply-To: <20220805022127.757324-1-wenwux.ma@intel.com> From: Luca Boccassi Date: Fri, 5 Aug 2022 11:03:52 +0100 Message-ID: Subject: Re: [PATCH] net/vhost: fix null pointer dereference To: Wenwu Ma Cc: Maxime Coquelin , Chenbo Xia , dpdk stable , Jiayu Hu , Yinan Wang , "He, Xingguang" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 5 Aug 2022 at 03:22, Wenwu Ma wrote: > > Because the async member of the vhost_virtqueue struct > can be freed in controlpath, so it should be protected > by spinlock in datapath, or, it may cause null pointer > dereference in the following vhost_poll_enqueue_completed(). > > Fixes: b737fd613969 ("vhost: add unsafe async API to clear packets") > > Signed-off-by: Wenwu Ma > --- > lib/vhost/virtio_net.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Hi, Is this for a stable branch? If so, which one? Please use --subject-prefix next time to clearly identify it. Kind regards, Luca Boccassi