From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0D5443E36 for ; Wed, 10 Apr 2024 15:07:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81AD8402CF; Wed, 10 Apr 2024 15:07:27 +0200 (CEST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by mails.dpdk.org (Postfix) with ESMTP id 0FD53402C7 for ; Wed, 10 Apr 2024 15:07:27 +0200 (CEST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-61587aa956eso62812167b3.1 for ; Wed, 10 Apr 2024 06:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712754446; x=1713359246; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tlyWdllPOuS5XPpPEx9yBGE1gzGKdU9CHzkWQFtVMCQ=; b=mMXaJIqO9hF4/qFVE/M/SxgQEtBmiqyYMVdvIbFcNbHVCzjwFl59DWEbHrKwr9JoLt alJ2qUeIah1L64ZAqOcgF8S7X0FB0R9TlOkvw7LTa1+MbEOTtMVTQJ00lL9YogVc8FEJ 7G8E5jf+WBoVDKY8SLtwZG6T+wwkT07r7sYvJb1lp0zfNtrnihVMO+QdIJ8XLfujmG47 B343rvF4d2DIwh5cYVCod/OI3d973adFencRnrRvzPfwk3z5uymF++aZjhYWg5mpIGDS zbGxRvtTYPSHSskbx1FMr+98NL1m51dhf9idWQorV1Hg4/ARPEn1tsmw9Ys+c8Ntt71f ZJng== X-Gm-Message-State: AOJu0YxhwGY3ruWhJnL6zKxfkO5j/RIU27jILnjAt5RdESvMes+Bzv4F xC2fnB47hqBEHWGhzPbqsYMzKTJr3NVkfO2gIhsqIJQ6gMuVWYdAazXV6A6K/HY= X-Google-Smtp-Source: AGHT+IGR7lavDiFqxvcIqznr2od5DqYQZ1/5WQtlAd4vNq8/OcrYIS6VE5VH52RHXVw611G3VN5ypQ== X-Received: by 2002:a81:fd09:0:b0:610:f586:2b42 with SMTP id g9-20020a81fd09000000b00610f5862b42mr2676302ywn.46.1712754445962; Wed, 10 Apr 2024 06:07:25 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id b128-20020a0dd986000000b00615800d67c3sm2703657ywe.3.2024.04.10.06.07.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 06:07:25 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-617e6c873f3so46012027b3.2 for ; Wed, 10 Apr 2024 06:07:25 -0700 (PDT) X-Received: by 2002:a25:9391:0:b0:dcc:cadf:3376 with SMTP id a17-20020a259391000000b00dcccadf3376mr2570447ybm.18.1712754445565; Wed, 10 Apr 2024 06:07:25 -0700 (PDT) MIME-Version: 1.0 References: <20240405103803.2785764-1-ciara.power@intel.com> In-Reply-To: From: Luca Boccassi Date: Wed, 10 Apr 2024 14:07:14 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 22.11] crypto/ipsec_mb: fix incorrectly setting cipher keys To: "Power, Ciara" Cc: "stable@dpdk.org" , "De Lara Guarch, Pablo" , "Ji, Kai" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 10 Apr 2024 at 09:06, Power, Ciara wrote: > > > > > -----Original Message----- > > From: Luca Boccassi > > Sent: Monday, April 8, 2024 10:23 AM > > To: Power, Ciara > > Cc: stable@dpdk.org; De Lara Guarch, Pablo ; > > Ji, Kai > > Subject: Re: [PATCH 22.11] crypto/ipsec_mb: fix incorrectly setting cipher keys > > > > On Mon, 8 Apr 2024 at 08:17, Power, Ciara wrote: > > > > > > Hi Luca, > > > > > > > -----Original Message----- > > > > From: Luca Boccassi > > > > Sent: Friday, April 5, 2024 3:44 PM > > > > To: Power, Ciara > > > > Cc: stable@dpdk.org; De Lara Guarch, Pablo > > > > ; Ji, Kai > > > > Subject: Re: [PATCH 22.11] crypto/ipsec_mb: fix incorrectly setting > > > > cipher keys > > > > > > > > On Fri, 5 Apr 2024 at 11:46, Ciara Power wrote: > > > > > > > > > > The encryption and decryption keys were incorrectly being reset > > > > > based on authentication algorithm after already being set earlier > > > > > in the code based on cipher algorithm. > > > > > In cases when 3DES was used, the keys were being incorrectly > > > > > overwritten. > > > > > > > > > > For CPU path, there is no need to have the keys set for XCBC and > > > > > CMAC cases. > > > > > > > > > > Fixes: 010230a1543b ("crypto/aesni_mb: support Chacha20-Poly1305") > > > > > Fixes: b0a37e8cd2ac ("crypto/ipsec_mb: fix cipher key setting") > > > > > Fixes: a2c6d3f34f90 ("crypto/aesni_mb: support CPU crypto") > > > > > > > > > > Signed-off-by: Ciara Power > > > > > --- > > > > > Cc: pablo.de.lara.guarch@intel.com > > > > > --- > > > > > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 14 -------------- > > > > > 1 file changed, 14 deletions(-) > > > > > > > > I have already tagged rc1 - is this fixing a regression introduced > > > > in > > > > rc1 itself? If not, how important is it, could it wait for the next release? > > > > > > No, it is fixing an issue that existed before 22.11 itself. I have also sent the fix > > for 21.11 LTS. > > > The bug was reported by an external user as it caused seg faults for their > > algorithm use case, so the sooner the better for fix to be merged. > > > Would it be suitable for merge in rc2? > > > > I am not planning an rc2, but if you can confirm you have tested this patch on > > top of rc1 on the affected platform then I can merge it for the final release. > > Hi Luca, > > Ah no RC2, ok yes I understand. > I have tested with SW PMD autotests and perf tests on 22.11.5-rc1 + patch, all seems ok. > But if you would prefer to wait until next LTS release, that is fine with me - user can get the fix from the mailing list if needed in the meantime. That's ok given you have tested I'll push it, thanks.