From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4A09489F8 for ; Tue, 28 Oct 2025 15:48:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC7F5402F0; Tue, 28 Oct 2025 15:48:47 +0100 (CET) Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) by mails.dpdk.org (Postfix) with ESMTP id 28E1F402F0 for ; Tue, 28 Oct 2025 15:48:46 +0100 (CET) Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-63e3804362cso5549078d50.2 for ; Tue, 28 Oct 2025 07:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761662925; x=1762267725; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Oeq7o4aEv2hAZ3kz1jmZIWQZ7doJILHbHlnoHpXQGjE=; b=dEjzhCIYFR+liLbofNm0EXxzQRqBIMNIuINGLGRYhRrLWnSO0uf9HFGYgy6XniqDLV BJzzVraw9mfut7ORykilJcuoxYSy1iBgju/AsVnSUA4W/lvy9V/2957lBsboKSjWnZ4R WmDZtpIefUTibyNkpWDKax1alGP6xy0kwbNZcuX4qHm0XYkDWSIzaJNy8cpdYKGxe/yc rzD3CbbjTuLBMg6pzjn7eEjuHFALCzGgMsPCXtrizROkryDExz+s4/2vWljf+BkM3Eq3 7o5EfelQ6cXDL1YYBp95n51Ft0YrB42l9rt0BmwyObKU0229eXMU5VEiODqF+wTjkiQ5 BI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761662925; x=1762267725; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Oeq7o4aEv2hAZ3kz1jmZIWQZ7doJILHbHlnoHpXQGjE=; b=T4PbbSa7n9Kzlyi82LoP+fqZi78pKU9bRmbqIhJ2fk9+daUwqw/cSh9bMnf7ebKjOg RkgFKhNk+VYdu2uuYEv6HnPk1DfY+uTqCj929WT1QY1nBFM/kn7P/SmRsoVL3I63AG0E KdF3ibU8XpztD2GdymljigESZYLgJi4jBppUfGem/jpcMERW/zBHLM9R3415gsxEkboP EROudespSyrXefXA0uwLh0+7fT5md6UXOO/LkrOASe65qWaiHR/F9jx3NPP7veBZZBE9 n4ZettlxeYdtUTR68Vf4yfXpj4AWoq+sOheSv7sPuVsYU5e3yklCx9VYtus83VnPRelp MviA== X-Forwarded-Encrypted: i=1; AJvYcCWdfgkzuUctr7d7arPGMkmQEl7bCk5ij1bKNFSq/7N1MAzIrYJIStUQHP2vDLjgu52T0YYHYUE=@dpdk.org X-Gm-Message-State: AOJu0YxbVGUUhBhUevoc4QfTiu7wqVRqQSIvd4AH6FhIzEJgsBqesONn r4iwkHQlXyI2ebBqgHvYnLYNYveeQaBlEw0Ij/K3LOZ0OWgE8HdoYxo2wCfsW9DgTMsCxhuB94d CJkrytfFrT81OZb4YuDi+YxrFENXfuXD6R8qw X-Gm-Gg: ASbGncsbUZzvk/+I1EwnV9QuwIFvQeig1dy65K5XHoXXqjoRCNnV9JkOiRozMQrTgG8 wRTyKfSYJW0qZLC3sg/a1Zr23KMFvXIrWOInoESLTfJSiykLYy2F9NKc2zSiEKXnZQO3P3FpBGT zwglYdMRanHCUPjbP9tOyQPbhMCx7I3kAA9H4FKzr700eMyDkvjImsHVHlRcrvmF6d1bC29U7Iq aIm6qhWMHSJSDpkgSi0LBLNBiQVqHA5QHx6PMwVue4MUlRBWj6Rbnc3rcOK+pRD+ewD/ypwGpSQ wGdYia4ORf77BREP9mU= X-Google-Smtp-Source: AGHT+IHJcpEXt17ocV+3BYaOmzbMA5K+Z/URfX0FtkKw5oKENWP314xguwFRsihbFr7A1sGLv9CDNgdhNoQoiEVQ9PI= X-Received: by 2002:a05:690c:6602:b0:783:7081:c48b with SMTP id 00721157ae682-78617fda6c1mr56560117b3.57.1761662925223; Tue, 28 Oct 2025 07:48:45 -0700 (PDT) MIME-Version: 1.0 References: <20251028081601.1749225-1-rongweil@nvidia.com> <3058440.n97fhnxGW3@thomas> In-Reply-To: <3058440.n97fhnxGW3@thomas> From: Luca Boccassi Date: Tue, 28 Oct 2025 14:48:34 +0000 X-Gm-Features: AWmQ_bn3zvhaOnN7xvaQlviPhCvt-wSPdcsV-_lDmK9t4BTTuOVHSf2tQnDSOkY Message-ID: Subject: Re: [PATCH22.11 v1] net/mlx5: fix age checking crash To: Thomas Monjalon Cc: Rongwei Liu , stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, michaelba@nvidia.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 28 Oct 2025 at 13:10, Thomas Monjalon wrote: > > 28/10/2025 13:13, Luca Boccassi: > > On Tue, 28 Oct 2025 at 08:17, Rongwei Liu wrote: > > > > > > When aging is configured, there is a background thread > > > which queries all the counters in the pool. > > > > > > Meantime, per queue flow insertion/deletion/update changes > > > the counter pool too. It introduces a race condition between > > > resetting counters's in_used and age_idx fields during flow deletion > > > and reading them in the background thread. > > > > > > To resolve it, all key members of counter's struct > > > are placed in a single uint32_t and they are accessed atomically. > > > > > > To avoid the occasional timestamp equalization with age_idx, > > > query_gen_when_free is moved out of the union. The total memory > > > size is kept the same. > > > > > > Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") > > > Cc: michaelba@nvidia.com > > > Cc: stable@dpdk.org > > > Signed-off-by: Rongwei Liu > > > > Hi, > > > > I cannot seem to find a reference to this patch on the main branch? > > Was it merged with a different commit? > > It seems Rongwei didn't reuse the title updated while merging in main: > > https://git.dpdk.org/dpdk/commit/?id=820ca7361bb > > Note the new title is more precise, please use it: > net/mlx5: fix flow aging race condition Sounds good, thanks