From: Luca Boccassi <bluca@debian.org>
To: "Ma, WenwuX" <wenwux.ma@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
dpdk stable <stable@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>
Subject: Re: [PATCH] net/vhost: fix null pointer dereference
Date: Mon, 8 Aug 2022 14:02:22 +0100 [thread overview]
Message-ID: <CAMw=ZnS0cMba7-=5kD53SCS5xbAudF-YztwnZC4AwB+jRdd1rg@mail.gmail.com> (raw)
In-Reply-To: <MN0PR11MB611027DEE6AA66AE9BD2D70AEB639@MN0PR11MB6110.namprd11.prod.outlook.com>
On Mon, 8 Aug 2022 at 02:01, Ma, WenwuX <wenwux.ma@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: 2022年8月5日 23:09
> > To: Ma, WenwuX <wenwux.ma@intel.com>
> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>; dpdk stable <stable@dpdk.org>; Hu, Jiayu
> > <jiayu.hu@intel.com>; Wang, Yinan <yinan.wang@intel.com>; He, Xingguang
> > <xingguang.he@intel.com>
> > Subject: Re: [PATCH] net/vhost: fix null pointer dereference
> >
> > On Fri, 2022-08-05 at 10:12 +0000, Ma, WenwuX wrote:
> > >
> > > > -----Original Message-----
> > > > From: Luca Boccassi <luca.boccassi@gmail.com>
> > > > Sent: 2022年8月5日 18:04
> > > > To: Ma, WenwuX <wenwux.ma@intel.com>
> > > > Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> > > > <chenbo.xia@intel.com>; dpdk stable <stable@dpdk.org>; Hu, Jiayu
> > > > <jiayu.hu@intel.com>; Wang, Yinan <yinan.wang@intel.com>; He,
> > > > Xingguang <xingguang.he@intel.com>
> > > > Subject: Re: [PATCH] net/vhost: fix null pointer dereference
> > > >
> > > > On Fri, 5 Aug 2022 at 03:22, Wenwu Ma <wenwux.ma@intel.com> wrote:
> > > > >
> > > > > Because the async member of the vhost_virtqueue struct can be
> > > > > freed in controlpath, so it should be protected by spinlock in
> > > > > datapath, or, it may cause null pointer dereference in the
> > > > > following vhost_poll_enqueue_completed().
> > > > >
> > > > > Fixes: b737fd613969 ("vhost: add unsafe async API to clear
> > > > > packets")
> > > > >
> > > > > Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> > > > > ---
> > > > > lib/vhost/virtio_net.c | 12 +++++++++---
> > > > > 1 file changed, 9 insertions(+), 3 deletions(-)
> > > >
> > > > Hi,
> > > >
> > > > Is this for a stable branch? If so, which one? Please use
> > > > --subject-prefix next time to clearly identify it.
> > > >
> > > Sorry, it is 21.11
> >
> > Does this issue affect only 21.11? Or main as well?
> >
> Only 21.11
Thanks, applied and pushed.
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2022-08-08 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:21 Wenwu Ma
2022-08-05 10:03 ` Luca Boccassi
2022-08-05 10:12 ` Ma, WenwuX
2022-08-05 15:09 ` Luca Boccassi
2022-08-08 1:00 ` Ma, WenwuX
2022-08-08 13:02 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw=ZnS0cMba7-=5kD53SCS5xbAudF-YztwnZC4AwB+jRdd1rg@mail.gmail.com' \
--to=bluca@debian.org \
--cc=chenbo.xia@intel.com \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).