From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E74AA034C for ; Mon, 8 Aug 2022 15:02:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 676244067B; Mon, 8 Aug 2022 15:02:36 +0200 (CEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 36BA74014F for ; Mon, 8 Aug 2022 15:02:35 +0200 (CEST) Received: by mail-io1-f48.google.com with SMTP id e69so7014952iof.5 for ; Mon, 08 Aug 2022 06:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=oHS7tysfeNC4TyX/S993M2b06zF1otjpvZzoW26mT5I=; b=1sA2ecTTra377pGO7okE2GFk7FKnjYnUCNr3NMDbcq52odDNLVYZLiJmm5CjxyyCiT i8f421pgXV1+ntMdCVsqQklJZhIJVLLUxjzu/6l+oTRBsWKeUR6jwlhb6S5w5k++epDs KSht4y4xclut7ORCVYUAfoqGDggx0uM9smHyJIpMxccVIbnWmoXDRPnId198aW+zCcDN 2cvDKVih/CnOwtmTQF57jHTZkxiClTV3dYvkyIVlpdpAwQgcM7O9gt4q+QFy0hF5GwZs FP+rwnyoLFznkDt9F9s2Ne+U8cD5QM8fpdgqlzv1/rykQ59gd3S+7QLrRRda5R5PSZTH WubQ== X-Gm-Message-State: ACgBeo1GERjllbTZO7NFkTa0CKTGnWWbFKBGFoiq0S3QlBh6dC4LmTqU tLrHHoOuBUfC9swJMJuQcJanVii98TtRDQ== X-Google-Smtp-Source: AA6agR5e33IthmHoY95ruUNKfq1MRlkneP9GMImZ0c6zACdH2LHYHnFw67e5AgYDbRSm+aI6ZlQNhw== X-Received: by 2002:a05:6602:13c9:b0:684:c06f:c401 with SMTP id o9-20020a05660213c900b00684c06fc401mr1601224iov.10.1659963753679; Mon, 08 Aug 2022 06:02:33 -0700 (PDT) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com. [209.85.166.48]) by smtp.gmail.com with ESMTPSA id r12-20020a0566022b8c00b00672714b81e0sm5524189iov.26.2022.08.08.06.02.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 06:02:33 -0700 (PDT) Received: by mail-io1-f48.google.com with SMTP id o2so7006483iof.8 for ; Mon, 08 Aug 2022 06:02:33 -0700 (PDT) X-Received: by 2002:a05:6638:c53:b0:342:a7e7:6829 with SMTP id g19-20020a0566380c5300b00342a7e76829mr8054839jal.112.1659963753091; Mon, 08 Aug 2022 06:02:33 -0700 (PDT) MIME-Version: 1.0 References: <20220805022127.757324-1-wenwux.ma@intel.com> <38da7a720c298be79038c0a1de17477bbe177160.camel@debian.org> In-Reply-To: From: Luca Boccassi Date: Mon, 8 Aug 2022 14:02:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net/vhost: fix null pointer dereference To: "Ma, WenwuX" Cc: Maxime Coquelin , "Xia, Chenbo" , dpdk stable , "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 8 Aug 2022 at 02:01, Ma, WenwuX wrote: > > > > > -----Original Message----- > > From: Luca Boccassi > > Sent: 2022=E5=B9=B48=E6=9C=885=E6=97=A5 23:09 > > To: Ma, WenwuX > > Cc: Maxime Coquelin ; Xia, Chenbo > > ; dpdk stable ; Hu, Jiayu > > ; Wang, Yinan ; He, Xingguang > > > > Subject: Re: [PATCH] net/vhost: fix null pointer dereference > > > > On Fri, 2022-08-05 at 10:12 +0000, Ma, WenwuX wrote: > > > > > > > -----Original Message----- > > > > From: Luca Boccassi > > > > Sent: 2022=E5=B9=B48=E6=9C=885=E6=97=A5 18:04 > > > > To: Ma, WenwuX > > > > Cc: Maxime Coquelin ; Xia, Chenbo > > > > ; dpdk stable ; Hu, Jiayu > > > > ; Wang, Yinan ; He, > > > > Xingguang > > > > Subject: Re: [PATCH] net/vhost: fix null pointer dereference > > > > > > > > On Fri, 5 Aug 2022 at 03:22, Wenwu Ma wrote: > > > > > > > > > > Because the async member of the vhost_virtqueue struct can be > > > > > freed in controlpath, so it should be protected by spinlock in > > > > > datapath, or, it may cause null pointer dereference in the > > > > > following vhost_poll_enqueue_completed(). > > > > > > > > > > Fixes: b737fd613969 ("vhost: add unsafe async API to clear > > > > > packets") > > > > > > > > > > Signed-off-by: Wenwu Ma > > > > > --- > > > > > lib/vhost/virtio_net.c | 12 +++++++++--- > > > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > > > Hi, > > > > > > > > Is this for a stable branch? If so, which one? Please use > > > > --subject-prefix next time to clearly identify it. > > > > > > > Sorry, it is 21.11 > > > > Does this issue affect only 21.11? Or main as well? > > > Only 21.11 Thanks, applied and pushed. Kind regards, Luca Boccassi