Re: [PATCH stable-22.11] kni: fix build with Linux 6.8

[Luca Boccassi <bluca@debian.org>]

On Thu, 18 Apr 2024 at 11:25, Kevin Traynor <ktraynor@redhat.com> wrote:
>
> On 12/03/2024 11:20, Kevin Traynor wrote:
> > On 12/03/2024 10:40, Jiri Slaby wrote:
> >> On 12. 03. 24, 11:26, Kevin Traynor wrote:
> >>> On 12/03/2024 08:59, David Marchand wrote:
> >>>> Hello Jiri,
> >>>>
> >>>> On Tue, Mar 12, 2024 at 9:57 AM Jiri Slaby <jslaby@suse.cz> wrote:
> >>>>>
> >>>>> strlcpy() was removed in commit d26270061ae6 (string: Remove strlcpy()), use
> >>>>> strscpy() instead.
> >>>>>
> >>>>> The patches fixes this:
> >>>>> kernel/linux/kni/kni_net.c: In function ‘kni_get_drvinfo’:
> >>>>> kernel/linux/kni/kni_net.c:835:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’?
> >>>>>
> >>>>> Intended esp. for stable/22.11. It should go wherever kni is still in
> >>>>> the tree.
> >>>>
> >>>> Thanks for the patch.
> >>>>
> >>>> Cc: stable and LTS maintainers.
> >>>>
> >>>>>
> >>>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >>>>
> >>>>
> >>>
> >>> Thanks Jiri and David. I will take this for 21.11 LTS also.
> >>
> >> Just heads up: I've just realized, that strscpy() was introduces only in
> >>
> >> commit 30035e45753b708e7d47a98398500ca005e02b86
> >> Author: Chris Metcalf <cmetcalf@ezchip.com>
> >> Date:   Wed Apr 29 12:52:04 2015 -0400
> >>
> >>      string: provide strscpy()
> >>
> >> in v4.3. If you support older kernels, the patch needs modifications.
> >> Like some #if's depending on the kernel version or some HAVE_STRSCPY
> >> defines.
> >>
> >> thanks,
> >
> > ok, thanks for letting us know. We should be fine for supported kernels
> > from kernel.org but it will probably an issue for Centos7 with older
> > DPDK LTS, though it is EoL very shortly.
> >
>
> I don't see this on 22.11 branch. Considering that 22.11 is almost ready
> for release and Centos7 will EoL in June. It might be just easier to
> wait and apply for the next release. Otherwise the patch is going to
> need to be reworked and tested on Centos7.
>
> Luca, what do you think ?

Yeah sounds good