From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EE8543E9F for ; Thu, 18 Apr 2024 12:32:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7EC1402CC; Thu, 18 Apr 2024 12:32:35 +0200 (CEST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by mails.dpdk.org (Postfix) with ESMTP id 3881540042 for ; Thu, 18 Apr 2024 12:32:35 +0200 (CEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-6150670d372so5897157b3.1 for ; Thu, 18 Apr 2024 03:32:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713436354; x=1714041154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41RORV4+Kz+zbByNNC3k/h9UZMYxPAXVUscG4rHwzYI=; b=WR2UYznqWonwy1FF8q/tukn6MToP6CGh4JES5yIpX5Cnm+4cdP0XFHvT8HQNZeYP+G Tgd9bcAdi39zy+tr5aRADNSyncKIrBLOcVg0BC0AkDKD/cUwZwhdjunemSFbF12Ynvo4 dldUPoltoLoH+cdW7DZtgnZ/rut78zuaTlUDbvRdyvCxULmvSYqxs/9yybLRg2ISnabK D24W8QLi1CjGKso6ksljCNybVS10wxj7VehoEoscWy5Vaek6xh+0OkUnFHWxM1s/uDb/ 9qRb6f5qDg9ytjj9FO0Fm/gpH6VNGBAWnwIZKHroBGMe8glB6CHVSxj6PiA3ScpWbLHK FrLQ== X-Forwarded-Encrypted: i=1; AJvYcCWPNw7Kz/EM7q1J+m2aBZuzCZ6d8wMqhrIb9U8TskgLc87Ulg4RunPM6M0nTF0+zhcP/U+qPKlqkEfY4q1cbdU= X-Gm-Message-State: AOJu0Yz1Ugd69unh5Rc5zOGgF2u3CkOmNSmMgHNVbkq8/JJHeY1Z8K7b HW+j+sVFV3zyY4aou09wawJJ5BwpP25Hc4vVaj6tZmzIINtdwZ5X1xOn2g== X-Google-Smtp-Source: AGHT+IE2cNLgx6wQTEyBdkSprqKCpCXJAwIonT+7Oob1mzr0Z/93lUN6LEpw5MQ+LBO6zXlufqzLYA== X-Received: by 2002:a05:690c:6503:b0:61a:baf0:a0a5 with SMTP id hw3-20020a05690c650300b0061abaf0a0a5mr2397383ywb.34.1713436354335; Thu, 18 Apr 2024 03:32:34 -0700 (PDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id q39-20020a814327000000b00617f096f95asm280465ywa.16.2024.04.18.03.32.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 03:32:34 -0700 (PDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6150670d372so5897017b3.1 for ; Thu, 18 Apr 2024 03:32:33 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUyfhrhAeeELkAfBHFyYWQdb0TFRCcWG37M5vqGmUiHBS3LNY13dKh7rA3pI+tPfeFX1IFhK8LLdHl679+zuPQ= X-Received: by 2002:a05:690c:6802:b0:619:5176:5e34 with SMTP id id2-20020a05690c680200b0061951765e34mr2438556ywb.18.1713436353638; Thu, 18 Apr 2024 03:32:33 -0700 (PDT) MIME-Version: 1.0 References: <20240312084914.92056-1-jslaby@suse.cz> <1c0b8110-34d9-4a4e-b9c9-35b06c7f0da8@redhat.com> <75c0abee-01b4-4b81-a779-1fdf664fa8d2@redhat.com> In-Reply-To: <75c0abee-01b4-4b81-a779-1fdf664fa8d2@redhat.com> From: Luca Boccassi Date: Thu, 18 Apr 2024 11:32:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH stable-22.11] kni: fix build with Linux 6.8 To: Kevin Traynor Cc: Jiri Slaby , David Marchand , Ferruh Yigit , "Xueming(Steven) Li" , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 18 Apr 2024 at 11:25, Kevin Traynor wrote: > > On 12/03/2024 11:20, Kevin Traynor wrote: > > On 12/03/2024 10:40, Jiri Slaby wrote: > >> On 12. 03. 24, 11:26, Kevin Traynor wrote: > >>> On 12/03/2024 08:59, David Marchand wrote: > >>>> Hello Jiri, > >>>> > >>>> On Tue, Mar 12, 2024 at 9:57=E2=80=AFAM Jiri Slaby = wrote: > >>>>> > >>>>> strlcpy() was removed in commit d26270061ae6 (string: Remove strlcp= y()), use > >>>>> strscpy() instead. > >>>>> > >>>>> The patches fixes this: > >>>>> kernel/linux/kni/kni_net.c: In function =E2=80=98kni_get_drvinfo=E2= =80=99: > >>>>> kernel/linux/kni/kni_net.c:835:9: error: implicit declaration of fu= nction =E2=80=98strlcpy=E2=80=99; did you mean =E2=80=98strscpy=E2=80=99? > >>>>> > >>>>> Intended esp. for stable/22.11. It should go wherever kni is still = in > >>>>> the tree. > >>>> > >>>> Thanks for the patch. > >>>> > >>>> Cc: stable and LTS maintainers. > >>>> > >>>>> > >>>>> Signed-off-by: Jiri Slaby > >>>> > >>>> > >>> > >>> Thanks Jiri and David. I will take this for 21.11 LTS also. > >> > >> Just heads up: I've just realized, that strscpy() was introduces only = in > >> > >> commit 30035e45753b708e7d47a98398500ca005e02b86 > >> Author: Chris Metcalf > >> Date: Wed Apr 29 12:52:04 2015 -0400 > >> > >> string: provide strscpy() > >> > >> in v4.3. If you support older kernels, the patch needs modifications. > >> Like some #if's depending on the kernel version or some HAVE_STRSCPY > >> defines. > >> > >> thanks, > > > > ok, thanks for letting us know. We should be fine for supported kernels > > from kernel.org but it will probably an issue for Centos7 with older > > DPDK LTS, though it is EoL very shortly. > > > > I don't see this on 22.11 branch. Considering that 22.11 is almost ready > for release and Centos7 will EoL in June. It might be just easier to > wait and apply for the next release. Otherwise the patch is going to > need to be reworked and tested on Centos7. > > Luca, what do you think ? Yeah sounds good