From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AB5543DED for ; Wed, 3 Apr 2024 17:34:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8054B4025C; Wed, 3 Apr 2024 17:34:35 +0200 (CEST) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by mails.dpdk.org (Postfix) with ESMTP id 688E740144 for ; Wed, 3 Apr 2024 17:34:34 +0200 (CEST) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6153e169066so17286007b3.3 for ; Wed, 03 Apr 2024 08:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712158473; x=1712763273; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6qLUpdTS/vXHeKnmEHwxdSBlING+gv1dxcOP4MYDaV8=; b=ADGmhawdb4WALJPWwc6Bw3XD92GkhrXW0w6o+b5K8ZBxu8cYkeKQeNe63TUYg/1fbZ e6BT3CqRev73BFloQ19Q84+WnTvAApcLwuOdQAMdriYaz06irLF+5xATwBgM5NEKM1eD 6kUSCC8mAAOK8ozoaeIEd9mc0wcelNN96TpzvfYf7EjlOUoBeYRCKTcX2PFLijB+qlGZ kNomplSEuQafQT5+LHBznmMe6PxFlSFUIoq9g4dP2WBYdUCARP3El1eqbUpEYTGTp+Sy 2sM71WYFXS48pYbY36y1lQP1LDdQ8tQhp5wZgnMKwRAkKkl4YG+Goayo+FGbBAQLzY46 XwQg== X-Gm-Message-State: AOJu0YyqT8ix+Yv5yD7uyywUDvmkn1zLjxnsL5PTWyh61Ww9jn21Ig0O iPdaY/KGt0YZFtwAHTScmUKhNcPUtHh+yy6yWEOYYsFJxkkG2D85D2ihJe3P2SA= X-Google-Smtp-Source: AGHT+IFSqmdCtYd95nAGaVCuRbkBG3PHdB0vrcDxu6afBFsKMTorrGf5ndmK2YLs7fxtbe3xadecJQ== X-Received: by 2002:a0d:cc56:0:b0:615:3858:d14c with SMTP id o83-20020a0dcc56000000b006153858d14cmr4686923ywd.28.1712158473561; Wed, 03 Apr 2024 08:34:33 -0700 (PDT) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id x5-20020a81d205000000b006119dd505b0sm3381295ywi.112.2024.04.03.08.34.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 08:34:33 -0700 (PDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-6152088aa81so22289677b3.0 for ; Wed, 03 Apr 2024 08:34:33 -0700 (PDT) X-Received: by 2002:a0d:d98a:0:b0:615:39a9:5b3 with SMTP id b132-20020a0dd98a000000b0061539a905b3mr4727806ywe.7.1712158473145; Wed, 03 Apr 2024 08:34:33 -0700 (PDT) MIME-Version: 1.0 References: <20240403083805.23622-1-dsosnowski@nvidia.com> <40040364d17a265bd46679864c990c87ff654122.camel@debian.org> In-Reply-To: From: Luca Boccassi Date: Wed, 3 Apr 2024 16:34:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 22.11] net/mlx5: fix async flow create error handling To: Dariusz Sosnowski Cc: "stable@dpdk.org" , Ori Kam , Matan Azrad , Slava Ovsiienko , Suanming Mou Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 3 Apr 2024 at 14:50, Dariusz Sosnowski wrote: > > > -----Original Message----- > > From: Luca Boccassi > > Sent: Wednesday, April 3, 2024 13:16 > > To: Dariusz Sosnowski ; Matan Azrad > > ; Slava Ovsiienko ; Suanming > > Mou > > Cc: stable@dpdk.org; Ori Kam > > Subject: Re: [PATCH 22.11] net/mlx5: fix async flow create error handling > > > > External email: Use caution opening links or attachments > > > > > > On Wed, 2024-04-03 at 10:38 +0200, Dariusz Sosnowski wrote: > > > [ upstream commit 5ecc8df4fad3411a53c20406f99b59dc736a6d1e ] > > > > > > Whenever processing of asynchronous flow rule create operation failed, > > > but after some dynamic flow actions had already been allocated, these > > > actions were not freed during error handling flow. > > > That behavior lead to leaks e.g., RSS/QUEUE action objects were leaked > > > which triggered assertions during device cleanup. > > > > > > This patch adds flow rule cleanup handling in case of an error during > > > async flow rule creation. > > > > > > Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Dariusz Sosnowski > > > Acked-by: Ori Kam > > > > > > > This patch does not apply on stable/22.11, how was it tested? > > The backports were tested today by applying on 22.11 branch on git@github.com:bluca/dpdk-stable.git > > Could you please try applying mlx5 patches sent by me in the following order? > > 1. "net/mlx5: fix flow configure validation" > 2. "net/mlx5: fix rollback on failed flow configure" > 3. "net/mlx5: fix async flow create error handling" > > There might be some conflicts between these patches, maybe that's the reason for failure. I'm sorry about not mentioning this. > I retested applying them on commit efe1d783f474, in that order and it applied correctly on my side. Thanks, that works, my email client showed me the 3rd one as the first mail, so when downloading the mbox with all 3 it failed. Next time please use a series so that you know the order you meant is the one we see too.