From: Luca Boccassi <luca.boccassi@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: stable@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
"Wathsala Vithanage" <wathsala.vithanage@arm.com>
Subject: Re: [PATCH 22.11] common/idpf: fix use after free in mailbox init
Date: Fri, 25 Oct 2024 16:50:20 +0100 [thread overview]
Message-ID: <CAMw=ZnSHEm495O_opkVfUWujr07Czh2b5z4zPTbc6QTOpWaexw@mail.gmail.com> (raw)
In-Reply-To: <20241025001435.284362-1-stephen@networkplumber.org>
On Fri, 25 Oct 2024 at 01:14, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> [ upstream commit 4baf54ed9dc87b89ea2150578c51120bc0157bb0 ]
>
> The macro in this driver was redefining LIST_FOR_EACH_ENTRY_SAFE
> as a simple LIST_FOR_EACH macro.
> But they are not the same the _SAFE variant guarantees that
> there will not be use after free.
>
> Fixes: fb4ac04e9bfa ("common/idpf: introduce common library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Acked-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> ---
> drivers/common/idpf/base/idpf_osdep.h | 10 ++++++++--
> drivers/net/idpf/idpf_ethdev.c | 3 +--
> 2 files changed, 9 insertions(+), 4 deletions(-)
Thanks, applied
prev parent reply other threads:[~2024-10-25 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 0:14 Stephen Hemminger
2024-10-25 15:50 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMw=ZnSHEm495O_opkVfUWujr07Czh2b5z4zPTbc6QTOpWaexw@mail.gmail.com' \
--to=luca.boccassi@gmail.com \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).