From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3991345BC3 for ; Fri, 25 Oct 2024 17:50:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 313F94021F; Fri, 25 Oct 2024 17:50:33 +0200 (CEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by mails.dpdk.org (Postfix) with ESMTP id 7ACA44021F for ; Fri, 25 Oct 2024 17:50:31 +0200 (CEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-6e35bf59cf6so32875277b3.0 for ; Fri, 25 Oct 2024 08:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729871431; x=1730476231; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aA5FE6S4gmjMxwC8M6qVYb8GfAm6vdO8SD4HMPuWpko=; b=iiYpXPE/WYTHG7ocGFQ0vbDiPKB/mwuQM4DT1DNPobiKW1hSi4UxjHBKUczC6BtNoz zEOQEARA4TCd1W0fewMymeBBZy7Dq592ORFt64owgedOzfl+obUz/yd8LGeA4kovHHEs DiXcO6h/Ea8nzE9LTk9t9+UMAhjZ6lS99/4qByTOgBakFAPTSruP7UdYGCVZmYtgA/w6 sCWlli8T2eT2GibL04wwEU7J5IU/uPdOXDvlhZ5qwFUVrprdCHKjokB83LCCXaY+zbCI gSLl3hcqW0RB2HDN+8dw1cdAoWIPvCmEc+5PMh92TXHKHEHRbW+RCBkVqbNnyE5AGqhc D6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729871431; x=1730476231; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aA5FE6S4gmjMxwC8M6qVYb8GfAm6vdO8SD4HMPuWpko=; b=Uj9GLxGqhIPIsE54P04XlDdLFpozSb2FPQg6OHnsKpIyY8EiMv0saEYQnKJV3apboT sDT5teSKmjaURz7sOyXMK3kWhdehzpTamMCIy+zVIMkr2seeyzxDVqZuLC1oc1qW+oc/ jFBy/iX2CmcgtmVGv6hXun9nypzF10yZOMIzJztgaXxyzfaeL5z3CG62+gLeLEvB7DCm SJ4+fheyn+RYf0Fq5t2QcrzQ2GTGyqbzT62Xq6XMVNFw6rnZEkzpDVAMx8EA4tsRHY1i rUcMimvKApcVgNZc8CRQQ4E+YCdLp0fggbRCD0FfBT7dNgBK1BVtilrfitBh1ah47WU9 Tpvw== X-Gm-Message-State: AOJu0YygaqLf2ePMRR3xVR69Z6lJH8IiQO+o2abnqXmwYoSlDxVRgi7N zwa6wirJcVj2AF5WMluoRTqZIzE/Xtlxn6r0au16/rjLgU628ozv01d7eHXQNP/lLeX7VdD+A2z 9V5rybPGv1cMeHiwQ8ifB3WYlgSA= X-Google-Smtp-Source: AGHT+IHNzfi8jlpgfA5ohTg6yfcXa/2MU0uogulxVaj4W/DCXm+k1KcWEUZllqBeNiH1v1q/UkjY+pACuLenU76F5vo= X-Received: by 2002:a05:690c:dc7:b0:6db:cea9:6ed9 with SMTP id 00721157ae682-6e9d88c23ddmr101007b3.4.1729871430759; Fri, 25 Oct 2024 08:50:30 -0700 (PDT) MIME-Version: 1.0 References: <20241025001435.284362-1-stephen@networkplumber.org> In-Reply-To: <20241025001435.284362-1-stephen@networkplumber.org> From: Luca Boccassi Date: Fri, 25 Oct 2024 16:50:20 +0100 Message-ID: Subject: Re: [PATCH 22.11] common/idpf: fix use after free in mailbox init To: Stephen Hemminger Cc: stable@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 25 Oct 2024 at 01:14, Stephen Hemminger wrote: > > [ upstream commit 4baf54ed9dc87b89ea2150578c51120bc0157bb0 ] > > The macro in this driver was redefining LIST_FOR_EACH_ENTRY_SAFE > as a simple LIST_FOR_EACH macro. > But they are not the same the _SAFE variant guarantees that > there will not be use after free. > > Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Br=C3=B8rup > Acked-by: Konstantin Ananyev > Acked-by: Wathsala Vithanage > --- > drivers/common/idpf/base/idpf_osdep.h | 10 ++++++++-- > drivers/net/idpf/idpf_ethdev.c | 3 +-- > 2 files changed, 9 insertions(+), 4 deletions(-) Thanks, applied