From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8BB543E06 for ; Fri, 5 Apr 2024 16:44:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AAAB402CE; Fri, 5 Apr 2024 16:44:03 +0200 (CEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by mails.dpdk.org (Postfix) with ESMTP id 519D44029C for ; Fri, 5 Apr 2024 16:44:01 +0200 (CEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-61495e769bdso21262927b3.0 for ; Fri, 05 Apr 2024 07:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712328240; x=1712933040; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=O5NQlLTumJKS1UKN17Oh13yM0zN2RwSClbKJiTzMlMo=; b=b0e0Wy4z0v4bQ/pGraMbfgh5TDxZB10sjMtAqDQ74yrNxTUSduMyyU4YnJ5j5ot/pK FTVYGiLF9bZxRzwDofSOF7+UbXG3nte7NA9COA10ODPrcCGlu6rpRRz6u1BHAO0xcP7V YaHdr6apdRG7kjmSvbfqLiyeOcWt7B29q9hvR7D3l78Xq4Dbp209YAwuN8k+dynr6aV/ I3bQbmmMpqlHg6m/yxTEiucdGTleCP/Batba03gxcRXs/1Wgl8HECBryMsEHBeOFviny D4c/fE0sqqJNEdcbbHt83QnaOjLM+hk5HdemwsaRYcbphZoCZsRdcvD1UPJPkIQS9EfM TZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712328240; x=1712933040; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O5NQlLTumJKS1UKN17Oh13yM0zN2RwSClbKJiTzMlMo=; b=mDbOOoReV53rQhRGVpX9b7eOz6DU8ALNl6WGXpdeAgory0fmbk3AwCE3sjp7x0L5st xFOAv9NgZMXUVozb3SvQJlNov+AKuNlPV82PDbATlA8+S5hmuTxxE7YzdFVp5KhBBzc8 zlQ/3OMonk0ecVEDOkBqGZJZgyxgdX5VWk4PjfUhXVmEDU7K0+ptIP4OZCIHPNSHqhmx fB4UrVy1av3v+MpiF90fSH/n+Plc/3xbD6JSNK5cv/ZhiqkMZ2GMC5OAQZT0Yo1eRDiW jhf3EV6PP8zAKJ0e9D6rEi0kxX0J7nUkCayFIRPNhR1wm+Yko8aUfioZT02MIA277fe/ 0b3A== X-Gm-Message-State: AOJu0YyDHkp3GntLk4NY4OQFL0vg42oiiSBbr0T5jyh5Xe4764OZ17oI GMnlfC/bMwSE9vTkh2IPGyZqLuyJPso99WIZKB54xdfNXI900RXtejLx8CZl1QrhMyVBRe6NjMP vw6UOvjg4XlqMqV4Joq8r0dWVikE= X-Google-Smtp-Source: AGHT+IHv16pc8QyWrkjIfJsjJBBVSMd62iTUQDRLj5qLLJgQn1y1B7yAOgXKmLVXFNeEHFH7pwtNEh+gFZJozA7cxw8= X-Received: by 2002:a0d:d60f:0:b0:615:4653:1c11 with SMTP id y15-20020a0dd60f000000b0061546531c11mr1722338ywd.12.1712328240629; Fri, 05 Apr 2024 07:44:00 -0700 (PDT) MIME-Version: 1.0 References: <20240405103803.2785764-1-ciara.power@intel.com> In-Reply-To: <20240405103803.2785764-1-ciara.power@intel.com> From: Luca Boccassi Date: Fri, 5 Apr 2024 15:43:49 +0100 Message-ID: Subject: Re: [PATCH 22.11] crypto/ipsec_mb: fix incorrectly setting cipher keys To: Ciara Power Cc: stable@dpdk.org, pablo.de.lara.guarch@intel.com, Kai Ji Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 5 Apr 2024 at 11:46, Ciara Power wrote: > > The encryption and decryption keys were incorrectly being reset based on > authentication algorithm after already being set earlier in the code > based on cipher algorithm. > In cases when 3DES was used, the keys were being > incorrectly overwritten. > > For CPU path, there is no need to have the keys set for XCBC and CMAC > cases. > > Fixes: 010230a1543b ("crypto/aesni_mb: support Chacha20-Poly1305") > Fixes: b0a37e8cd2ac ("crypto/ipsec_mb: fix cipher key setting") > Fixes: a2c6d3f34f90 ("crypto/aesni_mb: support CPU crypto") > > Signed-off-by: Ciara Power > --- > Cc: pablo.de.lara.guarch@intel.com > --- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 14 -------------- > 1 file changed, 14 deletions(-) I have already tagged rc1 - is this fixing a regression introduced in rc1 itself? If not, how important is it, could it wait for the next release?