From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C399A00C3 for ; Tue, 20 Sep 2022 13:11:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43C0E41148; Tue, 20 Sep 2022 13:11:07 +0200 (CEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id E63DC4069B for ; Tue, 20 Sep 2022 13:11:05 +0200 (CEST) Received: by mail-lf1-f44.google.com with SMTP id z25so3204470lfr.2 for ; Tue, 20 Sep 2022 04:11:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=3czegrBfLjA+f6yGzxKo629efLqlV3U6MLUcxeBfodQ=; b=NmJyPqcCj4BMsQQM3EKF/WNdlrqBR1Svo3imeNz7WQavwFM1IHFtKyeSbIKxStETrT qaOidt7AiFo0B1mGxjVwOXKERZwJbZNVNoiStVN6eTWG360Cv6cH6HAQTBzEW9ubkRj0 3HV+jJpUkT962mqWEfrQTmssKCA7J7S2qtRgCrFAbAPkeZWsaOejefMMtNZR861CfIaO 33NTAHVR2070TSxjuedsVNeDKi6LhtME+Q0eS61M2OZtOct7JRbWCLJz6lEGlWgOoEjt LHKblb6702ihC5vRfxBweAWz9+8iZe/fBzpQzHKgVabFxZAreeg0mWwih/68zxq86Z5P 6sbw== X-Gm-Message-State: ACrzQf2Gq/VvsjvZ3wKxjVCtYKl+S3eYSHaVP6zRmeThU6f89iMa9NOF +jOXKmno+7xbQfNcKq2UXpljFbLFiE2+mw== X-Google-Smtp-Source: AMsMyM4Swi+IHu/xcoLrwxbp8REM5Rk4MBqqGQ/fbC80NHFJfZcMA3ts0/5L8S5K5y3skabpXjrlgw== X-Received: by 2002:a05:6512:3b0a:b0:49a:7ce8:c450 with SMTP id f10-20020a0565123b0a00b0049a7ce8c450mr8745595lfv.231.1663672265029; Tue, 20 Sep 2022 04:11:05 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id g20-20020a2ea4b4000000b00261eb899361sm218291ljm.23.2022.09.20.04.11.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 04:11:03 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id u18so3157505lfo.8 for ; Tue, 20 Sep 2022 04:11:02 -0700 (PDT) X-Received: by 2002:a05:6512:3981:b0:49a:d169:5808 with SMTP id j1-20020a056512398100b0049ad1695808mr7335561lfu.241.1663672262257; Tue, 20 Sep 2022 04:11:02 -0700 (PDT) MIME-Version: 1.0 References: <7671019d-fff8-5e7f-1d92-f53d8ffc8032@redhat.com> In-Reply-To: <7671019d-fff8-5e7f-1d92-f53d8ffc8032@redhat.com> From: Luca Boccassi Date: Tue, 20 Sep 2022 12:10:50 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Early backport of Vhost regression fix in LTS branches To: Kevin Traynor Cc: Maxime Coquelin , "stable@dpdk.org" , Christian Ehrhardt , Xueming Li , Michael Phelan Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 20 Sept 2022 at 12:03, Kevin Traynor wrote: > > On 20/09/2022 10:36, Maxime Coquelin wrote: > > Hi LTS maintainers, > > > > We have discovered a regression causing deadlock in application using > > the Vhost library (when vIOMMU is used & NUMA reallocation happens). > > > > The faulty commit [0] got backported in all maintained LTS branches, > > following minor releases are impacted: > > - V21.11.1+ > > - V20.11.5+ > > - V19.11.12+ > > > > The fix for this regression is already in main branch, and will be part > > of next v22.11 release. > > > > Discussing with Kevin, he suggested the fix to be backported early to > > all the LTS branches. > > > > This issue is a deadlock likely to occur with an application such as > OVS, that uses vIOMMU vhost ports and a multi-NUMA system. > > In normal circumstances, for example with OVS, we could just recommend > users not to upgrade to the latest DPDK LTS releases until the issue is > fixed. Where this one gets tricky is that the latest LTS releases > contains CVE fixes. > > At the moment if a user wants the CVE fixes *and* the below deadlock > fix, they will have to pick patches themselves. It might help some if > the DPDK stable branches (which are still at last release point) > backport the fix below early so a user can just pull the branch. > > > Below is the fix to be backported: > > > > ====================================================================== > > commit 0b2a2ca35037d6a5168f0832c11d9858b8ae946a > > Author: David Marchand > > Date: Mon Jul 25 22:32:03 2022 +0200 > > > > vhost: fix virtqueue use after free on NUMA reallocation > > > > translate_ring_addresses (via numa_realloc) may change a virtio > > device and > > virtio queue. > > The virtqueue object must be refreshed before accessing the lock. > > > > Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Reviewed-by: Maxime Coquelin > > ====================================================================== > > > > The fix can be backported without conflicts to all the LTS branches, > > except for v19.11, for which the Vhost directory rename can cause > > issues. It can be overcome using below command: > > > > git cherry-pick -Xfind-renames=5% 0b2a2ca350 > > > > Is that OK for you? > > > > I can take care of it for all branches if other maintainers are busy and > ok with that. Sounds good to me, feel free to go ahead for 20.11, thank you. Kind regards, Luca Boccassi