From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8917848936 for ; Tue, 14 Oct 2025 17:18:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61890402A8; Tue, 14 Oct 2025 17:18:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F1344402A8 for ; Tue, 14 Oct 2025 17:18:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760455117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z1sAPFZTu2nJZrkiU9POOLPcluNYyhKSyeGQ7vjUM9c=; b=JGMMTuw/RSFZy4irXxYTU+NllygZA8HaY2JkGtBnX0fYDj1AyTtCwFKh26C2HdtezLo5Wr fVln3AWV67nwSqpaDPL9xUiDlY38qGGxm2LKRW7Ntlovzh24q/U7hXuePg0EyneQ6q+Fll FlN83Il4SdNqAljfGB3Gy3YDPyJOWD8= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-5In9fkDZPCuB6Opa1mg3NA-1; Tue, 14 Oct 2025 11:18:33 -0400 X-MC-Unique: 5In9fkDZPCuB6Opa1mg3NA-1 X-Mimecast-MFC-AGG-ID: 5In9fkDZPCuB6Opa1mg3NA_1760455112 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-59095ccc90eso1924541e87.1 for ; Tue, 14 Oct 2025 08:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760455111; x=1761059911; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z1sAPFZTu2nJZrkiU9POOLPcluNYyhKSyeGQ7vjUM9c=; b=Rr3e5ud6O7oFAY0hVJicBlN43DqWDLjMGnZGXr997RLmAhhHtm680+9omlr4YsNOxA Z7vKkVqwaALammWxyGYe6ySfvpJ/t8C8M+dWrQBq/lj/CpDTYaH+MgjpBbHRJYAC8UBG bjVFhMCM7kXdr3RuKTdgr+BgVBTizqYGSYoPyXoRCAhi659jbMNok5G0XCUY5SRTjolx V8k1apJ0e2ItvAu3kuWYoTdRIs1qfZUx8Q3jELMTMlT8vn1zl3umnrBP1H8XIPp4pEai e0oT1PcdZF7QL5yhK4xDSz+AZLxs4KAI6AWTXR8LqKLKcyILLwZwM22OXdRqmtMghF6q dg9w== X-Forwarded-Encrypted: i=1; AJvYcCVQuE3c0rAn1uRrHzUU9b2VNksw1vPBZn8q1e9K08zCsWXcChwunjsUQtDgX/aYAVmiPMtfBpY=@dpdk.org X-Gm-Message-State: AOJu0YxkNPi83cmV93QDLEKy3rzarXXRbU22C88ezgGUcQ8Ryw9SXRUn R88mUmuEbN5NkXtCONLnwffPZZ0sP9k38zH/mwnkQc4CLdOuMdMKO5nn2PdsOP+/c9Pk3f1FBlx nYVnpwcCqMEmDtBNa//x6qlUW3TPiDLLc6/Oyt5z1cQj0LU16CQQ/5v2v2grcI1gew/Ourzc4h4 VrzKC2Q9nkrWT1+oecDpyXO0s= X-Gm-Gg: ASbGncvOikGgx/fsoCxoqXH6oVUooigjXBrMSAOCVrrD2Rgsy6EvQiF/5B14pLBm83L HY3uj414Pq30XE+QBzKWkbl7+6C52YzBF3xqy+0a22hcQwluYFcHtDExNbmslZqb2bSQVikt7yY UKqM1g50YkmRQa0G9c55I= X-Received: by 2002:a05:6512:3044:b0:591:c542:3841 with SMTP id 2adb3069b0e04-591c5423a24mr482570e87.2.1760455111461; Tue, 14 Oct 2025 08:18:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLoAVDbucUMFXkicnd3gHJi4H+zLUgzhghAkWMzNkyHDk0LLyAhDOVH2NK9OaSGd3izM76LSKrwxvwNutblCQ= X-Received: by 2002:a05:6512:3044:b0:591:c542:3841 with SMTP id 2adb3069b0e04-591c5423a24mr482556e87.2.1760455110947; Tue, 14 Oct 2025 08:18:30 -0700 (PDT) MIME-Version: 1.0 References: <09058cfb25d7583f67d74f09cd36673f1b10f5ec.1734661755.git.wangyunjian@huawei.com> <1760085696-35028-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1760085696-35028-1-git-send-email-wangyunjian@huawei.com> From: Maxime Coquelin Date: Tue, 14 Oct 2025 17:18:19 +0200 X-Gm-Features: AS18NWD22QTB86BZPLe4IIVQvBxTuiCIW-rR3tpPTEo4TdeQC1UlQ97cv3slAXI Message-ID: Subject: Re: [PATCH v3] vhost: fix a double fetch when dequeue offloading To: Yunjian Wang Cc: dev@dpdk.org, maxime.coquelin@redhat.com, jerry.lilijun@huawei.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WElZVPnFdRiE_eYQ6GyegQIOTt38xTHZ0b4AUEZtrdc_1760455112 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Yunijan, On Fri, Oct 10, 2025 at 10:41=E2=80=AFAM Yunjian Wang wrote: > > The hdr->csum_start does two successive reads from user space to read a > variable length data structure. The result overflow if the data structure > changes between the two reads. > > To fix this, we can prevent double fetch issue by copying virtio_hdr to > the temporary variable. > > Fixes: 4dc4e33ffa10 ("net/virtio: fix Rx checksum calculation") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- > v3: update code styles suggested by Stephen Hemminger > --- > lib/vhost/virtio_net.c | 50 ++++++++++++++++++++++-------------------- > 1 file changed, 26 insertions(+), 24 deletions(-) > Thanks for spotting this. The patch looks good to me: Reviewed-by: Maxime Coquelin Maxime