From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F2DDA04B5 for ; Thu, 29 Oct 2020 11:45:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78423C9DE; Thu, 29 Oct 2020 11:45:08 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id A9137C9DA for ; Thu, 29 Oct 2020 11:45:05 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id r10so1108118plx.3 for ; Thu, 29 Oct 2020 03:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wmwgGhyrwUp5L0Lo9xvh0anDtoJ2h5AAZ+En3J+keZk=; b=aI0nTBv68OrcR1dT+glz59hesCpQ3hzQOumJFUdMgMtTWkE23++2Enhvjj01Owv5G+ MAF8GVEK9Xld7mDdcoqG7pdZo1Z7wC4IcyVDbzJGReFHpEnvNQp0uvjlRDmGAD1FgNoc RtU/bgfvHgphlzNBq0yWoDegZywJQnGaYoKFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wmwgGhyrwUp5L0Lo9xvh0anDtoJ2h5AAZ+En3J+keZk=; b=a9+YCP0hAmCFgHwLYXtH3hCiNA4YR655Fij3LABNYBkb/b0SXUGbu1+Jr1emRwYyoP LcbhI64mMkH8LGoMKZfBuS/7G9XMtvUYqFYb+yASQ7GDmr7HmhOloqCW8OERt5r+5Dur +2VGHuXE3sY5BDHJymH8uHOf+UxexoSlVh/xGdAuPVjpyJ0mQyWnfD1nBERyTeh/MITt hgtkDq5aZFo5MUs3m8K0Ir/XjmwKhu0PmWgWw15U08jJ3rtoP5gsxsMjkInekTmh1Gyp pl9ZeXQSxtlcCTBScNa86QvsU5Kj2g9KIQz+TYUEggPaY1W/aJMwvD4PNq6sg5TuruYi m8Yg== X-Gm-Message-State: AOAM5333xRWZCu4OZz9nYIUDYZQ+XFv+urHkrVblo/r39FUUKuoYpbO9 uvUPWQlfTDZ1AOKTCfHmx2ikeP2fFMZMN5+zZBLqOA== X-Google-Smtp-Source: ABdhPJxwaIt2S4EoglB9TsvBcgU4QVLpn3GbPqmFU6mF26MUHFAbxj2ve0mAo3HOVJh6wLzVWvJhgENRTSnGUNbLiUs= X-Received: by 2002:a17:902:b492:b029:d4:d88c:d1a7 with SMTP id y18-20020a170902b492b02900d4d88cd1a7mr3420766plr.15.1603968303733; Thu, 29 Oct 2020 03:45:03 -0700 (PDT) MIME-Version: 1.0 References: <20201029084419.9783-1-somnath.kotur@broadcom.com> <97365917b7997e22444eefdfb3e9f1e45f543c7a.camel@debian.org> In-Reply-To: <97365917b7997e22444eefdfb3e9f1e45f543c7a.camel@debian.org> From: Somnath Kotur Date: Thu, 29 Oct 2020 16:14:52 +0530 Message-ID: To: Luca Boccassi Cc: dpdk stable , Ajit Khaparde Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [19.11 1/2] net/bnxt: fix checking VNIC in shutdown path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Oh ok... Apologies then Luca..We went by the final diff you had between the upstream commit patch and the actual patch... perhaps that confused us or threw us ( speaking for kalesh's 2 patches as well) off a bit ... If they( all 4) are identical to what you already have on your sandbox, then indeed we are good to go Thanks a lot Som On Thu, 29 Oct 2020, 16:06 Luca Boccassi, wrote: > On Thu, 2020-10-29 at 14:14 +0530, Somnath Kotur wrote: > > [ backported from upstream commit > 4b029f02de3a0ce9cdd9a3475b84ca2e42d74281 ] > > > > Add a couple of NULL pointer checks in bnxt_free_all_filters() > > and bnxt_free_vnics() respectively to guard against certain error > > injection/recovery scenarios where it was found that the application > > was crashing with the bp->vnic_info pointer being NULL. > > > > Fixes: 51fafb89a9a0 ("net/bnxt: get rid of ff pools and use VNIC info > array") > > Cc: stable@dpdk.org > > > > Signed-off-by: Somnath Kotur > > Reviewed-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_filter.c | 15 +++++++++------ > > drivers/net/bnxt/bnxt_vnic.c | 3 +++ > > 2 files changed, 12 insertions(+), 6 deletions(-) > > Hi, > > Both of these patches appear to be 100% identical to the ones I pushed > yesterday? Was there something unclear in the generated email that made > you think the rebase was different that we can fix? > > > https://github.com/bluca/dpdk-stable/commit/77abebfe906e80404ecdfa71c60da318cd0fb563 > > https://github.com/bluca/dpdk-stable/commit/618bfe2417717a3b446180a10d1a2299d3f626e9 > > -- > Kind regards, > Luca Boccassi >