From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7873CA046B for ; Tue, 25 Jun 2019 05:41:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 235581BC01; Tue, 25 Jun 2019 05:41:31 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 09E7B1BC01 for ; Tue, 25 Jun 2019 05:41:28 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id r7so8707180pfl.3 for ; Mon, 24 Jun 2019 20:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NOMjCg3OkZ/9sQX9bWaCQ9MjYUdGYCrdFwh0y1oe65c=; b=fZF/J61KZVPWCV5Q5OL9RO0RmxNO56/4MA4OIywgv5fH0iDxW4fk3ZBtEH9Fv2lPJ4 HZI0i3pip7NOD9QxUlxWKluZB05EFmqPJfZJCoM/FJNktSlOfJcCaURWy3fsgs8k2jSF p1SLm110X38E6VVOCfNYJr1ruN3i4H+uuZz9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NOMjCg3OkZ/9sQX9bWaCQ9MjYUdGYCrdFwh0y1oe65c=; b=DrJK5ad8bQHZOvDPXDxjGgg93zccAt27rycF/UNBpZrUqHIkLHkBiYNTPiAhKkau2w afV1v9GXmkpMLUib5TQUxsaUNdIVlzE2KJSqGuH7+ncTDLwE/L5THUuNjPlRYpuHv/B7 pocY7zQpK3NVnf3najBy7rBY4VIY0R9dq1O6mQ7peB9TE2xL2GKEKbke45kpO+bGU+I9 l9nwWTcNH+6QaNCglUc+Kknoq4u+oti2vbzeWSj+RBEv7mzJLHNNAy0v1J5JaZ6m86xT ZXfpDDhZe+37W0VQ7UrEJRQb0VqWZcaeKKg0dGy4lRRGjh8TWvpBXO7+4/R+ghFuQoBT ODOw== X-Gm-Message-State: APjAAAU3llqAXHS06D5ieJ4ZFGULgrg+px1brjZwMTQ2fGaHzmaJ4seI VQ/ADKGvr3vLXXu4mB2q0FgRCyX/8n9LKXMMycXAWw== X-Google-Smtp-Source: APXvYqy5aKKps+LFMAxvI9/lR3gSbWyOeEDzRvS1iRi0Dy85VX97xmqbHtGh4feUhvjych5/VCOTp2RJZlW6OVoz96o= X-Received: by 2002:a65:50cb:: with SMTP id s11mr36283156pgp.371.1561434087898; Mon, 24 Jun 2019 20:41:27 -0700 (PDT) MIME-Version: 1.0 References: <20190624152525.19349-1-ktraynor@redhat.com> <20190624152525.19349-37-ktraynor@redhat.com> In-Reply-To: <20190624152525.19349-37-ktraynor@redhat.com> From: Somnath Kotur Date: Tue, 25 Jun 2019 09:12:00 +0530 Message-ID: To: Kevin Traynor Cc: Kalesh AP , Ajit Khaparde , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] patch 'net/bnxt: check for null completion ring doorbell' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jun 24, 2019 at 8:56 PM Kevin Traynor wrote: > > Hi, > > FYI, your patch has been queued to LTS release 18.11.3 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 06/27/19. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable-queue > > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk-stable-queue/commit/0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 > > Thanks. > > Kevin Traynor > Thanks Kevin! ACK-ed the rebase Regards Som > --- > From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001 > From: Somnath Kotur > Date: Sat, 8 Jun 2019 23:22:04 +0400 > Subject: [PATCH] net/bnxt: check for null completion ring doorbell > > [ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ] > > It is observed that sometimes during init, the bnxt_int_handler() gets > invoked while the cpr->cp_db.doorbell is not yet initialized. Check for > the same and return. > > Fixes: f7ecea911ec5 ("net/bnxt: fix interrupt handler") > > Signed-off-by: Somnath Kotur > Signed-off-by: Kalesh AP > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c > index e03766b41..e3aac7cbe 100644 > --- a/drivers/net/bnxt/bnxt_irq.c > +++ b/drivers/net/bnxt/bnxt_irq.c > @@ -32,5 +32,5 @@ static void bnxt_int_handler(void *param) > raw_cons = cpr->cp_raw_cons; > while (1) { > - if (!cpr || !cpr->cp_ring_struct) > + if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell) > return; > > -- > 2.20.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if non-empty: > --- > --- - 2019-06-24 16:18:56.998750420 +0100 > +++ 0037-net-bnxt-check-for-null-completion-ring-doorbell.patch 2019-06-24 16:18:55.067430374 +0100 > @@ -1 +1 @@ > -From 2807c5861e31b99295b915b28e121ce059a46416 Mon Sep 17 00:00:00 2001 > +From 0e449f4f13ad7d9c8ff1c241a51b5d41cd03d245 Mon Sep 17 00:00:00 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 2807c5861e31b99295b915b28e121ce059a46416 ] > + > @@ -11 +12,0 @@ > -Cc: stable@dpdk.org > @@ -21 +22 @@ > -index 918f3dcf4..0bb3eb4fa 100644 > +index e03766b41..e3aac7cbe 100644 > @@ -28 +29 @@ > -+ if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.doorbell) > ++ if (!cpr || !cpr->cp_ring_struct || !cpr->cp_doorbell)