From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08CB4468C4 for ; Tue, 10 Jun 2025 11:23:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 039D642E5D; Tue, 10 Jun 2025 11:23:05 +0200 (CEST) Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) by mails.dpdk.org (Postfix) with ESMTP id 335AD42E5D for ; Tue, 10 Jun 2025 11:23:02 +0200 (CEST) X-QQ-mid: esmtpgz12t1749547380tac23a170 X-QQ-Originating-IP: 0Zw7dHfE4mnI27/bfzHFaGDy34d8eAuqNq/NHftpNsk= Received: from w-MS-7E16.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:23:00 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 8513228214280807717 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 09/12] net/ngbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:22:34 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250610092237.232224-1-jiawenwu@trustnetic.com> References: <20250610092237.232224-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: Nh1//VF/JH+hcIfl+qOitQc/OJfnULW+doXqP6BTPLoSntmUq1Jg709V K3y5RqOSYulO/25bBiX+3j2VtTW32nni0Iqc1cMAmTVx34eh6DvrRNY5EwEWihWy2GPHBed AwmruDeuaBJmqRXHGjvA6jUhz0wXMa5H7UJ3VRExC+PaFQ6cKb0muV+dUzt7mFOjgIxpGDL KV4dJcRiz/hG9XMTpGRcFV4SrxihygvHybzBBv6p8uHsKlfkua/8EaSlnc2uFh0cr0moTvr CbiphLzV/dpSOM5Yc3rcLt8AvGwqLkUfIhSpOWHlHB0mxN5UuTNV3jYZr8RFSacZLRDWP4a nFxt86QsGTv3U0IAiJkqkUC3pKogKNuHXHlfInVa58P3Wp2IyCWWygEFNvcG8BBrjhEjP0w vvq8uflylPdWrp6capXs80Vhb5C1+ujSi1TrRPFKjNf7ox26wRib54zJaBe9qK9B28pZ7U8 lobBkmnrOaxanevThYgyRBIsAqOhAQkQ8hSLNxJmJamVRC6zjo6fMJk9eRQ4LIop0Iuj01L dRB9hPzmd/p2tBT8XbwXG761Ry/mHqZVSjAF1ivjvJjheE+/mGbIYtj6MYfXUPPnTA1sMDT 7HMO1Tc32K6wwYOXxcONKpzos2kw+GbwYbZDVBGjPzZ52Lwe9KRV2l5yhHmsQA7P8gkKlU3 fzDQ32R5Y/Rz98d80kusLIVGTofFMgjkvkclRF+gdCg3nfOcvqEYkNy5l7hrb//RbX+WKhZ SJoDbRNqYqjuaLWmKJ1PvRRnXqnsjYvbEvul91vFUT73WcziKOsKkU34yUE/T1CCd1QaHjC edEUZziAb7Sp0YHhS/bG09dOJrbHZc6XNSmWgG7T1saiShzgkUMzGWGCCwuMOaBWT553m5A 2t9nNkxMOv74ufH+7HxE13Fm8mr/r8BZd0oR+ILmPHAzwFOBIVJykQ4evQvjMne8ceDpc/m qyjgRknbyDEN+da0ei4c7uNhLgG2xFGpCc5RXtwTdSQz57k8dsThPPlxkWWNKyEzKjmku1C bwpouzYXwrb7azzcueGDaY2jYDPlHLQpE60NOzroLE/wHfh3H9We8oMohI0wBJHyaPFj6WL 5iTW7Edmv1rt8erukDCYImehvXQ6cTiSgLvdOzXBJ2t60n8jy3Xv2z53kY3JqqutQ== X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index a8f847de8d..d3ac40299f 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1429,7 +1429,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, NGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, NGBE_MACRX65TO127L); @@ -1448,7 +1448,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.48.1