From: "Li, WeiyuanX" <weiyuanx.li@intel.com>
To: "humin (Q)" <humin29@huawei.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Chas Williams <chas3@att.com>,
Hari Kumar Vemula <hari.kumarx.vemula@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: RE: [PATCH] net/bonding: set initial value of descriptor count alignment
Date: Wed, 2 Nov 2022 07:07:57 +0000 [thread overview]
Message-ID: <CH3PR11MB727532272440DA62222FE8ADE4399@CH3PR11MB7275.namprd11.prod.outlook.com> (raw)
In-Reply-To: <d32c8ff0-6594-aba7-2e36-27afa15309de@huawei.com>
> -----Original Message-----
> From: humin (Q) <humin29@huawei.com>
> Sent: Tuesday, November 1, 2022 10:21 AM
> To: Ivan Malov <ivan.malov@oktetlabs.ru>; dev@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>; Chas Williams <chas3@att.com>;
> Hari Kumar Vemula <hari.kumarx.vemula@intel.com>; stable@dpdk.org;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Subject: Re: [PATCH] net/bonding: set initial value of descriptor count
> alignment
>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
>
> 在 2022/10/31 21:17, Ivan Malov 写道:
> > The driver had once been broken by patch [1] looking to have a
> > non-zero "nb_max" value in a use case not involving adding any
> > back-end ports. That was addressed afterwards ([2]). But, as per
> > report [3], similar test cases exist which attempt to setup Rx queues
> > on a void bond before attaching any back-end ports. Rx queue setup, in
> > turn, involves device info get API invocation, and one of the checks
> > on received data causes an exception (division by zero). The
> > "nb_align" value is indeed zero at that time, but, as explained in
> > [2], such test cases are totally incorrect since a bond device must
> > have at least one back-end port plugged before any ethdev APIs can be
> > used.
> >
> > Once again, to avoid any problems with fixing the test cases, this
> > patch adjusts the bond PMD itself to workaround the bug.
> >
> > [1] commit 5be3b40fea60 ("net/bonding: fix values of descriptor
> > limits") [2] commit d03c0e83cc00 ("net/bonding: fix descriptor limit
> > reporting") [3] https://bugs.dpdk.org/show_bug.cgi?id=1118
> >
> > Fixes: d03c0e83cc00 ("net/bonding: fix descriptor limit reporting")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
This patch needs to be applied additionally https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.malov@oktetlabs.ru/ can be verified to pass
next prev parent reply other threads:[~2022-11-02 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 13:17 Ivan Malov
2022-11-01 2:21 ` humin (Q)
2022-11-02 7:07 ` Li, WeiyuanX [this message]
2022-11-06 9:40 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR11MB727532272440DA62222FE8ADE4399@CH3PR11MB7275.namprd11.prod.outlook.com \
--to=weiyuanx.li@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=hari.kumarx.vemula@intel.com \
--cc=humin29@huawei.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).