From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE4AE43BA7 for ; Thu, 7 Mar 2024 10:44:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0BA440295; Thu, 7 Mar 2024 10:44:50 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by mails.dpdk.org (Postfix) with ESMTP id 788FA40272 for ; Thu, 7 Mar 2024 10:44:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPKutRuW+2I0/UzZut5P3JSPvCLYfLf0PutriRQhYHhT3jJK+KLYV2cDyqJNte7xnlGFdbtUIkxbXzO83CQngI4stDjnrOSs8mmL0/+UfmgSJpLw+/QChNBJyIoAGlYjLk7dyWO29o6sEM2DiX7xXJ3+XREVM017McIcpJJPz+PDErG+AqOXcEjHIFWvQ19DHSRHriFBb78QjwDMQWO7W1Pi8wWzUPgmmTFyMse+H2JPFsHWaWxakfRrnFE5zZWam2EKpehGFLDbJBS8yAkqilvqzCTJ3ky/1+zz2vbOKX0zSubqmROcru8PVAc8ufCBYEbcWUS022z5B99xHIvHSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJ5XSZUXgr0q50EKzInAhl8+gNAZP8aqAFPaMzHmcl4=; b=RWE5y83VrAn2VB0wyXukX8Umi5/gKyH3XGRGW+sPiariD41Xb6Tk3fWAEcY+hAKpszz5Vpi4+Zi5Mm3wkkF315FZwbgVsYxhAzH6DX57iKaE+DHRZdSkR592sHnmh50QpWn5F5zkVxIBNXgQlQK/upfGMoGP7y3BJ0ygpNb54NXu7iWpjCLN6D6IV1mdOyQ1ZqesI+0Nyu21PDk56TLv9EPo9hlSQz3LdawpkBNgiZvYmvcNv8jbWj1V+AojPAAN6NK9N7zkhVPtF30hVaEf33tREdPyGJyR4tQaFfwvftajnui/+4BEcORjhP9aEoiZRq6OATrtEUarbehts4y3mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJ5XSZUXgr0q50EKzInAhl8+gNAZP8aqAFPaMzHmcl4=; b=zk+P0Ce29U6qLnA/JTctRXqRD0Uk8ek5L7XrYJit82voGJBuRR5WeBITjrATkOWMKS235fh28urTisVV6TMda8o05v/Z2GIcWPwfzRaO2oyWzus/k/JT3pXKvZ5om5WR/HytLkBBAYCFX4smXh8Z9fhjj9I61lZ+D7YbSIpqTOQ= Received: from CH3PR12MB8233.namprd12.prod.outlook.com (2603:10b6:610:129::15) by SJ0PR12MB6685.namprd12.prod.outlook.com (2603:10b6:a03:478::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 7 Mar 2024 09:44:47 +0000 Received: from CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::56c9:d5f3:2cb3:d9f2]) by CH3PR12MB8233.namprd12.prod.outlook.com ([fe80::56c9:d5f3:2cb3:d9f2%4]) with mapi id 15.20.7362.024; Thu, 7 Mar 2024 09:44:46 +0000 From: "Tummala, Sivaprasad" To: "luca.boccassi@gmail.com" CC: "Yigit, Ferruh" , dpdk stable Subject: RE: patch 'eal/x86: add AMD vendor check for TSC calibration' has been queued to stable release 22.11.5 Thread-Topic: patch 'eal/x86: add AMD vendor check for TSC calibration' has been queued to stable release 22.11.5 Thread-Index: AQHacC9zz8VWv62MSUulmQI+7mFpO7EsB2Mg Date: Thu, 7 Mar 2024 09:44:46 +0000 Message-ID: References: <20240307013159.1735343-1-luca.boccassi@gmail.com> <20240307013159.1735343-19-luca.boccassi@gmail.com> In-Reply-To: <20240307013159.1735343-19-luca.boccassi@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=aa2840c2-1e06-44c4-ae0c-51c5503ae1ed; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-07T09:43:16Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB8233:EE_|SJ0PR12MB6685:EE_ x-ms-office365-filtering-correlation-id: 0bf88707-4b1e-4247-3a1c-08dc3e8b3995 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L/ZGBxqdrzjjCLOvtMfjYIPjt6dQ99l1lpKnZ7dA/O0b0z+yWEOpXMArsLDwauYwiQv5YVpHGskMs9v07hBgTW9COXiHGzflwcT3I2DW1cgYt17dDI6jE2+BbZpSJMux1IM6OeLOze3aRMPZtNSvKGJgosy9XZLaCnffEP/M8PRpySKi5nqkhRcXuRdRdVkLuYOGJu4G8uaRezUQY6nmzsvVafAWLpyFsR6gP23kH1WqEnEVSemlWdRgLn3yLB55HFZntZWt/ZeHS+Rbfc//OOLr9ucZAl1R8zfCe641n8rhbCgMgK6+6vTGa2UU1Cb3sfrzQTw8I7Bq9qUpUYsCR9iMxkZLyYwpGVA9tt4CWaTQr4iMdp6cTE8PHS4DarKpcoboW23CbKmHnvtPV23izsGPdkcY4cGN7DJmo5UgCpixRTCo8fGqX5Sg2vA91z39PVXpr18rSU8Xf8FoQ2BLb9/t/QaW7qN/MkfevSyBgTcHSkRUHur6pFTvUN5kVcWHBEGPIWdzs3BYw6k7k6Przy/uH6cgNSDkZWyNB1gwIMfGElmuYEx9s36EtWYU/mqFwOxQhEaeIAYkD7q3McxKBDhCmSZ6Isv3fEC0FWHm6tdqAySIgV++L8z7jbAqUVgnPVszdwhV6qYK+XFK9v01PghZ2SlOeeJ4V7u3ByrnicfFI7vuQIwP2irS07kjpT8e x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8233.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jjtitr7sYyZFRQCmtLpGKAKpfDB4z6/7AjUKiEOUsW3NR90C9z52PId9u/rG?= =?us-ascii?Q?BjzMoHxw+fHkqoVWcDIpfYdx5yMQ4YbpDHUsIakCq2Ro7LMCd7qv0JUyV5eu?= =?us-ascii?Q?84Mt5KqMiT88PR0zwFi9By4pryerTm4/BU45vYNxz47oI8fsc0zqi9LdOXpX?= =?us-ascii?Q?9TmieHbl2xpVmaLLbWUzEbP41IMai08a45ToeDHDXHJPCdVwazZt91ivT5LB?= =?us-ascii?Q?2sMIQVwXXzqP1Ax3xdW6vFhZsa7Trgxte4Y3ONJRyb43Y7AMyXESFwmhraVF?= =?us-ascii?Q?k0srPvBGnMAx9tesaN/xw6+h92iNLXzoYaGp460JxBT5vqqmCt7Bx9a67fkl?= =?us-ascii?Q?ThyJzBdtQN7dQL8R5cF8lO3GDbMX7D2iwNwCnpPrI3Fxy09OH2tXuBoe6B11?= =?us-ascii?Q?xJnqSpX6iYEgXEouiuOVhRLcxjOrdXjmKqKUwxMFjKUK+r23nV9O/wZaTTiJ?= =?us-ascii?Q?qTOvHXskYMDoQ0KgEs8Gylm5NoEARD6abOGyU0Euo32ffTQQ2+hc4EmH8ghM?= =?us-ascii?Q?fFtYjMztkG4N0LSpUDnNEglu3pJyXYZ9njnLAdA0tZ4HCNIWKtFycF9q7TPv?= =?us-ascii?Q?z/mlXfG2mDyDv3XDJtEHqZglDSe93aTVTEujO/2i8D4LnhQHcAPynI8V0X8a?= =?us-ascii?Q?d2aj1JbUt18icEUu4VCBpf/ZGhc462pVH8sv2vfKq9ouk2Lfv3L3BVILBEdv?= =?us-ascii?Q?Fl9+ZNi3g8d/m9aUlaINa8VvsndXiZJUVqYENq6B93ehZfYdTPcpd+sMnCo7?= =?us-ascii?Q?5aLFQa2EW87JtE5CIHKbYLmvHAx13fuwZ9Zs2SnNVABfch68VD9rIgkYvQTq?= =?us-ascii?Q?0XuGESo8OTGX2E//Dhavr74U7uizCurQfafR9CxO8oIaU2+E+EhKAMdV6V3B?= =?us-ascii?Q?ryWDVuO/NWgNG7creohTZ3GULKAJtOdTy4g93EaIamjeTkr4tLLsAwKn1BHE?= =?us-ascii?Q?lySC5QIR8JB+mstdtpzRcIIX8jPxQlnX0ruO+RAoy/ghbYUwK3n+u0T9td9O?= =?us-ascii?Q?7iXRMXcYFqbOcd+1Ebs5whk2xm7MhaljV/Jt0ie9Du0ytLr2GKvH4BHboGoI?= =?us-ascii?Q?5c/27KRdHJDOsESzgBz3/LAbhrqHMJDg0r6nphMRxemJZIBDSQW5L2Yerjko?= =?us-ascii?Q?IFsFdTFaWGpVvNQdpJ3rPK2WF8t89f07F8atIxmPAkgx3lSINlEVZf3pUNha?= =?us-ascii?Q?k9dyHCWbpVVtWPusb0JgwmrwZbC/GrqHszs3PvAwV7K5+Enx6gYKvMXG3fEr?= =?us-ascii?Q?A1oybr+LvEDMfNKO7iBDud0allmTO+3cjYl0xBn+C36F8+WEzIybTKrlFxbU?= =?us-ascii?Q?T6ml8JmJGP+rE1VZDrDybPKILRaUoeubgHKZ9pMwiMk1lgaZivyc5yM8lN24?= =?us-ascii?Q?AdzZlBNyJgUvYVC/laPDUAgGMTM3pdqM9DeFrbCcjrTuIfdoAf8zGMZvKHKD?= =?us-ascii?Q?9cGz7yjM/+m/z5EqN+noUWwbjcMQQ/+3DFMdDZefVlw1XBggngQkH9MiY6ve?= =?us-ascii?Q?MXXMrwaJeGL758OiDuq2ruaCRV8SL5ECuGeRS3ToF/wqDX9vKHA/kdUkvqwY?= =?us-ascii?Q?aTY2zFwhyHofLFpsRwE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8233.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf88707-4b1e-4247-3a1c-08dc3e8b3995 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2024 09:44:46.6925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 39D2H3xWxY+vdtQuXkYwXs5Fi80+tslKO9yn64FAWVaUQNmvU8P1AlIBPOuZ8ByB4+6RFFRc6CjzZA5yCBvhOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6685 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [AMD Official Use Only - General] Hi Luca, LGTM! Thanks & Regards, Sivaprasad > -----Original Message----- > From: luca.boccassi@gmail.com > Sent: Thursday, March 7, 2024 7:01 AM > To: Tummala, Sivaprasad > Cc: Yigit, Ferruh ; dpdk stable > Subject: patch 'eal/x86: add AMD vendor check for TSC calibration' has be= en > queued to stable release 22.11.5 > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi, > > FYI, your patch has been queued to stable release 22.11.5 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 03/09/24. So please shout= if anyone > has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he patch > applied to the branch. This will indicate if there was any rebasing neede= d to apply > to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was co= rrectly > done. > > Queued patches are on a temporary branch at: > https://github.com/bluca/dpdk-stable > > This queued commit can be viewed at: > https://github.com/bluca/dpdk- > stable/commit/3c9e08f6d3f60301e5c3dad1ff4ee1731b000dda > > Thanks. > > Luca Boccassi > > --- > From 3c9e08f6d3f60301e5c3dad1ff4ee1731b000dda Mon Sep 17 00:00:00 2001 > From: Sivaprasad Tummala > Date: Wed, 22 Nov 2023 23:27:30 -0800 > Subject: [PATCH] eal/x86: add AMD vendor check for TSC calibration > > [ upstream commit 31d72ff4dc7c057366153e9918ac92bf9123a3bc ] > > AMD Epyc processors doesn't support get_tsc_freq_arch(). > The patch allows graceful return to allow fallback to alternate TSC calib= ration. > > Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC frequency query") > > Signed-off-by: Sivaprasad Tummala > Acked-by: Ferruh Yigit > --- > lib/eal/x86/rte_cycles.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/eal/x86/rte_cycles.c b/lib/eal/x86/rte_cycles.c index > 0e695caf28..2a601d7035 100644 > --- a/lib/eal/x86/rte_cycles.c > +++ b/lib/eal/x86/rte_cycles.c > @@ -6,6 +6,10 @@ > #include > #include > > +#define x86_vendor_amd(t1, t2, t3) \ > + ((t1 =3D=3D 0x68747541) && /* htuA */ \ > + (t2 =3D=3D 0x444d4163) && /* DMAc */ \ > + (t3 =3D=3D 0x69746e65)) /* itne */ > > #include "eal_private.h" > > @@ -90,6 +94,18 @@ get_tsc_freq_arch(void) > uint8_t mult, model; > int32_t ret; > > +#ifdef RTE_TOOLCHAIN_MSVC > + __cpuid(cpuinfo, 0); > + a =3D cpuinfo[0]; > + b =3D cpuinfo[1]; > + c =3D cpuinfo[2]; > + d =3D cpuinfo[3]; > +#else > + __cpuid(0, a, b, c, d); > +#endif > + if (x86_vendor_amd(b, c, d)) > + return 0; > + > /* > * Time Stamp Counter and Nominal Core Crystal Clock > * Information Leaf > -- > 2.39.2 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n-empty: > --- > --- - 2024-03-07 01:05:36.676799989 +0000 > +++ 0019-eal-x86-add-AMD-vendor-check-for-TSC-calibration.patch > +++ 2024-03-07 01:05:34.694937810 +0000 > @@ -1 +1 @@ > -From 31d72ff4dc7c057366153e9918ac92bf9123a3bc Mon Sep 17 00:00:00 2001 > +From 3c9e08f6d3f60301e5c3dad1ff4ee1731b000dda Mon Sep 17 00:00:00 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 31d72ff4dc7c057366153e9918ac92bf9123a3bc ] > + > @@ -11 +12,0 @@ > -Cc: stable@dpdk.org > @@ -20 +21 @@ > -index 69ed59b4f0..f147a5231d 100644 > +index 0e695caf28..2a601d7035 100644 > @@ -23 +24,2 @@ > -@@ -10,6 +10,10 @@ > +@@ -6,6 +6,10 @@ > + #include > @@ -25 +26,0 @@ > - #endif > @@ -34 +35 @@ > -@@ -110,6 +114,18 @@ get_tsc_freq_arch(void) > +@@ -90,6 +94,18 @@ get_tsc_freq_arch(void)